| Message ID | 20231117143506.1521718-3-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | UI: fix default VC regressions | expand |
On 17/11/2023 15.35, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Those display have their own implementation of "vc" chardev, which > doesn't use pixman. They also don't implement the width/height/cols/rows > options, so qemu_display_get_vc() should return a compatible argument. > > This patch was meant to be with the pixman series, when the "vc" field > was introduced. It fixes a regression where VC are created on the > tty (or null) instead of the display own "vc" implementation. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > ui/dbus.c | 1 + > ui/gtk.c | 1 + > ui/spice-app.c | 1 + > 3 files changed, 3 insertions(+) FWIW, Acked-by: Thomas Huth <thuth@redhat.com>
diff --git a/ui/dbus.c b/ui/dbus.c index 866467ad2e..e08b5de064 100644 --- a/ui/dbus.c +++ b/ui/dbus.c @@ -518,6 +518,7 @@ static QemuDisplay qemu_display_dbus = { .type = DISPLAY_TYPE_DBUS, .early_init = early_dbus_init, .init = dbus_init, + .vc = "vc", }; static void register_dbus(void) diff --git a/ui/gtk.c b/ui/gtk.c index be047a41ad..810d7fc796 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -2534,6 +2534,7 @@ static QemuDisplay qemu_display_gtk = { .type = DISPLAY_TYPE_GTK, .early_init = early_gtk_display_init, .init = gtk_display_init, + .vc = "vc", }; static void register_gtk(void) diff --git a/ui/spice-app.c b/ui/spice-app.c index 405fb7f9f5..a10b4a58fe 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -220,6 +220,7 @@ static QemuDisplay qemu_display_spice_app = { .type = DISPLAY_TYPE_SPICE_APP, .early_init = spice_app_display_early_init, .init = spice_app_display_init, + .vc = "vc", }; static void register_spice_app(void)