| Message ID | 20231122004219.3504219-1-samuel.holland@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [net] net: axienet: Fix check for partial TX checksum | expand |
On Tue, Nov 21, 2023 at 04:42:17PM -0800, Samuel Holland wrote: > Due to a typo, the code checked the RX checksum feature in the TX path. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
> -----Original Message----- > From: Samuel Holland <samuel.holland@sifive.com> > Sent: Wednesday, November 22, 2023 6:12 AM > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com> > Cc: Samuel Holland <samuel.holland@sifive.com>; Ariane Keller > <ariane.keller@tik.ee.ethz.ch>; Daniel Borkmann <daniel@iogearbox.net>; > David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Simek, Michal > <michal.simek@amd.com>; Paolo Abeni <pabeni@redhat.com>; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > netdev@vger.kernel.org > Subject: [PATCH net] net: axienet: Fix check for partial TX checksum > > Due to a typo, the code checked the RX checksum feature in the TX path. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet > driver") > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Thanks! > --- > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index 82d0d44b2b02..bf6e33990490 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct > net_device *ndev) > if (lp->features & XAE_FEATURE_FULL_TX_CSUM) { > /* Tx Full Checksum Offload Enabled */ > cur_p->app0 |= 2; > - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) { > + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) { > csum_start_off = skb_transport_offset(skb); > csum_index_off = csum_start_off + skb- > >csum_offset; > /* Tx Partial Checksum Offload Enabled */ > -- > 2.42.0
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 21 Nov 2023 16:42:17 -0800 you wrote: > Due to a typo, the code checked the RX checksum feature in the TX path. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> > --- > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: axienet: Fix check for partial TX checksum https://git.kernel.org/netdev/net/c/fd0413bbf8b1 You are awesome, thank you!
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 82d0d44b2b02..bf6e33990490 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) if (lp->features & XAE_FEATURE_FULL_TX_CSUM) { /* Tx Full Checksum Offload Enabled */ cur_p->app0 |= 2; - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) { + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) { csum_start_off = skb_transport_offset(skb); csum_index_off = csum_start_off + skb->csum_offset; /* Tx Partial Checksum Offload Enabled */
Due to a typo, the code checked the RX checksum feature in the TX path. Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") Signed-off-by: Samuel Holland <samuel.holland@sifive.com> --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)