diff mbox series

wifi: ath10k: Remove unused struct ath10k_htc_frame

Message ID 20231103-ath10k_htc_frame-v1-1-ff00b38a9630@quicinc.com (mailing list archive)
State Accepted
Commit 2bc76fef1a9a649e11b2dac6205bb8177128fc21
Delegated to: Kalle Valo
Headers show
Series wifi: ath10k: Remove unused struct ath10k_htc_frame | expand

Commit Message

Jeff Johnson Nov. 3, 2023, 10:05 p.m. UTC
struct ath10k_htc_frame is unused, and since it illogically contains
two consecutive flexible arrays, it could never be used, so remove it.

No functional changes, compile tested only.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/net/wireless/ath/ath10k/htc.h | 13 -------------
 1 file changed, 13 deletions(-)


---
base-commit: ac2f43d3d34e52b0d388b4c573ff6bbac90235b9
change-id: 20231025-ath10k_htc_frame-16d8e43f796d

Comments

Kalle Valo Nov. 22, 2023, 6:23 p.m. UTC | #1
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> struct ath10k_htc_frame is unused, and since it illogically contains
> two consecutive flexible arrays, it could never be used, so remove it.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

2bc76fef1a9a wifi: ath10k: Remove unused struct ath10k_htc_frame
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h
index 0d180faf3b77..0eaa21ad86ac 100644
--- a/drivers/net/wireless/ath/ath10k/htc.h
+++ b/drivers/net/wireless/ath/ath10k/htc.h
@@ -253,19 +253,6 @@  struct ath10k_htc_record {
 	};
 } __packed __aligned(4);
 
-/*
- * note: the trailer offset is dynamic depending
- * on payload length. this is only a struct layout draft
- */
-struct ath10k_htc_frame {
-	struct ath10k_htc_hdr hdr;
-	union {
-		struct ath10k_htc_msg msg;
-		u8 payload[0];
-	};
-	struct ath10k_htc_record trailer[0];
-} __packed __aligned(4);
-
 /*******************/
 /* Host-side stuff */
 /*******************/