| Message ID | 20231127051414.3783108-2-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: panel: Check device dependency before managing device link | expand |
Greg, Rafael, On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > Export device_is_dependent() since the drm_kms_helper module is starting > to use it. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v2: > * Newly introduced as needed by patch 2. > > drivers/base/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 67ba592afc77..bfd2bf0364b7 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) > } > return ret; > } > +EXPORT_SYMBOL_GPL(device_is_dependent); So, a committer just applied this to drm-misc-fixes without your approval. Could you ack it? If you don't want to, we'll fix it. Maxime
On Mon, Nov 27, 2023 at 05:38:13PM +0100, Maxime Ripard wrote: > Greg, Rafael, > > On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > > Export device_is_dependent() since the drm_kms_helper module is starting > > to use it. > > > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > --- > > v2: > > * Newly introduced as needed by patch 2. > > > > drivers/base/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/base/core.c b/drivers/base/core.c > > index 67ba592afc77..bfd2bf0364b7 100644 > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) > > } > > return ret; > > } > > +EXPORT_SYMBOL_GPL(device_is_dependent); > > So, a committer just applied this to drm-misc-fixes without your > approval. Could you ack it? If you don't want to, we'll fix it. Wait, why exactly is this needed? Nothing outside of the driver core should be needing this function, it shouldn't be public at all (I missed that before.) So please, revert it for now, let's figure out why DRM thinks this is needed for it's devices, and yet no other bus/subsystem does. thanks, greg k-h
On Mon, Nov 27, 2023 at 7:20 PM Greg KH <gregkh@linuxfoundation.org> wrote: [Maxime] > > So, a committer just applied this to drm-misc-fixes without your > > approval. That was me, mea culpa. I learned a lesson. Or two. > Wait, why exactly is this needed? Nothing outside of the driver core > should be needing this function, it shouldn't be public at all (I missed > that before.) > > So please, revert it for now, let's figure out why DRM thinks this is > needed for it's devices, and yet no other bus/subsystem does. I'm preparing a revert series back to the original patch causing the issue so we can clear the original bug out of the way, take a step back and fix this properly. Yours, Linus Walleij
diff --git a/drivers/base/core.c b/drivers/base/core.c index 67ba592afc77..bfd2bf0364b7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) } return ret; } +EXPORT_SYMBOL_GPL(device_is_dependent); static void device_link_init_status(struct device_link *link, struct device *consumer,
Export device_is_dependent() since the drm_kms_helper module is starting to use it. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v2: * Newly introduced as needed by patch 2. drivers/base/core.c | 1 + 1 file changed, 1 insertion(+)