| Message ID | 20231128104723.20622-9-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] drm/plane-helper: Move drm_plane_helper_atomic_check() into udl | expand |
Hi Thomas, Thank you for the patch. On Tue, Nov 28, 2023 at 11:45:24AM +0100, Thomas Zimmermann wrote: > Remove unnecessary include statements for <drm/drm_plane_helper.h>. > The file contains helpers for non-atomic code and should not be > required by most drivers. No functional changes. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Assuming you've compile-tested the driver, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Please get this merged through drm-misc as part of the series if possible. > --- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c > index a7f8611be6f42..db3bb4afbfc46 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c > @@ -27,7 +27,6 @@ > #include <drm/drm_managed.h> > #include <drm/drm_mode_config.h> > #include <drm/drm_plane.h> > -#include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_simple_kms_helper.h> > #include <drm/drm_vblank.h>
Hi Am 28.11.23 um 12:02 schrieb Laurent Pinchart: > Hi Thomas, > > Thank you for the patch. > > On Tue, Nov 28, 2023 at 11:45:24AM +0100, Thomas Zimmermann wrote: >> Remove unnecessary include statements for <drm/drm_plane_helper.h>. >> The file contains helpers for non-atomic code and should not be >> required by most drivers. No functional changes. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Assuming you've compile-tested the driver, I've COMPILE_TEST'ed the driver on aarch64. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Please get this merged through drm-misc as part of the series if > possible. Sure. Best regards Thomas > >> --- >> drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c >> index a7f8611be6f42..db3bb4afbfc46 100644 >> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c >> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c >> @@ -27,7 +27,6 @@ >> #include <drm/drm_managed.h> >> #include <drm/drm_mode_config.h> >> #include <drm/drm_plane.h> >> -#include <drm/drm_plane_helper.h> >> #include <drm/drm_probe_helper.h> >> #include <drm/drm_simple_kms_helper.h> >> #include <drm/drm_vblank.h> >
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index a7f8611be6f42..db3bb4afbfc46 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -27,7 +27,6 @@ #include <drm/drm_managed.h> #include <drm/drm_mode_config.h> #include <drm/drm_plane.h> -#include <drm/drm_plane_helper.h> #include <drm/drm_probe_helper.h> #include <drm/drm_simple_kms_helper.h> #include <drm/drm_vblank.h>
Remove unnecessary include statements for <drm/drm_plane_helper.h>. The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 - 1 file changed, 1 deletion(-)