| Message ID | b649ade5b712e47f4b4b3793943fa304edb26bba.1701183605.git.josef@toxicpanda.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: fix compile error with !CONFIG_BTRFS_FS_POSIX_ACL | expand |
On Tue, Nov 28, 2023 at 10:00:59AM -0500, Josef Bacik wrote: > I accidentally introduced a compile error with > !CONFIG_BTRFS_FS_POSIX_ACL in my mount api v2 patches. Fix this by just > returning -EINVAL. > > Fixes: ed6a5b9bae38 ("btrfs: add parse_param callback for the new mount api") > Signed-off-by: Josef Bacik <josef@toxicpanda.com> > --- > The fixes tag isn't useful because it's in my local branch, I put it in there so > you have the title to fold this into the actual patch that introduced the > problem. Yeah I use the title to find the patches, you can still use the Fixes: tag as it'a common format. The mount API switch is in a topic branch, I'll move it to misc-next soon.
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 8ce7c880e9ce..63dcb7f7b42c 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -413,8 +413,7 @@ static int btrfs_parse_param(struct fs_context *fc, fc->sb_flags |= SB_POSIXACL; #else btrfs_err(NULL, "support for ACL not compiled in!"); - ret = -EINVAL; - goto out; + return -EINVAL; #endif } /*
I accidentally introduced a compile error with !CONFIG_BTRFS_FS_POSIX_ACL in my mount api v2 patches. Fix this by just returning -EINVAL. Fixes: ed6a5b9bae38 ("btrfs: add parse_param callback for the new mount api") Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- The fixes tag isn't useful because it's in my local branch, I put it in there so you have the title to fold this into the actual patch that introduced the problem. fs/btrfs/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)