diff mbox series

[v4,2/2] ASoC: dt-bindings: audio-graph-port: Document new DAI link flags playback-only/capture-only

Message ID 20231128081119.106360-3-daniel.baluta@oss.nxp.com (mailing list archive)
State Accepted
Commit af29e51bee8223d8b26e574489d2433b88cdeb2f
Headers show
Series ASoC: audio-graph-card2: Introduce playback-only/capture-only DAI link flags | expand

Commit Message

Daniel Baluta (OSS) Nov. 28, 2023, 8:11 a.m. UTC
From: Daniel Baluta <daniel.baluta@nxp.com>

Document new playback-only and capture-only flags which can be used
when dai link can only support just one direction: playback or capture
but not both.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 .../devicetree/bindings/sound/audio-graph-port.yaml         | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Nov. 29, 2023, 2:54 p.m. UTC | #1
On Tue, Nov 28, 2023 at 10:11:19AM +0200, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
> 
> Document new playback-only and capture-only flags which can be used
> when dai link can only support just one direction: playback or capture
> but not both.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  .../devicetree/bindings/sound/audio-graph-port.yaml         | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 60b5e3fd1115..b13c08de505e 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -19,6 +19,12 @@ definitions:
>      properties:
>        mclk-fs:
>          $ref: simple-card.yaml#/definitions/mclk-fs
> +      playback-only:
> +        description: port connection used only for playback
> +        $ref: /schemas/types.yaml#/definitions/flag
> +      capture-only:
> +        description: port connection used only for capture
> +        $ref: /schemas/types.yaml#/definitions/flag

It seems like we have a random mix of port and endpoint properties here 
and I can't tell what's the logic for deciding the right place. 
Everything in port is also in endpoint, so maybe using port is 
deprecated. In most cases for graph bindings, we put properties in 
endpoint nodes.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 60b5e3fd1115..b13c08de505e 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -19,6 +19,12 @@  definitions:
     properties:
       mclk-fs:
         $ref: simple-card.yaml#/definitions/mclk-fs
+      playback-only:
+        description: port connection used only for playback
+        $ref: /schemas/types.yaml#/definitions/flag
+      capture-only:
+        description: port connection used only for capture
+        $ref: /schemas/types.yaml#/definitions/flag
 
   endpoint-base:
     allOf: