| Message ID | 20231129064311.272422-2-acelan.kao@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7a030abc0185b30a3fd19a7431347c6f5a82c588 |
| Headers | show |
| Series | [v7,1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP | expand |
On 11/29/23 06:43, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > Hi, > When the software reset command isn't supported, we now stop reporting > the warning message to avoid unnecessary warnings and potential confusion. > > Reviewed-by: Dhruva Gole <d-gole@ti.com> > Reviewed-by: Michael Walle <michael@walle.cc> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Acked-by: Pratyush Yadav <pratyush@kernel.org> > Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com> You haven't specified who shall take these patches. Is it fine for you if I take just the SPI NOR bits? If you want Mark to queue both: Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org> > > --- > v2. only lower the priority for the not supported failure > v3. replace ENOTSUPP with EOPNOTSUPP and check the first command only > v4. move the version information below the '---' line > v5. remove dev_warn if soft reset operation is not supported > --- > drivers/mtd/spi-nor/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 87cb2047df80..96a207751cf2 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -3237,7 +3237,8 @@ static void spi_nor_soft_reset(struct spi_nor *nor) > > ret = spi_mem_exec_op(nor->spimem, &op); > if (ret) { > - dev_warn(nor->dev, "Software reset failed: %d\n", ret); > + if (ret != -EOPNOTSUPP) > + dev_warn(nor->dev, "Software reset failed: %d\n", ret); > return; > } >
Hi AceLan, acelan.kao@canonical.com wrote on Wed, 29 Nov 2023 14:43:11 +0800: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > When the software reset command isn't supported, we now stop reporting > the warning message to avoid unnecessary warnings and potential confusion. > > Reviewed-by: Dhruva Gole <d-gole@ti.com> > Reviewed-by: Michael Walle <michael@walle.cc> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Acked-by: Pratyush Yadav <pratyush@kernel.org> > Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On Wed, Nov 29, 2023 at 07:46:02AM +0000, Tudor Ambarus wrote: > You haven't specified who shall take these patches. Is it fine for you > if I take just the SPI NOR bits? If you want Mark to queue both: I can certainly take both. I guess there's no build time dependency so we could each take the subsystem specific patch, though there'd be some bisection drift if that happens?
Mark Brown <broonie@kernel.org> 於 2023年11月30日 週四 上午5:19寫道： > > On Wed, Nov 29, 2023 at 07:46:02AM +0000, Tudor Ambarus wrote: > > > You haven't specified who shall take these patches. Is it fine for you > > if I take just the SPI NOR bits? If you want Mark to queue both: > > I can certainly take both. I guess there's no build time dependency so > we could each take the subsystem specific patch, though there'd be some > bisection drift if that happens? Hi Mark, It'd be better if you could take both of them. Thanks.
On 11/29/23 21:19, Mark Brown wrote: > On Wed, Nov 29, 2023 at 07:46:02AM +0000, Tudor Ambarus wrote: > >> You haven't specified who shall take these patches. Is it fine for you >> if I take just the SPI NOR bits? If you want Mark to queue both: > > I can certainly take both. I guess there's no build time dependency so > we could each take the subsystem specific patch, though there'd be some > bisection drift if that happens? Right, please take both then. Thanks!
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 87cb2047df80..96a207751cf2 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3237,7 +3237,8 @@ static void spi_nor_soft_reset(struct spi_nor *nor) ret = spi_mem_exec_op(nor->spimem, &op); if (ret) { - dev_warn(nor->dev, "Software reset failed: %d\n", ret); + if (ret != -EOPNOTSUPP) + dev_warn(nor->dev, "Software reset failed: %d\n", ret); return; }