| Message ID | IA1PR20MB495399CAF2EEECC206ADA7ABBBD5A@IA1PR20MB4953.namprd20.prod.outlook.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Huashan Pi board support | expand |
Hey, On Thu, Oct 19, 2023 at 07:18:00AM +0800, Inochi Amaoto wrote: > Huashan Pi board is an embedded development platform based on the > CV1812H chip. Add minimal device tree files for this board. > Currently, it can boot to a basic shell. Just pointing out that this series is too late for v6.7, so you probably won't hear anything from me until v6.7-rc1 has been tagged. Cheers, Conor. > > NOTE: this series is based on the Jisheng's Milk-V Duo patch. > > Link: https://en.sophgo.com/product/introduce/huashan.html > Link: https://en.sophgo.com/product/introduce/cv181xH.html > Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ > > Changed from v3: > 1. merge the patch 4 and 5 of v2 to preserve bisectability. > > Changed from v2: > 1. use dt override to save code. > 2. code cleanup. > > Changed from v1: > 1. split the patch into several patch and refactor them. > > Inochi Amaoto (7): > dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic > dt-bindings: timer: Add SOPHGO CV1812H clint > dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles > riscv: dts: sophgo: Separate compatible specific for CV1800B soc > riscv: dts: sophgo: cv18xx: Add gpio devices > riscv: dts: sophgo: add initial CV1812H SoC device tree > riscv: dts: sophgo: add Huashan Pi board device tree > > .../sifive,plic-1.0.0.yaml | 1 + > .../devicetree/bindings/riscv/sophgo.yaml | 4 + > .../bindings/timer/sifive,clint.yaml | 1 + > arch/riscv/boot/dts/sophgo/Makefile | 1 + > arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 119 +---------- > .../boot/dts/sophgo/cv1812h-huashan-pi.dts | 48 +++++ > arch/riscv/boot/dts/sophgo/cv1812h.dtsi | 24 +++ > arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 193 ++++++++++++++++++ > 8 files changed, 279 insertions(+), 112 deletions(-) > create mode 100644 arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts > create mode 100644 arch/riscv/boot/dts/sophgo/cv1812h.dtsi > create mode 100644 arch/riscv/boot/dts/sophgo/cv18xx.dtsi > > -- > 2.42.0 >
From: Conor Dooley <conor.dooley@microchip.com> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: > Huashan Pi board is an embedded development platform based on the > CV1812H chip. Add minimal device tree files for this board. > Currently, it can boot to a basic shell. > > NOTE: this series is based on the Jisheng's Milk-V Duo patch. > > Link: https://en.sophgo.com/product/introduce/huashan.html > Link: https://en.sophgo.com/product/introduce/cv181xH.html > Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ > > [...] Applied to riscv-dt-for-next, thanks! LMK if something looks not as expected. [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic https://git.kernel.org/conor/c/21a34e63afcc [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint https://git.kernel.org/conor/c/06ea2a1968a9 [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles https://git.kernel.org/conor/c/d7b92027834e [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc https://git.kernel.org/conor/c/5b5dce3951b2 [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices https://git.kernel.org/conor/c/dd791b45c866 [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree https://git.kernel.org/conor/c/681ec684a741 [7/7] riscv: dts: sophgo: add Huashan Pi board device tree https://git.kernel.org/conor/c/2c36b0cfb408 Thanks, Conor.
> >On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >> Huashan Pi board is an embedded development platform based on the >> CV1812H chip. Add minimal device tree files for this board. >> Currently, it can boot to a basic shell. >> >> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >> >> Link: https://en.sophgo.com/product/introduce/huashan.html >> Link: https://en.sophgo.com/product/introduce/cv181xH.html >> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >> >> [...] > >Applied to riscv-dt-for-next, thanks! LMK if something looks not as >expected. > >[1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic > https://git.kernel.org/conor/c/21a34e63afcc >[2/7] dt-bindings: timer: Add SOPHGO CV1812H clint > https://git.kernel.org/conor/c/06ea2a1968a9 >[3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles > https://git.kernel.org/conor/c/d7b92027834e >[4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc > https://git.kernel.org/conor/c/5b5dce3951b2 >[5/7] riscv: dts: sophgo: cv18xx: Add gpio devices > https://git.kernel.org/conor/c/dd791b45c866 >[6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree > https://git.kernel.org/conor/c/681ec684a741 >[7/7] riscv: dts: sophgo: add Huashan Pi board device tree > https://git.kernel.org/conor/c/2c36b0cfb408 > >Thanks, >Conor. > Hi Conor, Thanks for the confirmation. But I suggest to revert these patches. Several days ago, Sophgo informed me that CV1810 series will be renamed. And the Huashan Pi will switch to the chip with new name. To avoid unnecessary conflict, please drop these patch and I will prepare a new patch once the renamed chip is launched. Sorry for this inconvenience.
On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: > > > >On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: > >> Huashan Pi board is an embedded development platform based on the > >> CV1812H chip. Add minimal device tree files for this board. > >> Currently, it can boot to a basic shell. > >> > >> NOTE: this series is based on the Jisheng's Milk-V Duo patch. > >> > >> Link: https://en.sophgo.com/product/introduce/huashan.html > >> Link: https://en.sophgo.com/product/introduce/cv181xH.html > >> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ > >> > >> [...] > > > >Applied to riscv-dt-for-next, thanks! LMK if something looks not as > >expected. > > > >[1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic > > https://git.kernel.org/conor/c/21a34e63afcc > >[2/7] dt-bindings: timer: Add SOPHGO CV1812H clint > > https://git.kernel.org/conor/c/06ea2a1968a9 > >[3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles > > https://git.kernel.org/conor/c/d7b92027834e > >[4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc > > https://git.kernel.org/conor/c/5b5dce3951b2 > >[5/7] riscv: dts: sophgo: cv18xx: Add gpio devices > > https://git.kernel.org/conor/c/dd791b45c866 > >[6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree > > https://git.kernel.org/conor/c/681ec684a741 > >[7/7] riscv: dts: sophgo: add Huashan Pi board device tree > > https://git.kernel.org/conor/c/2c36b0cfb408 > > > >Thanks, > >Conor. > > > > Hi Conor, > > Thanks for the confirmation. But I suggest to revert these patches. > Several days ago, Sophgo informed me that CV1810 series will be > renamed. And the Huashan Pi will switch to the chip with new name. > To avoid unnecessary conflict, please drop these patch and I will > prepare a new patch once the renamed chip is launched. This is a board that exists, that you (and possibly others) have, right?
> >On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>> >>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>> Huashan Pi board is an embedded development platform based on the >>>> CV1812H chip. Add minimal device tree files for this board. >>>> Currently, it can boot to a basic shell. >>>> >>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>> >>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>> >>>> [...] >>> >>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>> expected. >>> >>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>> https://git.kernel.org/conor/c/21a34e63afcc >>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>> https://git.kernel.org/conor/c/06ea2a1968a9 >>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>> https://git.kernel.org/conor/c/d7b92027834e >>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>> https://git.kernel.org/conor/c/5b5dce3951b2 >>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>> https://git.kernel.org/conor/c/dd791b45c866 >>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>> https://git.kernel.org/conor/c/681ec684a741 >>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>> https://git.kernel.org/conor/c/2c36b0cfb408 >>> >>> Thanks, >>> Conor. >>> >> >> Hi Conor, >> >> Thanks for the confirmation. But I suggest to revert these patches. >> Several days ago, Sophgo informed me that CV1810 series will be >> renamed. And the Huashan Pi will switch to the chip with new name. >> To avoid unnecessary conflict, please drop these patch and I will >> prepare a new patch once the renamed chip is launched. > >This is a board that exists, that you (and possibly others) have, right? > Yes, of course.
On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: > > > >On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: > >>> > >>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: > >>>> Huashan Pi board is an embedded development platform based on the > >>>> CV1812H chip. Add minimal device tree files for this board. > >>>> Currently, it can boot to a basic shell. > >>>> > >>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. > >>>> > >>>> Link: https://en.sophgo.com/product/introduce/huashan.html > >>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html > >>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ > >>>> > >>>> [...] > >>> > >>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as > >>> expected. > >>> > >>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic > >>> https://git.kernel.org/conor/c/21a34e63afcc > >>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint > >>> https://git.kernel.org/conor/c/06ea2a1968a9 > >>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles > >>> https://git.kernel.org/conor/c/d7b92027834e > >>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc > >>> https://git.kernel.org/conor/c/5b5dce3951b2 > >>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices > >>> https://git.kernel.org/conor/c/dd791b45c866 > >>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree > >>> https://git.kernel.org/conor/c/681ec684a741 > >>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree > >>> https://git.kernel.org/conor/c/2c36b0cfb408 > >> Thanks for the confirmation. But I suggest to revert these patches. > >> Several days ago, Sophgo informed me that CV1810 series will be > >> renamed. And the Huashan Pi will switch to the chip with new name. > >> To avoid unnecessary conflict, please drop these patch and I will > >> prepare a new patch once the renamed chip is launched. > > > >This is a board that exists, that you (and possibly others) have, right? > > > > Yes, of course. I dunno then. It sounds from your message that this is purely a rebrand of the SoCs, so since people already have these boards, I'd rather not. We should be able to support both since it's just a naming change, right?
> >On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: >>> >>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>>>> >>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>>>> Huashan Pi board is an embedded development platform based on the >>>>>> CV1812H chip. Add minimal device tree files for this board. >>>>>> Currently, it can boot to a basic shell. >>>>>> >>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>>>> >>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>>>> >>>>>> [...] >>>>> >>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>>>> expected. >>>>> >>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>>>> https://git.kernel.org/conor/c/21a34e63afcc >>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>>>> https://git.kernel.org/conor/c/06ea2a1968a9 >>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>>>> https://git.kernel.org/conor/c/d7b92027834e >>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>>>> https://git.kernel.org/conor/c/5b5dce3951b2 >>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>>>> https://git.kernel.org/conor/c/dd791b45c866 >>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>>>> https://git.kernel.org/conor/c/681ec684a741 >>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>>>> https://git.kernel.org/conor/c/2c36b0cfb408 > >>>> Thanks for the confirmation. But I suggest to revert these patches. >>>> Several days ago, Sophgo informed me that CV1810 series will be >>>> renamed. And the Huashan Pi will switch to the chip with new name. >>>> To avoid unnecessary conflict, please drop these patch and I will >>>> prepare a new patch once the renamed chip is launched. >>> >>> This is a board that exists, that you (and possibly others) have, right? >>> >> >> Yes, of course. > >I dunno then. It sounds from your message that this is purely a rebrand >of the SoCs, IIRC, it is. FYI, Chen and Chao. Maybe you know something more. >so since people already have these boards, I'd rather not. >We should be able to support both since it's just a naming change, >right? I agree with this. If the above is true, we can just reuse the exists code with a different compatible name, right?
On Fri, Dec 01, 2023 at 04:31:38PM +0800, Inochi Amaoto wrote: > > > >On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: > >>> > >>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: > >>>>> > >>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: > >>>>>> Huashan Pi board is an embedded development platform based on the > >>>>>> CV1812H chip. Add minimal device tree files for this board. > >>>>>> Currently, it can boot to a basic shell. > >>>>>> > >>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. > >>>>>> > >>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html > >>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html > >>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ > >>>>>> > >>>>>> [...] > >>>>> > >>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as > >>>>> expected. > >>>>> > >>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic > >>>>> https://git.kernel.org/conor/c/21a34e63afcc > >>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint > >>>>> https://git.kernel.org/conor/c/06ea2a1968a9 > >>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles > >>>>> https://git.kernel.org/conor/c/d7b92027834e > >>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc > >>>>> https://git.kernel.org/conor/c/5b5dce3951b2 > >>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices > >>>>> https://git.kernel.org/conor/c/dd791b45c866 > >>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree > >>>>> https://git.kernel.org/conor/c/681ec684a741 > >>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree > >>>>> https://git.kernel.org/conor/c/2c36b0cfb408 > > > >>>> Thanks for the confirmation. But I suggest to revert these patches. > >>>> Several days ago, Sophgo informed me that CV1810 series will be > >>>> renamed. And the Huashan Pi will switch to the chip with new name. > >>>> To avoid unnecessary conflict, please drop these patch and I will > >>>> prepare a new patch once the renamed chip is launched. > >>> > >>> This is a board that exists, that you (and possibly others) have, right? > >>> > >> > >> Yes, of course. > > > >I dunno then. It sounds from your message that this is purely a rebrand > >of the SoCs, > > IIRC, it is. > FYI, Chen and Chao. Maybe you know something more. > > >so since people already have these boards, I'd rather not. > >We should be able to support both since it's just a naming change, > >right? > > I agree with this. If the above is true, we can just reuse the exists code > with a different compatible name, right? I think so? I'm not sure what the precedent really is for pure rebrandings of an SoC. I say for now, assume we can do that, and we can discuss it with Rob and Krzysztof when the time comes if there is no difference between the SoCs and boards. Cheers, Conor.
> >On Fri, Dec 01, 2023 at 04:31:38PM +0800, Inochi Amaoto wrote: >>> >>> On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: >>>>> >>>>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>>>>>> >>>>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>>>>>> Huashan Pi board is an embedded development platform based on the >>>>>>>> CV1812H chip. Add minimal device tree files for this board. >>>>>>>> Currently, it can boot to a basic shell. >>>>>>>> >>>>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>>>>>> >>>>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>>>>>> >>>>>>>> [...] >>>>>>> >>>>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>>>>>> expected. >>>>>>> >>>>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>>>>>> https://git.kernel.org/conor/c/21a34e63afcc >>>>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>>>>>> https://git.kernel.org/conor/c/06ea2a1968a9 >>>>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>>>>>> https://git.kernel.org/conor/c/d7b92027834e >>>>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>>>>>> https://git.kernel.org/conor/c/5b5dce3951b2 >>>>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>>>>>> https://git.kernel.org/conor/c/dd791b45c866 >>>>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>>>>>> https://git.kernel.org/conor/c/681ec684a741 >>>>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>>>>>> https://git.kernel.org/conor/c/2c36b0cfb408 >>> >>>>>> Thanks for the confirmation. But I suggest to revert these patches. >>>>>> Several days ago, Sophgo informed me that CV1810 series will be >>>>>> renamed. And the Huashan Pi will switch to the chip with new name. >>>>>> To avoid unnecessary conflict, please drop these patch and I will >>>>>> prepare a new patch once the renamed chip is launched. >>>>> >>>>> This is a board that exists, that you (and possibly others) have, right? >>>>> >>>> >>>> Yes, of course. >>> >>> I dunno then. It sounds from your message that this is purely a rebrand >>> of the SoCs, >> >> IIRC, it is. >> FYI, Chen and Chao. Maybe you know something more. >> >>> so since people already have these boards, I'd rather not. >>> We should be able to support both since it's just a naming change, >>> right? >> >> I agree with this. If the above is true, we can just reuse the exists code >> with a different compatible name, right? > >I think so? I'm not sure what the precedent really is for pure >rebrandings of an SoC. >I say for now, assume we can do that, and we can discuss it with Rob and >Krzysztof when the time comes if there is no difference between the SoCs >and boards. > OK, now let's reserve these code and discuss when the board with those SoCs come. Thanks for your explanation. >Cheers, >Conor. > >
On 2023/12/2 0:21, Conor Dooley wrote: > On Fri, Dec 01, 2023 at 04:31:38PM +0800, Inochi Amaoto wrote: >>> On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: >>>>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>>>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>>>>>> Huashan Pi board is an embedded development platform based on the >>>>>>>> CV1812H chip. Add minimal device tree files for this board. >>>>>>>> Currently, it can boot to a basic shell. >>>>>>>> >>>>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>>>>>> >>>>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>>>>>> >>>>>>>> [...] >>>>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>>>>>> expected. >>>>>>> >>>>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>>>>>> https://git.kernel.org/conor/c/21a34e63afcc >>>>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>>>>>> https://git.kernel.org/conor/c/06ea2a1968a9 >>>>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>>>>>> https://git.kernel.org/conor/c/d7b92027834e >>>>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>>>>>> https://git.kernel.org/conor/c/5b5dce3951b2 >>>>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>>>>>> https://git.kernel.org/conor/c/dd791b45c866 >>>>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>>>>>> https://git.kernel.org/conor/c/681ec684a741 >>>>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>>>>>> https://git.kernel.org/conor/c/2c36b0cfb408 >>>>>> Thanks for the confirmation. But I suggest to revert these patches. >>>>>> Several days ago, Sophgo informed me that CV1810 series will be >>>>>> renamed. And the Huashan Pi will switch to the chip with new name. >>>>>> To avoid unnecessary conflict, please drop these patch and I will >>>>>> prepare a new patch once the renamed chip is launched. >>>>> This is a board that exists, that you (and possibly others) have, right? >>>>> >>>> Yes, of course. >>> I dunno then. It sounds from your message that this is purely a rebrand >>> of the SoCs, >> IIRC, it is. >> FYI, Chen and Chao. Maybe you know something more. >> >>> so since people already have these boards, I'd rather not. >>> We should be able to support both since it's just a naming change, >>> right? >> I agree with this. If the above is true, we can just reuse the exists code >> with a different compatible name, right? > I think so? I'm not sure what the precedent really is for pure > rebrandings of an SoC. > I say for now, assume we can do that, and we can discuss it with Rob and > Krzysztof when the time comes if there is no difference between the SoCs > and boards. > > Cheers, > Conor. As far as I know, sophgo's SoC product names all start with "sg", while products starting with "cv" come from CVITEK (another chip company). CVITEK was acquired by sophgo a year ago, so now many SOC product names that originally started with "cv" are being repackaged and changed to start with "sg". For the cv1800b adopted by Duo, Sophgo has made it clear that it will not change its codename. But I heard that for other products, such as the cv1812h used by Huashanpi, sophgo may change their names in the future, but sophgo has not officially confirmed it yet. Looks like sophgo themselves are still in the process of digesting cv's products, ;) Since we have just started to support cv1812h and have not done much work yet, I suggest not to merge this patch into the mainline, and wait until there is clear news before doing this to avoid introducing unnecessary modifications later. Thanks, Chen
On Sat, Dec 02, 2023 at 09:11:38AM +0800, Chen Wang wrote: > As far as I know, sophgo's SoC product names all start with "sg", while > products starting with "cv" come from CVITEK (another chip company). CVITEK > was acquired by sophgo a year ago, so now many SOC product names that > originally started with "cv" are being repackaged and changed to start with > "sg". > > For the cv1800b adopted by Duo, Sophgo has made it clear that it will not > change its codename. > > But I heard that for other products, such as the cv1812h used by Huashanpi, > sophgo may change their names in the future, but sophgo has not officially > confirmed it yet. Looks like sophgo themselves are still in the process of > digesting cv's products, ;) > > Since we have just started to support cv1812h and have not done much work > yet, I suggest not to merge this patch into the mainline, and wait until > there is clear news before doing this to avoid introducing unnecessary > modifications later. If there are people who have the boards, I'd be inclined to make the mainline kernel usable for them. Doing some renames or adding compatibles down the road, if the SoC is actually rebranded, is not a big deal. I'll leave it up to you guys as to what to do - it's only -rc4 today, so there's no impending doom. Cheers, Conor.
>On 2023/12/2 0:21, Conor Dooley wrote: >> On Fri, Dec 01, 2023 at 04:31:38PM +0800, Inochi Amaoto wrote: >>>> On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: >>>>>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>>>>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>>>>>>> Huashan Pi board is an embedded development platform based on the >>>>>>>>> CV1812H chip. Add minimal device tree files for this board. >>>>>>>>> Currently, it can boot to a basic shell. >>>>>>>>> >>>>>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>>>>>>> >>>>>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>>>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>>>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>>>>>>> >>>>>>>>> [...] >>>>>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>>>>>>> expected. >>>>>>>> >>>>>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>>>>>>> https://git.kernel.org/conor/c/21a34e63afcc >>>>>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>>>>>>> https://git.kernel.org/conor/c/06ea2a1968a9 >>>>>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>>>>>>> https://git.kernel.org/conor/c/d7b92027834e >>>>>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>>>>>>> https://git.kernel.org/conor/c/5b5dce3951b2 >>>>>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>>>>>>> https://git.kernel.org/conor/c/dd791b45c866 >>>>>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>>>>>>> https://git.kernel.org/conor/c/681ec684a741 >>>>>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>>>>>>> https://git.kernel.org/conor/c/2c36b0cfb408 >>>>>>> Thanks for the confirmation. But I suggest to revert these patches. >>>>>>> Several days ago, Sophgo informed me that CV1810 series will be >>>>>>> renamed. And the Huashan Pi will switch to the chip with new name. >>>>>>> To avoid unnecessary conflict, please drop these patch and I will >>>>>>> prepare a new patch once the renamed chip is launched. >>>>>> This is a board that exists, that you (and possibly others) have, right? >>>>>> >>>>> Yes, of course. >>>> I dunno then. It sounds from your message that this is purely a rebrand >>>> of the SoCs, >>> IIRC, it is. >>> FYI, Chen and Chao. Maybe you know something more. >>> >>>> so since people already have these boards, I'd rather not. >>>> We should be able to support both since it's just a naming change, >>>> right? >>> I agree with this. If the above is true, we can just reuse the exists code >>> with a different compatible name, right? >> I think so? I'm not sure what the precedent really is for pure >> rebrandings of an SoC. >> I say for now, assume we can do that, and we can discuss it with Rob and >> Krzysztof when the time comes if there is no difference between the SoCs >> and boards. >> >> Cheers, >> Conor. > >As far as I know, sophgo's SoC product names all start with "sg", while products starting with "cv" come from CVITEK (another chip company). CVITEK was acquired by sophgo a year ago, so now many SOC product names that originally started with "cv" are being repackaged and changed to start with "sg". > >For the cv1800b adopted by Duo, Sophgo has made it clear that it will not change its codename. > >But I heard that for other products, such as the cv1812h used by Huashanpi, sophgo may change their names in the future, but sophgo has not officially confirmed it yet. Looks like sophgo themselves are still in the process of digesting cv's products, ;) > >Since we have just started to support cv1812h and have not done much work yet, I suggest not to merge this patch into the mainline, and wait until there is clear news before doing this to avoid introducing unnecessary modifications later. > Hi Chen, There is a update for you. The cv1812h does not have the A53 core as the sg200x does. Maybe we should treat cv1812h as a trim of sg200x, not just a reband. According to this information, I suggest to preserve these code for cv1812h, it can make upstream the new soc eaiser. Also, adding a new compatible is not too hard, and it is necessary if we have new soc. Otherwise, the one with Huashan Pi now may be confused because it have a old version. >Thanks, > >Chen >
On 2023/12/4 7:32, Inochi Amaoto wrote: >> On 2023/12/2 0:21, Conor Dooley wrote: >>> On Fri, Dec 01, 2023 at 04:31:38PM +0800, Inochi Amaoto wrote: >>>>> On Fri, Dec 01, 2023 at 09:02:59AM +0800, Inochi Amaoto wrote: >>>>>>> On Fri, Dec 01, 2023 at 07:21:29AM +0800, Inochi Amaoto wrote: >>>>>>>>> On Thu, 19 Oct 2023 07:18:00 +0800, Inochi Amaoto wrote: >>>>>>>>>> Huashan Pi board is an embedded development platform based on the >>>>>>>>>> CV1812H chip. Add minimal device tree files for this board. >>>>>>>>>> Currently, it can boot to a basic shell. >>>>>>>>>> >>>>>>>>>> NOTE: this series is based on the Jisheng's Milk-V Duo patch. >>>>>>>>>> >>>>>>>>>> Link: https://en.sophgo.com/product/introduce/huashan.html >>>>>>>>>> Link: https://en.sophgo.com/product/introduce/cv181xH.html >>>>>>>>>> Link: https://lore.kernel.org/linux-riscv/20231006121449.721-1-jszhang@kernel.org/ >>>>>>>>>> >>>>>>>>>> [...] >>>>>>>>> Applied to riscv-dt-for-next, thanks! LMK if something looks not as >>>>>>>>> expected. >>>>>>>>> >>>>>>>>> [1/7] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic >>>>>>>>> https://git.kernel.org/conor/c/21a34e63afcc >>>>>>>>> [2/7] dt-bindings: timer: Add SOPHGO CV1812H clint >>>>>>>>> https://git.kernel.org/conor/c/06ea2a1968a9 >>>>>>>>> [3/7] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles >>>>>>>>> https://git.kernel.org/conor/c/d7b92027834e >>>>>>>>> [4/7] riscv: dts: sophgo: Separate compatible specific for CV1800B soc >>>>>>>>> https://git.kernel.org/conor/c/5b5dce3951b2 >>>>>>>>> [5/7] riscv: dts: sophgo: cv18xx: Add gpio devices >>>>>>>>> https://git.kernel.org/conor/c/dd791b45c866 >>>>>>>>> [6/7] riscv: dts: sophgo: add initial CV1812H SoC device tree >>>>>>>>> https://git.kernel.org/conor/c/681ec684a741 >>>>>>>>> [7/7] riscv: dts: sophgo: add Huashan Pi board device tree >>>>>>>>> https://git.kernel.org/conor/c/2c36b0cfb408 >>>>>>>> Thanks for the confirmation. But I suggest to revert these patches. >>>>>>>> Several days ago, Sophgo informed me that CV1810 series will be >>>>>>>> renamed. And the Huashan Pi will switch to the chip with new name. >>>>>>>> To avoid unnecessary conflict, please drop these patch and I will >>>>>>>> prepare a new patch once the renamed chip is launched. >>>>>>> This is a board that exists, that you (and possibly others) have, right? >>>>>>> >>>>>> Yes, of course. >>>>> I dunno then. It sounds from your message that this is purely a rebrand >>>>> of the SoCs, >>>> IIRC, it is. >>>> FYI, Chen and Chao. Maybe you know something more. >>>> >>>>> so since people already have these boards, I'd rather not. >>>>> We should be able to support both since it's just a naming change, >>>>> right? >>>> I agree with this. If the above is true, we can just reuse the exists code >>>> with a different compatible name, right? >>> I think so? I'm not sure what the precedent really is for pure >>> rebrandings of an SoC. >>> I say for now, assume we can do that, and we can discuss it with Rob and >>> Krzysztof when the time comes if there is no difference between the SoCs >>> and boards. >>> >>> Cheers, >>> Conor. >> As far as I know, sophgo's SoC product names all start with "sg", while products starting with "cv" come from CVITEK (another chip company). CVITEK was acquired by sophgo a year ago, so now many SOC product names that originally started with "cv" are being repackaged and changed to start with "sg". >> >> For the cv1800b adopted by Duo, Sophgo has made it clear that it will not change its codename. >> >> But I heard that for other products, such as the cv1812h used by Huashanpi, sophgo may change their names in the future, but sophgo has not officially confirmed it yet. Looks like sophgo themselves are still in the process of digesting cv's products, ;) >> >> Since we have just started to support cv1812h and have not done much work yet, I suggest not to merge this patch into the mainline, and wait until there is clear news before doing this to avoid introducing unnecessary modifications later. >> > Hi Chen, > > There is a update for you. The cv1812h does not have the A53 core as the > sg200x does. Maybe we should treat cv1812h as a trim of sg200x, not just > a reband. > > According to this information, I suggest to preserve these code for > cv1812h, it can make upstream the new soc eaiser. Also, adding a new > compatible is not too hard, and it is necessary if we have new soc. > Otherwise, the one with Huashan Pi now may be confused because it have > a old version. Thanks Inochi for your info, let's just preserve these code for huashan pi now and keep watching on what's going on then. Regards, Chen > >> Thanks, >> >> Chen >>
On Mon, Dec 04, 2023 at 05:15:36PM +0800, Chen Wang wrote: > > On 2023/12/4 7:32, Inochi Amaoto wrote: > > > On 2023/12/2 0:21, Conor Dooley wrote: > > > As far as I know, sophgo's SoC product names all start with "sg", while products starting with "cv" come from CVITEK (another chip company). CVITEK was acquired by sophgo a year ago, so now many SOC product names that originally started with "cv" are being repackaged and changed to start with "sg". > > > > > > For the cv1800b adopted by Duo, Sophgo has made it clear that it will not change its codename. > > > > > > But I heard that for other products, such as the cv1812h used by Huashanpi, sophgo may change their names in the future, but sophgo has not officially confirmed it yet. Looks like sophgo themselves are still in the process of digesting cv's products, ;) > > > > > > Since we have just started to support cv1812h and have not done much work yet, I suggest not to merge this patch into the mainline, and wait until there is clear news before doing this to avoid introducing unnecessary modifications later. > > > > > Hi Chen, > > > > There is a update for you. The cv1812h does not have the A53 core as the > > sg200x does. Maybe we should treat cv1812h as a trim of sg200x, not just > > a reband. > > > > According to this information, I suggest to preserve these code for > > cv1812h, it can make upstream the new soc eaiser. Also, adding a new > > compatible is not too hard, and it is necessary if we have new soc. > > Otherwise, the one with Huashan Pi now may be confused because it have > > a old version. > > Thanks Inochi for your info, let's just preserve these code for huashan pi > now and keep watching on what's going on then. Could you explain on what you mean by "preserve"? I'm a little unsure.
On 2023/12/4 17:32, Conor Dooley wrote: > On Mon, Dec 04, 2023 at 05:15:36PM +0800, Chen Wang wrote: >> On 2023/12/4 7:32, Inochi Amaoto wrote: >>>> On 2023/12/2 0:21, Conor Dooley wrote: >>>> As far as I know, sophgo's SoC product names all start with "sg", while products starting with "cv" come from CVITEK (another chip company). CVITEK was acquired by sophgo a year ago, so now many SOC product names that originally started with "cv" are being repackaged and changed to start with "sg". >>>> >>>> For the cv1800b adopted by Duo, Sophgo has made it clear that it will not change its codename. >>>> >>>> But I heard that for other products, such as the cv1812h used by Huashanpi, sophgo may change their names in the future, but sophgo has not officially confirmed it yet. Looks like sophgo themselves are still in the process of digesting cv's products, ;) >>>> >>>> Since we have just started to support cv1812h and have not done much work yet, I suggest not to merge this patch into the mainline, and wait until there is clear news before doing this to avoid introducing unnecessary modifications later. >>>> >>> Hi Chen, >>> >>> There is a update for you. The cv1812h does not have the A53 core as the >>> sg200x does. Maybe we should treat cv1812h as a trim of sg200x, not just >>> a reband. >>> >>> According to this information, I suggest to preserve these code for >>> cv1812h, it can make upstream the new soc eaiser. Also, adding a new >>> compatible is not too hard, and it is necessary if we have new soc. >>> Otherwise, the one with Huashan Pi now may be confused because it have >>> a old version. >> Thanks Inochi for your info, let's just preserve these code for huashan pi >> now and keep watching on what's going on then. > Could you explain on what you mean by "preserve"? I'm a little unsure. hi, Conor, I meant keeping your changes on riscv-dt-for-next and continue submitting this patch ([PATCH v4 0/7] Add Huashan Pi board support) to upstream. Sorry for my poor english, hope I have explained it well. :$ Thanks, Chen
> > > Thanks Inochi for your info, let's just preserve these code for huashan pi > > > now and keep watching on what's going on then. > > Could you explain on what you mean by "preserve"? I'm a little unsure. > > I meant keeping your changes on riscv-dt-for-next and continue submitting > this patch ([PATCH v4 0/7] Add Huashan Pi board support) to upstream. > > Sorry for my poor english, hope I have explained it well. :$ I thought that was what you meant, but I just wanted to make sure :) Thanks for explaining it again, Conor.