mbox series

[v2,0/7] Add Support for Wave5 on TI Devices

Message ID 20231130223959.3837222-1-b-brnich@ti.com (mailing list archive)
Headers show
Series Add Support for Wave5 on TI Devices | expand

Message

Brandon Brnich Nov. 30, 2023, 10:39 p.m. UTC
This series is responsible for adding support for Wave5 driver[0]
across numerous TI K3 platforms.

[0]: https://lore.kernel.org/all/ae6d2ad3-0b2a-462a-a9eb-9ce01e7a7f5e@xs4all.nl/

Changes since v1:
=================

* Remove sram parameters
  - sram-size property not included in bindings. Without this, size
  will default to 0 so no point in specifying until binding is added.
* Remove global CMA pools for each platform
  - This is something that has been added in TI backport of driver
  and does not yet have reliable support in upstream version.
  - Removing for now with intention to add back once 48-bit
  addressing is supported in upstream Wave5 driver.

Brandon Brnich (6):
  arm64: dts: ti: k3-j784s4: Add Wave5 Video Encoder/Decoder Node
  arm64: dts: ti: k3-am69-sk: Enable Wave5 Video Encoder/Decoder
  arm64: dts: ti: k3-am68-sk: Enable Wave5 Video Encoder/Decoder
  arm64: dts: ti: k3-am62a: Add Wave5 Video Encoder/Decoder Node
  arm64: dts: ti: k3-am62p: Add Wave5 Video Encoder/Decoder Node
  arm64: defconfig: Enable Wave5 Video Encoder/Decoder

Darren Etheridge (1):
  arm64: dts: ti: k3-j721s2-main: add wave5 video encoder/decoder node

 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     |  9 +++++++++
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts       |  4 ++++
 arch/arm64/boot/dts/ti/k3-am62p-main.dtsi     | 10 ++++++++++
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts       |  4 ++++
 .../boot/dts/ti/k3-am68-sk-base-board.dts     |  4 ++++
 arch/arm64/boot/dts/ti/k3-am69-sk.dts         |  8 ++++++++
 .../dts/ti/k3-j721s2-common-proc-board.dts    |  4 ++++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 10 ++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      |  8 ++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    | 20 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4.dtsi         |  2 ++
 arch/arm64/configs/defconfig                  |  1 +
 12 files changed, 84 insertions(+)

Comments

Nishanth Menon Dec. 1, 2023, 6:24 a.m. UTC | #1
On 16:39-20231130, Brandon Brnich wrote:
> This series is responsible for adding support for Wave5 driver[0]
> across numerous TI K3 platforms.
> 
> [0]: https://lore.kernel.org/all/ae6d2ad3-0b2a-462a-a9eb-9ce01e7a7f5e@xs4all.nl/
> 
> Changes since v1:
> =================
> 
> * Remove sram parameters
>   - sram-size property not included in bindings. Without this, size
>   will default to 0 so no point in specifying until binding is added.
> * Remove global CMA pools for each platform
>   - This is something that has been added in TI backport of driver
>   and does not yet have reliable support in upstream version.
>   - Removing for now with intention to add back once 48-bit
>   addressing is supported in upstream Wave5 driver.
> 
> Brandon Brnich (6):
>   arm64: dts: ti: k3-j784s4: Add Wave5 Video Encoder/Decoder Node
>   arm64: dts: ti: k3-am69-sk: Enable Wave5 Video Encoder/Decoder
>   arm64: dts: ti: k3-am68-sk: Enable Wave5 Video Encoder/Decoder
>   arm64: dts: ti: k3-am62a: Add Wave5 Video Encoder/Decoder Node
>   arm64: dts: ti: k3-am62p: Add Wave5 Video Encoder/Decoder Node
>   arm64: defconfig: Enable Wave5 Video Encoder/Decoder
> 
> Darren Etheridge (1):
>   arm64: dts: ti: k3-j721s2-main: add wave5 video encoder/decoder node
> 
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     |  9 +++++++++
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts       |  4 ++++
>  arch/arm64/boot/dts/ti/k3-am62p-main.dtsi     | 10 ++++++++++
>  arch/arm64/boot/dts/ti/k3-am62p5-sk.dts       |  4 ++++
>  .../boot/dts/ti/k3-am68-sk-base-board.dts     |  4 ++++
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts         |  8 ++++++++
>  .../dts/ti/k3-j721s2-common-proc-board.dts    |  4 ++++
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 10 ++++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      |  8 ++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    | 20 +++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4.dtsi         |  2 ++
>  arch/arm64/configs/defconfig                  |  1 +
>  12 files changed, 84 insertions(+)

I think I should hold off on this series for the next cycle till
it hits linus master.

Reason:
https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/

Could you folks help address the same and finalize on the compatible
etc? I think Geert does have a point there. So far, we have accepted
bindings where the compatible does not contain the family name prefix
(examples: git grep j721e Documentation/) it tends to be ti,j721e-csi2rx
or something of the form. I don't think I prefer seeing a variation for
that IP.