| Message ID | 20231108-wave5-v14-rebased-v14-6-0b4af1258656@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Wave5 codec driver | expand |
On Wed, 08 Nov 2023 20:29:25 +0100, Sebastian Fricke wrote: > From: Robert Beckett <bob.beckett@collabora.com> > > Add bindings for the wave5 chips&media codec driver > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com> > --- > .../devicetree/bindings/media/cnm,wave521c.yaml | 61 ++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Sebastian, CC TI K3 On Wed, Nov 8, 2023 at 8:29 PM Sebastian Fricke <sebastian.fricke@collabora.com> wrote: > From: Robert Beckett <bob.beckett@collabora.com> > > Add bindings for the wave5 chips&media codec driver > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com> Thanks for your patch, which is now commit de4b9f7e371a5384 ("dt-bindings: media: wave5: add yaml devicetree bindings") in media/master. > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/cnm,wave521c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chips&Media Wave 5 Series multi-standard codec IP > + > +maintainers: > + - Nas Chung <nas.chung@chipsnmedia.com> > + - Jackson Lee <jackson.lee@chipsnmedia.com> > + > +description: > + The Chips&Media WAVE codec IP is a multi format video encoder/decoder > + > +properties: > + compatible: > + items: > + - enum: > + - ti,k3-j721s2-wave521c This is the only compatible value defined which contains both "k3" and "j72*". I assume the "k3-" part should be dropped? > + - const: cnm,wave521c > + This also applies to the driver added in commit 9707a6254a8a6b97 ("media: chips-media: wave5: Add the v4l2 layer") in media/master. Gr{oetje,eeting}s, Geert
On 11:27-20231128, Geert Uytterhoeven wrote: > Hi Sebastian, > > CC TI K3 Thanks for looping us in Geert. [...] > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - ti,k3-j721s2-wave521c > > This is the only compatible value defined which contains both "k3" > and "j72*". I assume the "k3-" part should be dropped? Correct - we have not been using architecture prefix such as k3- in compatibles for any other peripheral and that lines up with DT spec[1] $ git grep ti, Documentation/|grep compatible|grep yaml|cut -d ':' -f2|grep k3- is empty. I have for asked this to be cleared up[2] before I can pick the dts changes corresponding to the binding.. I will wait for the bindings to hit linus master prior to looking at the dts changes. [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4 [2] https://lore.kernel.org/all/20231201062427.6fw5gn2zgkkurv4q@shadow/
diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml new file mode 100644 index 000000000000..6d5569e77b7a --- /dev/null +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/cnm,wave521c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Chips&Media Wave 5 Series multi-standard codec IP + +maintainers: + - Nas Chung <nas.chung@chipsnmedia.com> + - Jackson Lee <jackson.lee@chipsnmedia.com> + +description: + The Chips&Media WAVE codec IP is a multi format video encoder/decoder + +properties: + compatible: + items: + - enum: + - ti,k3-j721s2-wave521c + - const: cnm,wave521c + + reg: + maxItems: 1 + + clocks: + items: + - description: VCODEC clock + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + + sram: + $ref: /schemas/types.yaml#/definitions/phandle + description: + The VPU uses the SRAM to store some of the reference data instead of + storing it on DMA memory. It is mainly used for the purpose of reducing + bandwidth. + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + vpu: video-codec@12345678 { + compatible = "ti,k3-j721s2-wave521c", "cnm,wave521c"; + reg = <0x12345678 0x1000>; + clocks = <&clks 42>; + interrupts = <42>; + sram = <&sram>; + };