| Message ID | 20231202192536.266885-6-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Convert DA906{1,2} bindings to json-schema | expand |
On Sat, Dec 02, 2023 at 07:25:29PM +0000, Biju Das wrote: > Update watchdog property by referring to dlg,da9062-watchdog binding file > and drop its definition from this file. > > While at, update description with link to product information. This is unrelated IMO. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../devicetree/bindings/mfd/dlg,da9063.yaml | 21 ++++++------------- > 1 file changed, 6 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > index c5a7e10d7d80..1bdfb2be2e17 100644 > --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > @@ -17,6 +17,9 @@ description: | > moment where all voltage monitors are disabled. Next, as da9063 only supports > UV *and* OV monitoring, both must be set to the same severity and value > (0: disable, 1: enable). > + Product information for the DA906{3L,3} devices can be found here: > + - https://www.dialog-semiconductor.com/products/da9063l > + - https://www.dialog-semiconductor.com/products/da9063 > > properties: > compatible: > @@ -35,21 +38,6 @@ properties: > "#interrupt-cells": > const: 2 > > - dlg,use-sw-pm: > - type: boolean > - description: > - Disable the watchdog during suspend. > - Only use this option if you can't use the watchdog automatic suspend > - function during a suspend (see register CONTROL_B). > - > - watchdog: > - type: object > - $ref: /schemas/watchdog/watchdog.yaml# > - unevaluatedProperties: false > - properties: > - compatible: > - const: dlg,da9063-watchdog > - > rtc: > type: object > $ref: /schemas/rtc/rtc.yaml# > @@ -82,6 +70,9 @@ properties: > $ref: /schemas/regulator/regulator.yaml > unevaluatedProperties: false > > + watchdog: > + $ref: /schemas/watchdog/dlg,da9062-watchdog.yaml > + > required: > - compatible > - reg > -- > 2.39.2 >
Hi Conor, Thanks for the feedback. > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Sunday, December 3, 2023 11:40 AM > Subject: Re: [PATCH v2 05/11] dt-bindings: mfd: dlg,da9063: Update > watchdog property > > On Sat, Dec 02, 2023 at 07:25:29PM +0000, Biju Das wrote: > > Update watchdog property by referring to dlg,da9062-watchdog binding > > file and drop its definition from this file. > > > > > While at, update description with link to product information. > > This is unrelated IMO. OK will move this to patch#11. Cheers, Biju > Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../devicetree/bindings/mfd/dlg,da9063.yaml | 21 ++++++------------- > > 1 file changed, 6 insertions(+), 15 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > > b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > > index c5a7e10d7d80..1bdfb2be2e17 100644 > > --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml > > @@ -17,6 +17,9 @@ description: | > > moment where all voltage monitors are disabled. Next, as da9063 only > supports > > UV *and* OV monitoring, both must be set to the same severity and > value > > (0: disable, 1: enable). > > + Product information for the DA906{3L,3} devices can be found here: > > + - https://www.dialog-semiconductor.com/products/da9063l > > + - https://www.dialog-semiconductor.com/products/da9063 > > > > properties: > > compatible: > > @@ -35,21 +38,6 @@ properties: > > "#interrupt-cells": > > const: 2 > > > > - dlg,use-sw-pm: > > - type: boolean > > - description: > > - Disable the watchdog during suspend. > > - Only use this option if you can't use the watchdog automatic > suspend > > - function during a suspend (see register CONTROL_B). > > - > > - watchdog: > > - type: object > > - $ref: /schemas/watchdog/watchdog.yaml# > > - unevaluatedProperties: false > > - properties: > > - compatible: > > - const: dlg,da9063-watchdog > > - > > rtc: > > type: object > > $ref: /schemas/rtc/rtc.yaml# > > @@ -82,6 +70,9 @@ properties: > > $ref: /schemas/regulator/regulator.yaml > > unevaluatedProperties: false > > > > + watchdog: > > + $ref: /schemas/watchdog/dlg,da9062-watchdog.yaml > > + > > required: > > - compatible > > - reg > > -- > > 2.39.2 > >
diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml index c5a7e10d7d80..1bdfb2be2e17 100644 --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml @@ -17,6 +17,9 @@ description: | moment where all voltage monitors are disabled. Next, as da9063 only supports UV *and* OV monitoring, both must be set to the same severity and value (0: disable, 1: enable). + Product information for the DA906{3L,3} devices can be found here: + - https://www.dialog-semiconductor.com/products/da9063l + - https://www.dialog-semiconductor.com/products/da9063 properties: compatible: @@ -35,21 +38,6 @@ properties: "#interrupt-cells": const: 2 - dlg,use-sw-pm: - type: boolean - description: - Disable the watchdog during suspend. - Only use this option if you can't use the watchdog automatic suspend - function during a suspend (see register CONTROL_B). - - watchdog: - type: object - $ref: /schemas/watchdog/watchdog.yaml# - unevaluatedProperties: false - properties: - compatible: - const: dlg,da9063-watchdog - rtc: type: object $ref: /schemas/rtc/rtc.yaml# @@ -82,6 +70,9 @@ properties: $ref: /schemas/regulator/regulator.yaml unevaluatedProperties: false + watchdog: + $ref: /schemas/watchdog/dlg,da9062-watchdog.yaml + required: - compatible - reg
Update watchdog property by referring to dlg,da9062-watchdog binding file and drop its definition from this file. While at, update description with link to product information. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../devicetree/bindings/mfd/dlg,da9063.yaml | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-)