mbox series

[0/3] Virtio dmabuf improvements

Message ID 20231107093744.388099-1-aesteve@redhat.com (mailing list archive)
Headers show
Series Virtio dmabuf improvements | expand

Message

Albert Esteve Nov. 7, 2023, 9:37 a.m. UTC
Various improvements for the virtio-dmabuf module.
This patch includes:

- Check for ownership before allowing a vhost device
  to remove an object from the table.
- Properly cleanup shared resources if a vhost device
  object gets cleaned up.
- Rename virtio dmabuf functions to `virtio_dmabuf_*`

Albert Esteve (3):
  hw/virtio: check owner for removing objects
  hw/virtio: cleanup shared resources
  hw/virtio: rename virtio dmabuf API

 hw/display/virtio-dmabuf.c        | 14 +++++-----
 hw/virtio/vhost-user.c            | 33 ++++++++++++++++++-----
 hw/virtio/vhost.c                 |  5 ++++
 include/hw/virtio/vhost.h         |  6 +++++
 include/hw/virtio/virtio-dmabuf.h | 33 ++++++++++++-----------
 tests/unit/test-virtio-dmabuf.c   | 44 +++++++++++++++----------------
 6 files changed, 83 insertions(+), 52 deletions(-)

Comments

Albert Esteve Nov. 30, 2023, 3:49 p.m. UTC | #1
On Tue, Nov 7, 2023 at 10:37 AM Albert Esteve <aesteve@redhat.com> wrote:

> Various improvements for the virtio-dmabuf module.
> This patch includes:
>
> - Check for ownership before allowing a vhost device
>   to remove an object from the table.
> - Properly cleanup shared resources if a vhost device
>   object gets cleaned up.
> - Rename virtio dmabuf functions to `virtio_dmabuf_*`
>
> Albert Esteve (3):
>   hw/virtio: check owner for removing objects
>   hw/virtio: cleanup shared resources
>   hw/virtio: rename virtio dmabuf API
>
>  hw/display/virtio-dmabuf.c        | 14 +++++-----
>  hw/virtio/vhost-user.c            | 33 ++++++++++++++++++-----
>  hw/virtio/vhost.c                 |  5 ++++
>  include/hw/virtio/vhost.h         |  6 +++++
>  include/hw/virtio/virtio-dmabuf.h | 33 ++++++++++++-----------
>  tests/unit/test-virtio-dmabuf.c   | 44 +++++++++++++++----------------
>  6 files changed, 83 insertions(+), 52 deletions(-)
>
> --
> 2.41.0
>
>
Bump :)

@Marc-André Lureau <marcandre.lureau@gmail.com> could you please take a
look? You suggested the API upgrades, so would be great if you could check
if it is what you had in mind.

Thanks!
Michael S. Tsirkin Dec. 4, 2023, 8:49 a.m. UTC | #2
On Thu, Nov 30, 2023 at 04:49:35PM +0100, Albert Esteve wrote:
> 
> 
> 
> On Tue, Nov 7, 2023 at 10:37 AM Albert Esteve <aesteve@redhat.com> wrote:
> 
>     Various improvements for the virtio-dmabuf module.
>     This patch includes:
> 
>     - Check for ownership before allowing a vhost device
>       to remove an object from the table.
>     - Properly cleanup shared resources if a vhost device
>       object gets cleaned up.
>     - Rename virtio dmabuf functions to `virtio_dmabuf_*`
> 
>     Albert Esteve (3):
>       hw/virtio: check owner for removing objects
>       hw/virtio: cleanup shared resources
>       hw/virtio: rename virtio dmabuf API
> 
>      hw/display/virtio-dmabuf.c        | 14 +++++-----
>      hw/virtio/vhost-user.c            | 33 ++++++++++++++++++-----
>      hw/virtio/vhost.c                 |  5 ++++
>      include/hw/virtio/vhost.h         |  6 +++++
>      include/hw/virtio/virtio-dmabuf.h | 33 ++++++++++++-----------
>      tests/unit/test-virtio-dmabuf.c   | 44 +++++++++++++++----------------
>      6 files changed, 83 insertions(+), 52 deletions(-)
> 
>     --
>     2.41.0
> 
> 
> 
> Bump :)
> 
> @Marc-André Lureau could you please take a look? You suggested the API
> upgrades, so would be great if you could check if it is what you had in mind.
> 
> Thanks!

All this is post releas material, right?
Albert Esteve Dec. 4, 2023, 9:15 a.m. UTC | #3
On Mon, Dec 4, 2023 at 9:50 AM Michael S. Tsirkin <mst@redhat.com> wrote:

> On Thu, Nov 30, 2023 at 04:49:35PM +0100, Albert Esteve wrote:
> >
> >
> >
> > On Tue, Nov 7, 2023 at 10:37 AM Albert Esteve <aesteve@redhat.com>
> wrote:
> >
> >     Various improvements for the virtio-dmabuf module.
> >     This patch includes:
> >
> >     - Check for ownership before allowing a vhost device
> >       to remove an object from the table.
> >     - Properly cleanup shared resources if a vhost device
> >       object gets cleaned up.
> >     - Rename virtio dmabuf functions to `virtio_dmabuf_*`
> >
> >     Albert Esteve (3):
> >       hw/virtio: check owner for removing objects
> >       hw/virtio: cleanup shared resources
> >       hw/virtio: rename virtio dmabuf API
> >
> >      hw/display/virtio-dmabuf.c        | 14 +++++-----
> >      hw/virtio/vhost-user.c            | 33 ++++++++++++++++++-----
> >      hw/virtio/vhost.c                 |  5 ++++
> >      include/hw/virtio/vhost.h         |  6 +++++
> >      include/hw/virtio/virtio-dmabuf.h | 33 ++++++++++++-----------
> >      tests/unit/test-virtio-dmabuf.c   | 44
> +++++++++++++++----------------
> >      6 files changed, 83 insertions(+), 52 deletions(-)
> >
> >     --
> >     2.41.0
> >
> >
> >
> > Bump :)
> >
> > @Marc-André Lureau could you please take a look? You suggested the API
> > upgrades, so would be great if you could check if it is what you had in
> mind.
> >
> > Thanks!
>
> All this is post releas material, right?
>
>
Yes, it is.