mbox series

[v2,0/5] TPMI update for permissions

Message ID 20231130214751.3100418-1-srinivas.pandruvada@linux.intel.com (mailing list archive)
Headers show
Series TPMI update for permissions | expand

Message

srinivas pandruvada Nov. 30, 2023, 9:47 p.m. UTC
Process read/write and enabled state for feature drivers. When a feature
is disabled, don't create a device to load a feature driver. When a read
is blocked then don't load feature drivers. When write is blocked continue
to function in read only mode.

v2:
	Dropped patch platform/x86/intel/tpmi: Add additional TPMI header fields
	Addressed other review comments, details are in each patch

Srinivas Pandruvada (5):
  platform/x86/intel/tpmi: Don't create devices for disabled features
  platform/x86/intel/tpmi: Modify external interface to get read/write
    state
  platform/x86/intel/tpmi: Move TPMI ID definition
  platform/x86: ISST: Process read/write blocked feature status
  platform/x86/intel-uncore-freq: Process read/write blocked feature
    status

 .../intel/speed_select_if/isst_tpmi_core.c    | 25 +++++++++++++
 drivers/platform/x86/intel/tpmi.c             | 35 +++++++++----------
 .../uncore-frequency/uncore-frequency-tpmi.c  | 15 ++++++++
 include/linux/intel_tpmi.h                    | 18 ++++++++--
 4 files changed, 72 insertions(+), 21 deletions(-)

Comments

srinivas pandruvada Nov. 30, 2023, 11:24 p.m. UTC | #1
On Thu, 2023-11-30 at 13:47 -0800, Srinivas Pandruvada wrote:
> Process read/write and enabled state for feature drivers. When a
> feature
> is disabled, don't create a device to load a feature driver. When a
> read
> is blocked then don't load feature drivers. When write is blocked
> continue
> to function in read only mode.
> 
> v2:
>         Dropped patch platform/x86/intel/tpmi: Add additional TPMI
> header fields
>         Addressed other review comments, details are in each patch
> 
lkp@intel.com is complaining that these patches can't be applied. I
will fix any issue after review and post v3 if required.

Thanks,
Srinivas


> Srinivas Pandruvada (5):
>   platform/x86/intel/tpmi: Don't create devices for disabled features
>   platform/x86/intel/tpmi: Modify external interface to get
> read/write
>     state
>   platform/x86/intel/tpmi: Move TPMI ID definition
>   platform/x86: ISST: Process read/write blocked feature status
>   platform/x86/intel-uncore-freq: Process read/write blocked feature
>     status
> 
>  .../intel/speed_select_if/isst_tpmi_core.c    | 25 +++++++++++++
>  drivers/platform/x86/intel/tpmi.c             | 35 +++++++++--------
> --
>  .../uncore-frequency/uncore-frequency-tpmi.c  | 15 ++++++++
>  include/linux/intel_tpmi.h                    | 18 ++++++++--
>  4 files changed, 72 insertions(+), 21 deletions(-)
>
Hans de Goede Dec. 4, 2023, 2:06 p.m. UTC | #2
Hi Srinivas,

On 12/1/23 00:24, srinivas pandruvada wrote:
> On Thu, 2023-11-30 at 13:47 -0800, Srinivas Pandruvada wrote:
>> Process read/write and enabled state for feature drivers. When a
>> feature
>> is disabled, don't create a device to load a feature driver. When a
>> read
>> is blocked then don't load feature drivers. When write is blocked
>> continue
>> to function in read only mode.
>>
>> v2:
>>         Dropped patch platform/x86/intel/tpmi: Add additional TPMI
>> header fields
>>         Addressed other review comments, details are in each patch
>>
> lkp@intel.com is complaining that these patches can't be applied. I
> will fix any issue after review and post v3 if required.

Thanks.

I guess this may conflict with or depend on:

"[PATCH V6 00/20] intel_pmc: Add telemetry API to read counters"

which I have just merged into pdx86/review-hans, please make
sure your next version on top of pdx86/review-hans.

Regards,

Hans


> 
> Thanks,
> Srinivas
> 
> 
>> Srinivas Pandruvada (5):
>>   platform/x86/intel/tpmi: Don't create devices for disabled features
>>   platform/x86/intel/tpmi: Modify external interface to get
>> read/write
>>     state
>>   platform/x86/intel/tpmi: Move TPMI ID definition
>>   platform/x86: ISST: Process read/write blocked feature status
>>   platform/x86/intel-uncore-freq: Process read/write blocked feature
>>     status
>>
>>  .../intel/speed_select_if/isst_tpmi_core.c    | 25 +++++++++++++
>>  drivers/platform/x86/intel/tpmi.c             | 35 +++++++++--------
>> --
>>  .../uncore-frequency/uncore-frequency-tpmi.c  | 15 ++++++++
>>  include/linux/intel_tpmi.h                    | 18 ++++++++--
>>  4 files changed, 72 insertions(+), 21 deletions(-)
>>
>