mbox series

[v2,0/8] drm/plane-helpers: Minor clean ups

Message ID 20231204090852.1650-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series drm/plane-helpers: Minor clean ups | expand

Message

Thomas Zimmermann Dec. 4, 2023, 9:07 a.m. UTC
Move drm_plane_helper_atomic_check() into udl, which is the only
driver using it. Remove several unnecessary include statements for
<drm/drm_plane_helper.h>.

v2:
	* fix documentation (Sui)

Thomas Zimmermann (8):
  drm/plane-helper: Move drm_plane_helper_atomic_check() into udl
  drm/amdgpu: Do not include <drm/drm_plane_helper.h>
  drm/loongson: Do not include <drm/drm_plane_helper.h>
  drm/shmobile: Do not include <drm/drm_plane_helper.h>
  drm/solomon: Do not include <drm/drm_plane_helper.h>
  drm/ofdrm: Do not include <drm/drm_plane_helper.h>
  drm/simpledrm: Do not include <drm/drm_plane_helper.h>
  drm/xlnx: Do not include <drm/drm_plane_helper.h>

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  1 -
 drivers/gpu/drm/drm_crtc_helper.c             |  7 ++--
 drivers/gpu/drm/drm_plane_helper.c            | 32 -------------------
 drivers/gpu/drm/loongson/lsdc_plane.c         |  1 -
 .../drm/renesas/shmobile/shmob_drm_plane.c    |  1 -
 drivers/gpu/drm/solomon/ssd130x.h             |  1 -
 drivers/gpu/drm/tiny/ofdrm.c                  |  1 -
 drivers/gpu/drm/tiny/simpledrm.c              |  1 -
 drivers/gpu/drm/udl/udl_modeset.c             | 19 +++++++++--
 drivers/gpu/drm/xlnx/zynqmp_kms.c             |  1 -
 include/drm/drm_plane_helper.h                |  2 --
 11 files changed, 19 insertions(+), 48 deletions(-)

Comments

Alex Deucher Dec. 4, 2023, 4:15 p.m. UTC | #1
On Mon, Dec 4, 2023 at 4:09 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Move drm_plane_helper_atomic_check() into udl, which is the only
> driver using it. Remove several unnecessary include statements for
> <drm/drm_plane_helper.h>.
>
> v2:
>         * fix documentation (Sui)
>
> Thomas Zimmermann (8):
>   drm/plane-helper: Move drm_plane_helper_atomic_check() into udl
>   drm/amdgpu: Do not include <drm/drm_plane_helper.h>
>   drm/loongson: Do not include <drm/drm_plane_helper.h>
>   drm/shmobile: Do not include <drm/drm_plane_helper.h>
>   drm/solomon: Do not include <drm/drm_plane_helper.h>
>   drm/ofdrm: Do not include <drm/drm_plane_helper.h>
>   drm/simpledrm: Do not include <drm/drm_plane_helper.h>
>   drm/xlnx: Do not include <drm/drm_plane_helper.h>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

>
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  1 -
>  drivers/gpu/drm/drm_crtc_helper.c             |  7 ++--
>  drivers/gpu/drm/drm_plane_helper.c            | 32 -------------------
>  drivers/gpu/drm/loongson/lsdc_plane.c         |  1 -
>  .../drm/renesas/shmobile/shmob_drm_plane.c    |  1 -
>  drivers/gpu/drm/solomon/ssd130x.h             |  1 -
>  drivers/gpu/drm/tiny/ofdrm.c                  |  1 -
>  drivers/gpu/drm/tiny/simpledrm.c              |  1 -
>  drivers/gpu/drm/udl/udl_modeset.c             | 19 +++++++++--
>  drivers/gpu/drm/xlnx/zynqmp_kms.c             |  1 -
>  include/drm/drm_plane_helper.h                |  2 --
>  11 files changed, 19 insertions(+), 48 deletions(-)
>
> --
> 2.43.0
>
Harry Wentland Dec. 5, 2023, 2:41 p.m. UTC | #2
On 2023-12-04 04:07, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <drm/drm_plane_helper.h>.
> The file contains helpers for non-atomic code and should not be
> required by most drivers. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index aa43f1761acd3..b8c3a9b104a41 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -92,7 +92,6 @@
>  #include <drm/drm_vblank.h>
>  #include <drm/drm_audio_component.h>
>  #include <drm/drm_gem_atomic_helper.h>
> -#include <drm/drm_plane_helper.h>
>  
>  #include <acpi/video.h>
>