| Message ID | 20231205184741.3092376-3-mmayer@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory: brcmstb_dpfe: support DPFE API v4 | expand |
On 12/5/23 10:47, Markus Mayer wrote: > Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 > to the Broadcom DPFE driver. > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 05/12/2023 19:47, Markus Mayer wrote: > Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 > to the Broadcom DPFE driver. No, why? > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > --- > drivers/memory/brcmstb_dpfe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c > index a7ab3d377206..66876b409e59 100644 > --- a/drivers/memory/brcmstb_dpfe.c > +++ b/drivers/memory/brcmstb_dpfe.c > @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { > { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, > { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, > { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, > + > + /* Match specific DCPU versions */ > + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, > + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, > + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, Pointless change. Best regards, Krzysztof
On 12/6/2023 3:09 AM, Krzysztof Kozlowski wrote: > On 05/12/2023 19:47, Markus Mayer wrote: >> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 >> to the Broadcom DPFE driver. > > No, why? > >> >> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >> --- >> drivers/memory/brcmstb_dpfe.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c >> index a7ab3d377206..66876b409e59 100644 >> --- a/drivers/memory/brcmstb_dpfe.c >> +++ b/drivers/memory/brcmstb_dpfe.c >> @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { >> { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, >> { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, >> { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, >> + >> + /* Match specific DCPU versions */ >> + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, >> + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, >> + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, > > Pointless change. Is it possible to ask you as a maintainer to stop having those knee jerk reactions and try to understand things a bit better, or simply request a better explanation from the submitter?
On 06/12/2023 17:19, Florian Fainelli wrote: > > > On 12/6/2023 3:09 AM, Krzysztof Kozlowski wrote: >> On 05/12/2023 19:47, Markus Mayer wrote: >>> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 >>> to the Broadcom DPFE driver. >> >> No, why? >> >>> >>> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >>> --- >>> drivers/memory/brcmstb_dpfe.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c >>> index a7ab3d377206..66876b409e59 100644 >>> --- a/drivers/memory/brcmstb_dpfe.c >>> +++ b/drivers/memory/brcmstb_dpfe.c >>> @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { >>> { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, >>> { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, >>> { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, >>> + >>> + /* Match specific DCPU versions */ >>> + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, >>> + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, >>> + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, >> >> Pointless change. > > Is it possible to ask you as a maintainer to stop having those knee jerk > reactions and try to understand things a bit better, or simply request a > better explanation from the submitter? I asked: "Why?". None of the commits explain the rationale behind the change. None of them say why such change is needed. They all repeat what the patch is doing, which is pretty easy to see from the diff. The commit must answer the trickiest question: why are we doing this? Best regards, Krzysztof
diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index a7ab3d377206..66876b409e59 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, + + /* Match specific DCPU versions */ + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, + /* API v3 is the default going forward */ { .compatible = "brcm,dpfe-cpu", .data = &dpfe_api_v3 }, {}
Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 to the Broadcom DPFE driver. Signed-off-by: Markus Mayer <mmayer@broadcom.com> --- drivers/memory/brcmstb_dpfe.c | 6 ++++++ 1 file changed, 6 insertions(+)