mbox

[pull,request,net,V3,00/15] mlx5 fixes 2023-12-05

Message ID 20231205214534.77771-1-saeed@kernel.org (mailing list archive)
State Deferred
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2023-12-05

Message

Saeed Mahameed Dec. 5, 2023, 9:45 p.m. UTC
From: Saeed Mahameed <saeedm@nvidia.com>

This series provides bug fixes to mlx5 driver.

V2->V3:
  - Drop commit #8 as requested by Jianbo.
  - Added two commits from Rahul to fix snprintf return val

V1->V2:
  - Drop commit #9 ("net/mlx5e: Forbid devlink reload if IPSec rules are
    offloaded"), we are working on a better fix

Please pull and let me know if there is any problem.

Thanks,
Saeed.



The following changes since commit 3c91c909f13f0c32b0d54d75c3f798479b1a84f5:

  octeontx2-af: fix a use-after-free in rvu_npa_register_reporters (2023-12-05 15:39:13 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2023-12-05

for you to fetch changes up to 1b6c74c73e3ba05dbba2dedf6703f025563231d0:

  net/mlx5e: Correct snprintf truncation handling for fw_version buffer used by representors (2023-12-05 13:43:01 -0800)

----------------------------------------------------------------
mlx5-fixes-2023-12-05

----------------------------------------------------------------
Chris Mi (2):
      net/mlx5e: Disable IPsec offload support if not FW steering
      net/mlx5e: TC, Don't offload post action rule if not supported

Dan Carpenter (1):
      net/mlx5: Fix a NULL vs IS_ERR() check

Gavin Li (1):
      net/mlx5e: Check netdev pointer before checking its net ns

Jianbo Liu (1):
      net/mlx5e: Reduce eswitch mode_lock protection context

Leon Romanovsky (4):
      net/mlx5e: Honor user choice of IPsec replay window size
      net/mlx5e: Ensure that IPsec sequence packet number starts from 1
      net/mlx5e: Remove exposure of IPsec RX flow steering struct
      net/mlx5e: Tidy up IPsec NAT-T SA discovery

Moshe Shemesh (2):
      net/mlx5e: Fix possible deadlock on mlx5e_tx_timeout_work
      net/mlx5: Nack sync reset request when HotPlug is enabled

Patrisious Haddad (2):
      net/mlx5e: Unify esw and normal IPsec status table creation/destruction
      net/mlx5e: Add IPsec and ASO syndromes check in HW

Rahul Rameshbabu (2):
      net/mlx5e: Correct snprintf truncation handling for fw_version buffer
      net/mlx5e: Correct snprintf truncation handling for fw_version buffer used by representors

 drivers/net/ethernet/mellanox/mlx5/core/en.h       |   1 +
 .../ethernet/mellanox/mlx5/core/en/tc/post_act.c   |   6 +
 .../ethernet/mellanox/mlx5/core/en_accel/ipsec.c   |  56 ++-
 .../ethernet/mellanox/mlx5/core/en_accel/ipsec.h   |  22 +-
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c         | 441 ++++++++++++++++++---
 .../mellanox/mlx5/core/en_accel/ipsec_offload.c    |  10 +-
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |   2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  27 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |   4 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    |  25 +-
 .../net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c | 160 +-------
 .../net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.h |  15 -
 drivers/net/ethernet/mellanox/mlx5/core/eswitch.c  |  35 +-
 drivers/net/ethernet/mellanox/mlx5/core/eswitch.h  |   2 +
 .../ethernet/mellanox/mlx5/core/eswitch_offloads.c |  54 ++-
 drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c |  29 ++
 include/linux/mlx5/mlx5_ifc.h                      |   9 +-
 17 files changed, 587 insertions(+), 311 deletions(-)

Comments

Jakub Kicinski Dec. 5, 2023, 10:48 p.m. UTC | #1
On Tue,  5 Dec 2023 13:45:19 -0800 Saeed Mahameed wrote:
> V2->V3:
>   - Drop commit #8 as requested by Jianbo.
>   - Added two commits from Rahul to fix snprintf return val
> 
> V1->V2:
>   - Drop commit #9 ("net/mlx5e: Forbid devlink reload if IPSec rules are
>     offloaded"), we are working on a better fix
> 
> Please pull and let me know if there is any problem.

Why are you reposting this without waiting 24 hours?
Saeed Mahameed Dec. 6, 2023, 8:58 p.m. UTC | #2
On 05 Dec 14:48, Jakub Kicinski wrote:
>On Tue,  5 Dec 2023 13:45:19 -0800 Saeed Mahameed wrote:
>> V2->V3:
>>   - Drop commit #8 as requested by Jianbo.
>>   - Added two commits from Rahul to fix snprintf return val
>>
>> V1->V2:
>>   - Drop commit #9 ("net/mlx5e: Forbid devlink reload if IPSec rules are
>>     offloaded"), we are working on a better fix
>>
>> Please pull and let me know if there is any problem.
>
>Why are you reposting this without waiting 24 hours?

V1 is more than a week old.
V2->V3 which you have an issue with, has no change other than removing 1
patch and adding 2 more patches that were already reviewed on the list
for more than a week as well.

This is a PR of patches that were already reviewed on the list for way
more than 24hours.

Anyway, do you want me to RESEND ?

Thanks,
Saeed.
Jakub Kicinski Dec. 7, 2023, 2:41 a.m. UTC | #3
On Wed, 6 Dec 2023 12:58:13 -0800 Saeed Mahameed wrote:
> V1 is more than a week old.
> V2->V3 which you have an issue with, has no change other than removing
> 1 patch and adding 2 more patches that were already reviewed on the list
> for more than a week as well.
> 
> This is a PR of patches that were already reviewed on the list for way
> more than 24hours.

The same rules for everybody. Please don't repost within 24h,
unless someone of import tells you to.

> Anyway, do you want me to RESEND ?

I guess that'd be counter-productive. I'll revive it tomorrow,
no need for a resend.
Saeed Mahameed Dec. 7, 2023, 7:03 p.m. UTC | #4
On 06 Dec 18:41, Jakub Kicinski wrote:
>On Wed, 6 Dec 2023 12:58:13 -0800 Saeed Mahameed wrote:
>> V1 is more than a week old.
>> V2->V3 which you have an issue with, has no change other than removing
>> 1 patch and adding 2 more patches that were already reviewed on the list
>> for more than a week as well.
>>
>> This is a PR of patches that were already reviewed on the list for way
>> more than 24hours.
>
>The same rules for everybody. Please don't repost within 24h,
>unless someone of import tells you to.
>

Ack.

>> Anyway, do you want me to RESEND ?
>
>I guess that'd be counter-productive. I'll revive it tomorrow,
>no need for a resend.

Thanks !

>-- 
>pv-bot: 24h