| Message ID | 20231206-wip-selftests-v2-0-c0350c2f5986@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests/hid: tablets fixes | expand |
On Wed, 6 Dec 2023, Benjamin Tissoires wrote: > Hi, > > the main trigger of this series was the XP-Pen issue[0]. > Basically, the tablets tests were good-ish but couldn't > handle that tablet both in terms of emulation or in terms > of detection of issues. > > So rework the tablets test a bit to be able to include the > XP-Pen patch later, once I have a kernel fix for it (right > now I only have a HID-BPF fix, meaning that the test will > fail if I include them). > > Also, vmtest.sh needed a little bit of care, because > boot2container moved, and I made it easier to reuse in a CI > environment. > > Cheers, > Benjamin > > Note: I got the confirmation off-list from Peter that his > rev-by applied to the whole series. > > [0] https://lore.kernel.org/all/nycvar.YFH.7.76.2311012033290.29220@cbobk.fhfr.pm/ > > Signed-off-by: Benjamin Tissoires <bentiss@kernel.org> FWIW Acked-by: Jiri Kosina <jkosina@suse.com> As far as I am concerned, feel free to push it to hid.git right away. And thanks a lot for all the work.
On Wed, 06 Dec 2023 11:45:51 +0100, Benjamin Tissoires wrote: > the main trigger of this series was the XP-Pen issue[0]. > Basically, the tablets tests were good-ish but couldn't > handle that tablet both in terms of emulation or in terms > of detection of issues. > > So rework the tablets test a bit to be able to include the > XP-Pen patch later, once I have a kernel fix for it (right > now I only have a HID-BPF fix, meaning that the test will > fail if I include them). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-5.8/selftests), thanks! [01/15] selftests/hid: vmtest.sh: update vm2c and container https://git.kernel.org/hid/hid/c/887f8094b335 [02/15] selftests/hid: vmtest.sh: allow finer control on the build steps https://git.kernel.org/hid/hid/c/46bc0277c250 [03/15] selftests/hid: base: allow for multiple skip_if_uhdev https://git.kernel.org/hid/hid/c/110292a77f7c [04/15] selftests/hid: tablets: remove unused class https://git.kernel.org/hid/hid/c/b5edacf79c8e [05/15] selftests/hid: tablets: move the transitions to PenState https://git.kernel.org/hid/hid/c/d52f52069fed [06/15] selftests/hid: tablets: move move_to function to PenDigitizer https://git.kernel.org/hid/hid/c/881ccc36b426 [07/15] selftests/hid: tablets: do not set invert when the eraser is used https://git.kernel.org/hid/hid/c/d8d7aa2266a7 [08/15] selftests/hid: tablets: set initial data for tilt/twist https://git.kernel.org/hid/hid/c/e08e493ff961 [09/15] selftests/hid: tablets: define the elements of PenState https://git.kernel.org/hid/hid/c/83912f83fabc [10/15] selftests/hid: tablets: add variants of states with buttons https://git.kernel.org/hid/hid/c/74452d6329be [11/15] selftests/hid: tablets: convert the primary button tests https://git.kernel.org/hid/hid/c/1f01537ef17e [12/15] selftests/hid: tablets: add a secondary barrel switch test https://git.kernel.org/hid/hid/c/76df1f72fb25 [13/15] selftests/hid: tablets: be stricter for some transitions https://git.kernel.org/hid/hid/c/ab9b82909e9b [14/15] selftests/hid: fix mypy complains https://git.kernel.org/hid/hid/c/ed5bc56cedca [15/15] selftests/hid: fix ruff linter complains https://git.kernel.org/hid/hid/c/f556aa957df8 Cheers,
On Thu, Dec 7, 2023 at 9:53 AM Benjamin Tissoires <bentiss@kernel.org> wrote: > > On Wed, 06 Dec 2023 11:45:51 +0100, Benjamin Tissoires wrote: > > the main trigger of this series was the XP-Pen issue[0]. > > Basically, the tablets tests were good-ish but couldn't > > handle that tablet both in terms of emulation or in terms > > of detection of issues. > > > > So rework the tablets test a bit to be able to include the > > XP-Pen patch later, once I have a kernel fix for it (right > > now I only have a HID-BPF fix, meaning that the test will > > fail if I include them). > > > > [...] > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-5.8/selftests), thanks! of course, it's for-6.8/selftests, not 5.8 :) Cheers, Benjamin > > [01/15] selftests/hid: vmtest.sh: update vm2c and container > https://git.kernel.org/hid/hid/c/887f8094b335 > [02/15] selftests/hid: vmtest.sh: allow finer control on the build steps > https://git.kernel.org/hid/hid/c/46bc0277c250 > [03/15] selftests/hid: base: allow for multiple skip_if_uhdev > https://git.kernel.org/hid/hid/c/110292a77f7c > [04/15] selftests/hid: tablets: remove unused class > https://git.kernel.org/hid/hid/c/b5edacf79c8e > [05/15] selftests/hid: tablets: move the transitions to PenState > https://git.kernel.org/hid/hid/c/d52f52069fed > [06/15] selftests/hid: tablets: move move_to function to PenDigitizer > https://git.kernel.org/hid/hid/c/881ccc36b426 > [07/15] selftests/hid: tablets: do not set invert when the eraser is used > https://git.kernel.org/hid/hid/c/d8d7aa2266a7 > [08/15] selftests/hid: tablets: set initial data for tilt/twist > https://git.kernel.org/hid/hid/c/e08e493ff961 > [09/15] selftests/hid: tablets: define the elements of PenState > https://git.kernel.org/hid/hid/c/83912f83fabc > [10/15] selftests/hid: tablets: add variants of states with buttons > https://git.kernel.org/hid/hid/c/74452d6329be > [11/15] selftests/hid: tablets: convert the primary button tests > https://git.kernel.org/hid/hid/c/1f01537ef17e > [12/15] selftests/hid: tablets: add a secondary barrel switch test > https://git.kernel.org/hid/hid/c/76df1f72fb25 > [13/15] selftests/hid: tablets: be stricter for some transitions > https://git.kernel.org/hid/hid/c/ab9b82909e9b > [14/15] selftests/hid: fix mypy complains > https://git.kernel.org/hid/hid/c/ed5bc56cedca > [15/15] selftests/hid: fix ruff linter complains > https://git.kernel.org/hid/hid/c/f556aa957df8 > > Cheers, > -- > Benjamin Tissoires <bentiss@kernel.org> >
Hi, the main trigger of this series was the XP-Pen issue[0]. Basically, the tablets tests were good-ish but couldn't handle that tablet both in terms of emulation or in terms of detection of issues. So rework the tablets test a bit to be able to include the XP-Pen patch later, once I have a kernel fix for it (right now I only have a HID-BPF fix, meaning that the test will fail if I include them). Also, vmtest.sh needed a little bit of care, because boot2container moved, and I made it easier to reuse in a CI environment. Cheers, Benjamin Note: I got the confirmation off-list from Peter that his rev-by applied to the whole series. [0] https://lore.kernel.org/all/nycvar.YFH.7.76.2311012033290.29220@cbobk.fhfr.pm/ Signed-off-by: Benjamin Tissoires <bentiss@kernel.org> --- Changes in v2: - took Peter's review into account - Added a few patches to make mypy and ruff happy given that I had to add a couple of type hints here and there - Link to v1: https://lore.kernel.org/r/20231129-wip-selftests-v1-0-ba15a1fe1b0d@kernel.org --- Benjamin Tissoires (15): selftests/hid: vmtest.sh: update vm2c and container selftests/hid: vmtest.sh: allow finer control on the build steps selftests/hid: base: allow for multiple skip_if_uhdev selftests/hid: tablets: remove unused class selftests/hid: tablets: move the transitions to PenState selftests/hid: tablets: move move_to function to PenDigitizer selftests/hid: tablets: do not set invert when the eraser is used selftests/hid: tablets: set initial data for tilt/twist selftests/hid: tablets: define the elements of PenState selftests/hid: tablets: add variants of states with buttons selftests/hid: tablets: convert the primary button tests selftests/hid: tablets: add a secondary barrel switch test selftests/hid: tablets: be stricter for some transitions selftests/hid: fix mypy complains selftests/hid: fix ruff linter complains tools/testing/selftests/hid/tests/base.py | 7 +- tools/testing/selftests/hid/tests/test_mouse.py | 14 +- tools/testing/selftests/hid/tests/test_tablet.py | 764 ++++++++++++++------- .../selftests/hid/tests/test_wacom_generic.py | 6 +- tools/testing/selftests/hid/vmtest.sh | 46 +- 5 files changed, 567 insertions(+), 270 deletions(-) --- base-commit: 4ea4ed22b57846facd9cb4af5f67cb7bd2792cf3 change-id: 20231121-wip-selftests-001ac427e086 Best regards,