| Message ID | 20230830224910.8091-16-quic_abhinavk@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/16] drm/msm/dpu: fix writeback programming for YUV cases | expand |
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: > > Since CDM block support has now been added for writeback blocks > add NV12 in the list of supported WB formats. > > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 713dfc079718..978330c6678e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -244,6 +244,7 @@ static const uint32_t wb2_formats[] = { > DRM_FORMAT_BGRA4444, > DRM_FORMAT_BGRX4444, > DRM_FORMAT_XBGR4444, > + DRM_FORMAT_NV12, > }; No. This way the driver would announce availability of NV12 even on chipsets where NV12 is not supported for the writeback. Please define separate formats array. BTW: does HW only support NV12 for the writeback? What about YV12 or e.g. NV21? > > /************************************************************* > -- > 2.40.1 >
On 8/30/2023 5:26 PM, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: >> >> Since CDM block support has now been added for writeback blocks >> add NV12 in the list of supported WB formats. >> >> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> index 713dfc079718..978330c6678e 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> @@ -244,6 +244,7 @@ static const uint32_t wb2_formats[] = { >> DRM_FORMAT_BGRA4444, >> DRM_FORMAT_BGRX4444, >> DRM_FORMAT_XBGR4444, >> + DRM_FORMAT_NV12, >> }; > > No. This way the driver would announce availability of NV12 even on > chipsets where NV12 is not supported for the writeback. Please define > separate formats array. > > BTW: does HW only support NV12 for the writeback? What about YV12 or e.g. NV21? > Yes, as we discussed in the prev patch, I will split the wb2_formats array to RGB only and RGB+YUV to address this issue. Regarding the full list of supported formats, here it is: https://git.codelinaro.org/clo/la/platform/vendor/opensource/display-drivers/-/blob/clo/main/msm/sde/sde_hw_catalog_format.h?ref_type=heads#L107 But YUV420 shouldnt be here as its not supported. I have to see if I can add some test cases in IGT to validate NV16 and DRM_FORMAT_YUYV. Hence I only exposed this one for now. >> >> /************************************************************* >> -- >> 2.40.1 >> > >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 713dfc079718..978330c6678e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -244,6 +244,7 @@ static const uint32_t wb2_formats[] = { DRM_FORMAT_BGRA4444, DRM_FORMAT_BGRX4444, DRM_FORMAT_XBGR4444, + DRM_FORMAT_NV12, }; /*************************************************************
Since CDM block support has now been added for writeback blocks add NV12 in the list of supported WB formats. Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + 1 file changed, 1 insertion(+)