[RESEND,AGAIN,v2,0/2] Add drm_dbg_ratelimited()

Message

Andi Shyti Dec. 6, 2023, 9:09 p.m. UTC

Hi,

This is the second time I am resending this series in its v2. It
has been reviewd, acked, blessed, discussed, rectified, assessed,
authorized, validated, glorified, praised, demanded, approved,
and yet, I don't understand why no one is merging it.

Thanks,
Andi

v2:
pick the right patch with the following changes:
 - add more r-b's
 - add a patch 2 where the drm_dbg_ratelimited is actually used.

Nirmoy Das (2):
  drm/print: Add drm_dbg_ratelimited
  drm/i915: Ratelimit debug log in vm_fault_ttm

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 include/drm/drm_print.h                 | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Thomas Zimmermann Dec. 7, 2023, 9 a.m. UTC | #1

Hi

Am 06.12.23 um 22:09 schrieb Andi Shyti:
> Hi,
> 
> This is the second time I am resending this series in its v2. It
> has been reviewd, acked, blessed, discussed, rectified, assessed,
> authorized, validated, glorified, praised, demanded, approved,
> and yet, I don't understand why no one is merging it.

I think it should go through the Intel tree.

Best regards
Thomas

> 
> Thanks,
> Andi
> 
> v2:
> pick the right patch with the following changes:
>   - add more r-b's
>   - add a patch 2 where the drm_dbg_ratelimited is actually used.
> 
> Nirmoy Das (2):
>    drm/print: Add drm_dbg_ratelimited
>    drm/i915: Ratelimit debug log in vm_fault_ttm
> 
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
>   include/drm/drm_print.h                 | 3 +++
>   2 files changed, 6 insertions(+), 2 deletions(-)
>

Maxime Ripard Dec. 7, 2023, 9:10 a.m. UTC | #2

On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> This is the second time I am resending this series in its v2. It
> has been reviewd, acked, blessed, discussed, rectified, assessed,
> authorized, validated, glorified, praised, demanded, approved,
> and yet, I don't understand why no one is merging it.

$ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
Jani Nikula <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Joonas Lahtinen <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Rodrigo Vivi <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Tvrtko Ursulin <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
David Airlie <[e-mail]> (maintainer:DRM DRIVERS)
Daniel Vetter <[e-mail]> (maintainer:DRM DRIVERS)
[e-mail] (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
[e-mail] (open list:DRM DRIVERS)
[e-mail] (open list)

You've Cc'd none of the i915 maintainers, that's why it's been stuck.

Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?

Maxime

Andi Shyti Dec. 7, 2023, 9:23 a.m. UTC | #3

Hi Thomas and Maxime,

thanks for the answer,

On Thu, Dec 07, 2023 at 10:10:55AM +0100, Maxime Ripard wrote:
> On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> > This is the second time I am resending this series in its v2. It
> > has been reviewd, acked, blessed, discussed, rectified, assessed,
> > authorized, validated, glorified, praised, demanded, approved,
> > and yet, I don't understand why no one is merging it.
> 
> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
> Jani Nikula <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Joonas Lahtinen <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Rodrigo Vivi <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Tvrtko Ursulin <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> David Airlie <[e-mail]> (maintainer:DRM DRIVERS)
> Daniel Vetter <[e-mail]> (maintainer:DRM DRIVERS)
> [e-mail] (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> [e-mail] (open list:DRM DRIVERS)
> [e-mail] (open list)
> 
> You've Cc'd none of the i915 maintainers, that's why it's been stuck.
> 
> Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?

The main change here is in drm_print.h, though and there is just
an example of usage in i915. I though this should go through the
drm branch.

Is it OK if I push it in drm-intel-next?

Thanks,
Andi

Maxime Ripard Dec. 7, 2023, 1:06 p.m. UTC | #4

On Thu, Dec 07, 2023 at 10:23:08AM +0100, Andi Shyti wrote:
> Hi Thomas and Maxime,
> 
> thanks for the answer,
> 
> On Thu, Dec 07, 2023 at 10:10:55AM +0100, Maxime Ripard wrote:
> > On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> > > This is the second time I am resending this series in its v2. It
> > > has been reviewd, acked, blessed, discussed, rectified, assessed,
> > > authorized, validated, glorified, praised, demanded, approved,
> > > and yet, I don't understand why no one is merging it.
> > 
> > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
> > Jani Nikula <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Joonas Lahtinen <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Rodrigo Vivi <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Tvrtko Ursulin <[e-mail]> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > David Airlie <[e-mail]> (maintainer:DRM DRIVERS)
> > Daniel Vetter <[e-mail]> (maintainer:DRM DRIVERS)
> > [e-mail] (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > [e-mail] (open list:DRM DRIVERS)
> > [e-mail] (open list)
> > 
> > You've Cc'd none of the i915 maintainers, that's why it's been stuck.
> > 
> > Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?
> 
> The main change here is in drm_print.h, though and there is just
> an example of usage in i915. I though this should go through the
> drm branch.
> 
> Is it OK if I push it in drm-intel-next?

Sure, and you can add my acked-by on the first

Maxime