Message ID | 20231128213536.3764212-4-sjoerd@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Moxtet bus fixes | expand |
On Tue, 28 Nov 2023 22:35:06 +0100 Sjoerd Simons <sjoerd@collabora.com> wrote: > The rtc on the mox shares its interrupt line with the moxtet bus. Set > the interrupt type to be consistent between both devices. This ensures > correct setup of the interrupt line regardless of probing order. > > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com> > Cc: stable@vger.kernel.org # v6.2+ > Fixes: 21aad8ba615e ("arm64: dts: armada-3720-turris-mox: Add missing interrupt for RTC") > > --- > > (no changes since v1) > > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 9eab2bb22134..805ef2d79b40 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -130,7 +130,7 @@ rtc@6f { > compatible = "microchip,mcp7940x"; > reg = <0x6f>; > interrupt-parent = <&gpiosb>; > - interrupts = <5 0>; /* GPIO2_5 */ > + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; /* GPIO2_5 */ > }; > }; > Reviewed-by: Marek BehĂșn <kabel@kernel.org>
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts index 9eab2bb22134..805ef2d79b40 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts @@ -130,7 +130,7 @@ rtc@6f { compatible = "microchip,mcp7940x"; reg = <0x6f>; interrupt-parent = <&gpiosb>; - interrupts = <5 0>; /* GPIO2_5 */ + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; /* GPIO2_5 */ }; };
The rtc on the mox shares its interrupt line with the moxtet bus. Set the interrupt type to be consistent between both devices. This ensures correct setup of the interrupt line regardless of probing order. Signed-off-by: Sjoerd Simons <sjoerd@collabora.com> Cc: stable@vger.kernel.org # v6.2+ Fixes: 21aad8ba615e ("arm64: dts: armada-3720-turris-mox: Add missing interrupt for RTC") --- (no changes since v1) arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)