| Message ID | 20230927181214.129346-2-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ieee802154: Associations between devices | expand |
On Wed, 2023-09-27 at 18:12:04 UTC, Miquel Raynal wrote: > Soon association and disassociation will be implemented, which will > require to be able to either change the PAN ID from 0xFFFF to a real > value when association succeeded, or to reset the PAN ID to 0xFFFF upon > disassociation. Let's allow to do that manually for now. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging. Miquel
Hello Miquel, On 20.11.23 12:01, Miquel Raynal wrote: > On Wed, 2023-09-27 at 18:12:04 UTC, Miquel Raynal wrote: >> Soon association and disassociation will be implemented, which will >> require to be able to either change the PAN ID from 0xFFFF to a real >> value when association succeeded, or to reset the PAN ID to 0xFFFF upon >> disassociation. Let's allow to do that manually for now. >> >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging. I can't see this, or any other patch from the series, in the staging branch. Did you forget to push this out to kernel.org? regards Stefan Schmidt
Hi Stefan, stefan@datenfreihafen.org wrote on Thu, 7 Dec 2023 21:27:59 +0100: > Hello Miquel, > > > On 20.11.23 12:01, Miquel Raynal wrote: > > On Wed, 2023-09-27 at 18:12:04 UTC, Miquel Raynal wrote: > >> Soon association and disassociation will be implemented, which will > >> require to be able to either change the PAN ID from 0xFFFF to a real > >> value when association succeeded, or to reset the PAN ID to 0xFFFF upon > >> disassociation. Let's allow to do that manually for now. > >> > >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging. > > I can't see this, or any other patch from the series, in the staging branch. Did you forget to push this out to kernel.org? Oh! Thanks for spotting this, I actually pushed the branch (otherwise the hook would not have sent these messages) but the push operation apparently failed at some point so the tip of the branch was not updated. This is now fixed. Thanks for the reviews by the way. Miquèl
Hi Stefan, stefan@datenfreihafen.org wrote on Thu, 7 Dec 2023 21:27:59 +0100: > Hello Miquel, > > > On 20.11.23 12:01, Miquel Raynal wrote: > > On Wed, 2023-09-27 at 18:12:04 UTC, Miquel Raynal wrote: > >> Soon association and disassociation will be implemented, which will > >> require to be able to either change the PAN ID from 0xFFFF to a real > >> value when association succeeded, or to reset the PAN ID to 0xFFFF upon > >> disassociation. Let's allow to do that manually for now. > >> > >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging. > > I can't see this, or any other patch from the series, in the staging branch. Did you forget to push this out to kernel.org? While preparing the PR for net maintainers I realized that in the above message I actually pushed on the wpan repo instead of the wpan-next repo by mistake. This explain why you didn't see it on the wpan-next/[staging|master] branches. I've fixed my mess hopefully, and will anyway send the PR today as the patches have been in -next for a week or more already. Thanks, Miquèl
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index d610c1886160..46ac6f599fe1 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1087,16 +1087,6 @@ static int nl802154_set_pan_id(struct sk_buff *skb, struct genl_info *info) pan_id = nla_get_le16(info->attrs[NL802154_ATTR_PAN_ID]); - /* TODO - * I am not sure about to check here on broadcast pan_id. - * Broadcast is a valid setting, comment from 802.15.4: - * If this value is 0xffff, the device is not associated. - * - * This could useful to simple deassociate an device. - */ - if (pan_id == cpu_to_le16(IEEE802154_PAN_ID_BROADCAST)) - return -EINVAL; - return rdev_set_pan_id(rdev, wpan_dev, pan_id); }
Soon association and disassociation will be implemented, which will require to be able to either change the PAN ID from 0xFFFF to a real value when association succeeded, or to reset the PAN ID to 0xFFFF upon disassociation. Let's allow to do that manually for now. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- net/ieee802154/nl802154.c | 10 ---------- 1 file changed, 10 deletions(-)