| Message ID | 20231207080953.27976-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | OSStest: use CONFIG_X86_GENERIC for 32-bit x86 kernel | expand |
On Thu, Dec 07, 2023 at 09:09:53AM +0100, Juergen Gross wrote: > Today the cpu type for a 32-bit x86 kernel is not specified in the > used kernel config, resulting in the M686 to be used. > > Instead of using the M686 which isn't even a 64-bit cpu (thus not > capable to run a Xen guest), use the X86_GENERIC variant which is > more appropriate. > > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > ts-kernel-build | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ts-kernel-build b/ts-kernel-build > index 719b33aa..d9e033c4 100755 > --- a/ts-kernel-build > +++ b/ts-kernel-build > @@ -608,7 +608,10 @@ setopt CONFIG_POWER_RESET_XGENE y > setopt CONFIG_RTC_DRV_XGENE y > > case ${XEN_TARGET_ARCH} in > - x86_32) setopt CONFIG_64BIT n ;; > + x86_32) > + setopt CONFIG_64BIT n > + setopt CONFIG_X86_GENERIC y It would be nice if that was working, but XEN_TARGET_ARCH is never set, so the change isn't going to work. I'm preparing patches to set X86_GENERIC on i386 builds, and fixing some issues. Thanks,
On 08.12.23 16:59, Anthony PERARD wrote: > On Thu, Dec 07, 2023 at 09:09:53AM +0100, Juergen Gross wrote: >> Today the cpu type for a 32-bit x86 kernel is not specified in the >> used kernel config, resulting in the M686 to be used. >> >> Instead of using the M686 which isn't even a 64-bit cpu (thus not >> capable to run a Xen guest), use the X86_GENERIC variant which is >> more appropriate. >> >> Signed-off-by: Juergen Gross <jgross@suse.com> >> --- >> ts-kernel-build | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/ts-kernel-build b/ts-kernel-build >> index 719b33aa..d9e033c4 100755 >> --- a/ts-kernel-build >> +++ b/ts-kernel-build >> @@ -608,7 +608,10 @@ setopt CONFIG_POWER_RESET_XGENE y >> setopt CONFIG_RTC_DRV_XGENE y >> >> case ${XEN_TARGET_ARCH} in >> - x86_32) setopt CONFIG_64BIT n ;; >> + x86_32) >> + setopt CONFIG_64BIT n >> + setopt CONFIG_X86_GENERIC y > > It would be nice if that was working, but XEN_TARGET_ARCH is never set, > so the change isn't going to work. Oh, how ... funny? weird? strange? > > I'm preparing patches to set X86_GENERIC on i386 builds, and fixing some > issues. Thanks, Juergen
On 08.12.23 16:59, Anthony PERARD wrote: > On Thu, Dec 07, 2023 at 09:09:53AM +0100, Juergen Gross wrote: >> Today the cpu type for a 32-bit x86 kernel is not specified in the >> used kernel config, resulting in the M686 to be used. >> >> Instead of using the M686 which isn't even a 64-bit cpu (thus not >> capable to run a Xen guest), use the X86_GENERIC variant which is >> more appropriate. >> >> Signed-off-by: Juergen Gross <jgross@suse.com> >> --- >> ts-kernel-build | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/ts-kernel-build b/ts-kernel-build >> index 719b33aa..d9e033c4 100755 >> --- a/ts-kernel-build >> +++ b/ts-kernel-build >> @@ -608,7 +608,10 @@ setopt CONFIG_POWER_RESET_XGENE y >> setopt CONFIG_RTC_DRV_XGENE y >> >> case ${XEN_TARGET_ARCH} in >> - x86_32) setopt CONFIG_64BIT n ;; >> + x86_32) >> + setopt CONFIG_64BIT n >> + setopt CONFIG_X86_GENERIC y > > It would be nice if that was working, but XEN_TARGET_ARCH is never set, > so the change isn't going to work. > > I'm preparing patches to set X86_GENERIC on i386 builds, and fixing some > issues. Oh, BTW, I think it might be a good idea to add a MAINTAINERS entry in the Xen git tree for OSStest. I was pretty sure you are the one to send patches to, but maybe someone else should receive them? Juergen
diff --git a/ts-kernel-build b/ts-kernel-build index 719b33aa..d9e033c4 100755 --- a/ts-kernel-build +++ b/ts-kernel-build @@ -608,7 +608,10 @@ setopt CONFIG_POWER_RESET_XGENE y setopt CONFIG_RTC_DRV_XGENE y case ${XEN_TARGET_ARCH} in - x86_32) setopt CONFIG_64BIT n ;; + x86_32) + setopt CONFIG_64BIT n + setopt CONFIG_X86_GENERIC y + ;; x86_64) setopt CONFIG_64BIT y setopt CONFIG_IA32_EMULATION y
Today the cpu type for a 32-bit x86 kernel is not specified in the used kernel config, resulting in the M686 to be used. Instead of using the M686 which isn't even a 64-bit cpu (thus not capable to run a Xen guest), use the X86_GENERIC variant which is more appropriate. Signed-off-by: Juergen Gross <jgross@suse.com> --- ts-kernel-build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)