| Message ID | 20231211025624.28991-1-chunfeng.yun@mediatek.com |
|---|---|
| State | Accepted |
| Commit | cc230a4cd8e91f64c90b5494dfd76848197418ed |
| Headers | show |
| Series | [v2,1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch | expand |
On 11/12/2023 03:56, Chunfeng Yun wrote: > Due to some old SoCs with shared t-phy between usb3 and pcie only support > force-mode switch, and shared and non-shared t-phy may exist at the same > time on a SoC, can't use compatible to distinguish between shared and > non-shared t-phy, add a property to supported it. > Currently, only support switch from default pcie mode to usb3 mode. > But now prefer to use "mediatek,syscon-type" on new SoC as far as possible. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 11 Dec 2023 10:56:23 +0800, Chunfeng Yun wrote: > Due to some old SoCs with shared t-phy between usb3 and pcie only support > force-mode switch, and shared and non-shared t-phy may exist at the same > time on a SoC, can't use compatible to distinguish between shared and > non-shared t-phy, add a property to supported it. > Currently, only support switch from default pcie mode to usb3 mode. > But now prefer to use "mediatek,syscon-type" on new SoC as far as possible. > > [...] Applied, thanks! [1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch commit: cc230a4cd8e91f64c90b5494dfd76848197418ed [2/2] phy: mediatek: tphy: add support force phy mode switch commit: 9b27303003f5af0d378f29ccccea57c7d65cc642 Best regards,
On 12/22/23 01:15, Vinod Koul wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On Mon, 11 Dec 2023 10:56:23 +0800, Chunfeng Yun wrote: >> Due to some old SoCs with shared t-phy between usb3 and pcie only support >> force-mode switch, and shared and non-shared t-phy may exist at the same >> time on a SoC, can't use compatible to distinguish between shared and >> non-shared t-phy, add a property to supported it. >> Currently, only support switch from default pcie mode to usb3 mode. >> But now prefer to use "mediatek,syscon-type" on new SoC as far as possible. >> >> [...] > > Applied, thanks! > > [1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch > commit: cc230a4cd8e91f64c90b5494dfd76848197418ed > [2/2] phy: mediatek: tphy: add support force phy mode switch > commit: 9b27303003f5af0d378f29ccccea57c7d65cc642 > > Best regards, > -- > ~Vinod > > Is it possible to cherry-pick these 2 patches to stable branches? These 2 patches help fix USB port 1 (xhci1) for board mt8395-genio-1200-evb. The following branch has been tested. - linux-6.7.y (6.7.5): apply test, build pass, function tested OK (with corresponded dtb change). - linux-6.6.y (6.6.17): apply test, build pass. - linux-6.1.y (6.1.78): apply test, build pass. Thanks. Macpaul Lin
diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml index 2bb91542e984..acba0720125d 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml @@ -235,6 +235,15 @@ patternProperties: Specify the flag to enable BC1.2 if support it type: boolean + mediatek,force-mode: + description: + The force mode is used to manually switch the shared phy mode between + USB3 and PCIe, when USB3 phy type is selected by the consumer, and + force-mode is set, will cause phy's power and pipe toggled and force + phy as USB3 mode which switched from default PCIe mode. But perfer to + use the property "mediatek,syscon-type" for newer SoCs that support it. + type: boolean + mediatek,syscon-type: $ref: /schemas/types.yaml#/definitions/phandle-array maxItems: 1
Due to some old SoCs with shared t-phy between usb3 and pcie only support force-mode switch, and shared and non-shared t-phy may exist at the same time on a SoC, can't use compatible to distinguish between shared and non-shared t-phy, add a property to supported it. Currently, only support switch from default pcie mode to usb3 mode. But now prefer to use "mediatek,syscon-type" on new SoC as far as possible. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v2: modify commit message, and property description --- Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)