[v13,0/5] PCI: add 4x lane support for pci-j721e controllers

Message

s-vadapalli Nov. 28, 2023, 5:43 a.m. UTC

Hello,

This series adds support to the pci-j721e PCIe controller for up to 4x Lane
configuration supported by TI's J784S4 SoC. Bindings are also added for
the num-lanes property which shall be used by the driver. The compatible
for J784S4 SoC is added.

This series is based on linux-next tagged next-20231128.

Regards,
Siddharth.

---
v12:
https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
Changes since v12:
- Rebased series on linux-next tagged next-20231128.
- Reordered patches with bindings patches first followed by driver
  patches.
- Collected Reviewed-by tag from
  Krzysztof Kozlowski <[e-mail]>
  which was missed in the v12 series as pointed out at:
  https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/


Matt Ranostay (5):
  dt-bindings: PCI: ti,j721e-pci-*: add checks for num-lanes
  dt-bindings: PCI: ti,j721e-pci-*: add j784s4-pci-* compatible strings
  PCI: j721e: Add per platform maximum lane settings
  PCI: j721e: Add PCIe 4x lane selection support
  PCI: j721e: add j784s4 PCIe configuration

 .../bindings/pci/ti,j721e-pci-ep.yaml         | 39 ++++++++++++++--
 .../bindings/pci/ti,j721e-pci-host.yaml       | 39 ++++++++++++++--
 drivers/pci/controller/cadence/pci-j721e.c    | 45 ++++++++++++++++---
 3 files changed, 112 insertions(+), 11 deletions(-)

Comments

Maxime Ripard Dec. 11, 2023, 8:57 a.m. UTC | #1

Hi Bjorn, Krzysztof, Lorenzo, Rob,

On Tue, Nov 28, 2023 at 11:13:57AM +0530, Siddharth Vadapalli wrote:
> This series adds support to the pci-j721e PCIe controller for up to 4x Lane
> configuration supported by TI's J784S4 SoC. Bindings are also added for
> the num-lanes property which shall be used by the driver. The compatible
> for J784S4 SoC is added.
> 
> This series is based on linux-next tagged next-20231128.

These patches have been floating around for a long time (v12 was almost
identical and was submitted back in April, without any review back then
already [1]), and it looks like reviewers are happy with it.

Could you merge them to get them in 6.8?

Thanks!
Maxime

1: https://lore.kernel.org/lkml/[e-mail]/

Krzysztof Wilczyński Dec. 13, 2023, 7:05 p.m. UTC | #2

Hello,

> This series adds support to the pci-j721e PCIe controller for up to 4x Lane
> configuration supported by TI's J784S4 SoC. Bindings are also added for
> the num-lanes property which shall be used by the driver. The compatible
> for J784S4 SoC is added.
> 
> This series is based on linux-next tagged next-20231128.

Applied to controller/cadence, thank you!

[01/05] dt-bindings: PCI: ti,j721e-pci-*: Add checks for num-lanes
        https://git.kernel.org/pci/pci/c/b3ba0f6e82cb
[02/05] dt-bindings: PCI: ti,j721e-pci-*: Add j784s4-pci-* compatible strings
        https://git.kernel.org/pci/pci/c/adc14d44d7cb
[03/05] PCI: j721e: Add per platform maximum lane settings
        https://git.kernel.org/pci/pci/c/3ac7f14084f5
[04/05] PCI: j721e: Add PCIe 4x lane selection support
        https://git.kernel.org/pci/pci/c/4490f559f755
[05/05] PCI: j721e: Add j784s4 PCIe configuration
        https://git.kernel.org/pci/pci/c/9ca59b45ecf3

	Krzysztof

Krzysztof Wilczyński Dec. 13, 2023, 7:13 p.m. UTC | #3

Hi Maxime,

> > This series adds support to the pci-j721e PCIe controller for up to 4x Lane
> > configuration supported by TI's J784S4 SoC. Bindings are also added for
> > the num-lanes property which shall be used by the driver. The compatible
> > for J784S4 SoC is added.
> > 
> > This series is based on linux-next tagged next-20231128.
> 
> These patches have been floating around for a long time (v12 was almost
> identical and was submitted back in April, without any review back then
> already [1]), and it looks like reviewers are happy with it.

Having a glance, it looks good to me, too.

> Could you merge them to get them in 6.8?


Applied, so it should make it to 6.8.  Apologies for the delay.

	Krzysztof