| Message ID | 20231213232822.2950853-4-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Delegated to: | Mat Martineau |
| Headers | show |
| Series | None | expand |
On Wed, 13 Dec 2023, Jakub Kicinski wrote: > We assume in handful of places that the name of the spec is > the same as the name of the family. We could fix that but > it seems like a fair assumption to make. Rename the MPTCP > spec instead. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: matttbe@kernel.org > CC: martineau@kernel.org > CC: dcaratti@redhat.com > CC: mptcp@lists.linux.dev > --- > Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} | 0 > include/uapi/linux/mptcp_pm.h | 2 +- > net/mptcp/mptcp_pm_gen.c | 2 +- > net/mptcp/mptcp_pm_gen.h | 2 +- > 4 files changed, 3 insertions(+), 3 deletions(-) > rename Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} (100%) > Hi Jakub - The renaming here is fine. "path management" is the right expansion of "pm" in this context, so you can remove the "(?)" from the summary line. Reviewed-by: Mat Martineau <martineau@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes: > We assume in handful of places that the name of the spec is > the same as the name of the family. We could fix that but > it seems like a fair assumption to make. Rename the MPTCP > spec instead. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Hi Jakub,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/netlink-specs-ovs-remove-fixed-header-fields-from-attrs/20231214-073118
base: net-next/main
patch link: https://lore.kernel.org/r/20231213232822.2950853-4-kuba%40kernel.org
patch subject: [PATCH net-next 3/3] netlink: specs: mptcp: rename the MPTCP path management(?) spec
reproduce: (https://download.01.org/0day-ci/archive/20231215/202312150140.ST22T64E-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312150140.ST22T64E-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/netlink/specs/mptcp.yaml
diff --git a/Documentation/netlink/specs/mptcp.yaml b/Documentation/netlink/specs/mptcp_pm.yaml similarity index 100% rename from Documentation/netlink/specs/mptcp.yaml rename to Documentation/netlink/specs/mptcp_pm.yaml diff --git a/include/uapi/linux/mptcp_pm.h b/include/uapi/linux/mptcp_pm.h index b5d11aece408..50589e5dd6a3 100644 --- a/include/uapi/linux/mptcp_pm.h +++ b/include/uapi/linux/mptcp_pm.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */ /* Do not edit directly, auto-generated from: */ -/* Documentation/netlink/specs/mptcp.yaml */ +/* Documentation/netlink/specs/mptcp_pm.yaml */ /* YNL-GEN uapi header */ #ifndef _UAPI_LINUX_MPTCP_PM_H diff --git a/net/mptcp/mptcp_pm_gen.c b/net/mptcp/mptcp_pm_gen.c index a2325e70ddab..670da7822e6c 100644 --- a/net/mptcp/mptcp_pm_gen.c +++ b/net/mptcp/mptcp_pm_gen.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) /* Do not edit directly, auto-generated from: */ -/* Documentation/netlink/specs/mptcp.yaml */ +/* Documentation/netlink/specs/mptcp_pm.yaml */ /* YNL-GEN kernel source */ #include <net/netlink.h> diff --git a/net/mptcp/mptcp_pm_gen.h b/net/mptcp/mptcp_pm_gen.h index 10579d184587..ac9fc7225b6a 100644 --- a/net/mptcp/mptcp_pm_gen.h +++ b/net/mptcp/mptcp_pm_gen.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */ /* Do not edit directly, auto-generated from: */ -/* Documentation/netlink/specs/mptcp.yaml */ +/* Documentation/netlink/specs/mptcp_pm.yaml */ /* YNL-GEN kernel header */ #ifndef _LINUX_MPTCP_PM_GEN_H
We assume in handful of places that the name of the spec is the same as the name of the family. We could fix that but it seems like a fair assumption to make. Rename the MPTCP spec instead. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: matttbe@kernel.org CC: martineau@kernel.org CC: dcaratti@redhat.com CC: mptcp@lists.linux.dev --- Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} | 0 include/uapi/linux/mptcp_pm.h | 2 +- net/mptcp/mptcp_pm_gen.c | 2 +- net/mptcp/mptcp_pm_gen.h | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) rename Documentation/netlink/specs/{mptcp.yaml => mptcp_pm.yaml} (100%)