diff mbox series

[isar-cip-core] distro: fix dosfstools-native is not applied to security target

Message ID 20231214130012.16994-1-venkata.pyla@toshiba-tsip.com (mailing list archive)
State Accepted
Headers show
Series [isar-cip-core] distro: fix dosfstools-native is not applied to security target | expand

Commit Message

Venkata Pyla Dec. 14, 2023, 1 p.m. UTC
From: venkata pyla <venkata.pyla@toshiba-tsip.com>

'dosfstools-native' is required for vfat images to build reproducibly,
this value is assigned to `IMAGER_BUILD_DEPS` as a default value, but when
other local configurations defines some value to it then the default
value is skipped, so modifed to append the value instead of setting as a
default.

Fixes: #85

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
---
 conf/distro/cip-core-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Dec. 14, 2023, 2:25 p.m. UTC | #1
On 14.12.23 14:00, venkata.pyla@toshiba-tsip.com wrote:
> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
> 
> 'dosfstools-native' is required for vfat images to build reproducibly,
> this value is assigned to `IMAGER_BUILD_DEPS` as a default value, but when
> other local configurations defines some value to it then the default
> value is skipped, so modifed to append the value instead of setting as a
> default.
> 
> Fixes: #85
> 
> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
> ---
>  conf/distro/cip-core-common.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/distro/cip-core-common.inc b/conf/distro/cip-core-common.inc
> index fb5b98d..dfee24a 100644
> --- a/conf/distro/cip-core-common.inc
> +++ b/conf/distro/cip-core-common.inc
> @@ -15,5 +15,5 @@ WKS_FILE ?= "${MACHINE}.wks"
>  
>  CIP_IMAGE_OPTIONS ?= ""
>  
> -IMAGER_BUILD_DEPS ?= "dosfstools-native"
> +IMAGER_BUILD_DEPS:append = " dosfstools-native"
>  IMAGER_BUILD_DEPS:remove:buster = "dosfstools-native"

Thanks, applied.

Jan
diff mbox series

Patch

diff --git a/conf/distro/cip-core-common.inc b/conf/distro/cip-core-common.inc
index fb5b98d..dfee24a 100644
--- a/conf/distro/cip-core-common.inc
+++ b/conf/distro/cip-core-common.inc
@@ -15,5 +15,5 @@  WKS_FILE ?= "${MACHINE}.wks"
 
 CIP_IMAGE_OPTIONS ?= ""
 
-IMAGER_BUILD_DEPS ?= "dosfstools-native"
+IMAGER_BUILD_DEPS:append = " dosfstools-native"
 IMAGER_BUILD_DEPS:remove:buster = "dosfstools-native"