| Message ID | 20231214-x1e80100-dts-fix-pm8550-regulators-supplies-v1-1-6b5830dc337e@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f8ab2984e5b0f1aaf94e3810b809bae055020e11 |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100-crd: Fix supplies for some LDOs in PM8550 | expand |
On 12/14/23 20:24, Abel Vesa wrote: > The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4 > from PM8550ve. This needs to be done through shared supply approach > otherwise the bindings check fails. Not only that, but Linux also doesn't parse it :D > > Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 23-12-14 20:31:46, Konrad Dybcio wrote: > > > On 12/14/23 20:24, Abel Vesa wrote: > > The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4 > > from PM8550ve. This needs to be done through shared supply approach > > otherwise the bindings check fails. > Not only that, but Linux also doesn't parse it :D Good thing they are not used by any consumer (yet) then. ;) > > > > Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device") > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Thanks! > > Konrad
On Thu, 14 Dec 2023 21:24:50 +0200, Abel Vesa wrote: > The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4 > from PM8550ve. This needs to be done through shared supply approach > otherwise the bindings check fails. > > Applied, thanks! [1/1] arm64: dts: qcom: x1e80100-crd: Fix supplies for some LDOs in PM8550 commit: f8ab2984e5b0f1aaf94e3810b809bae055020e11 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index c209ae59c6b5..7532d8eca2de 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -58,13 +58,11 @@ regulators-0 { vdd-bob1-supply = <&vph_pwr>; vdd-bob2-supply = <&vph_pwr>; - vdd-l1-supply = <&vreg_s4c_1p8>; + vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>; vdd-l2-l13-l14-supply = <&vreg_bob1>; - vdd-l4-supply = <&vreg_s4c_1p8>; vdd-l5-l16-supply = <&vreg_bob1>; vdd-l6-l7-supply = <&vreg_bob2>; vdd-l8-l9-supply = <&vreg_bob1>; - vdd-l10-supply = <&vreg_s4c_1p8>; vdd-l12-supply = <&vreg_s5j_1p2>; vdd-l15-supply = <&vreg_s4c_1p8>; vdd-l17-supply = <&vreg_bob2>;
The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4 from PM8550ve. This needs to be done through shared supply approach otherwise the bindings check fails. Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- base-commit: 7b0e611dc474ffa67d3a6ea235085bf423ee5f2a change-id: 20231214-x1e80100-dts-fix-pm8550-regulators-supplies-1e35fa367ccf Best regards,