| Message ID | 20231123185821.2272504-2-christoph.muellner@vrull.eu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b91c26fdb0e8150cdb610cdaadea62bb5e43bee0 |
| Headers | show |
| Series | tools: selftests: riscv: Fix compiler warnings | expand |
On 23/11/2023 19:58, Christoph Muellner wrote: > From: Christoph Müllner <christoph.muellner@vrull.eu> > > GCC prints a couple of format string warnings when compiling > the hwprobe test. Let's follow the recommendation in > Documentation/printk-formats.txt to fix these warnings. > > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> > --- > tools/testing/selftests/riscv/hwprobe/hwprobe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/riscv/hwprobe/hwprobe.c b/tools/testing/selftests/riscv/hwprobe/hwprobe.c > index c474891df307..abb825811c70 100644 > --- a/tools/testing/selftests/riscv/hwprobe/hwprobe.c > +++ b/tools/testing/selftests/riscv/hwprobe/hwprobe.c > @@ -29,7 +29,7 @@ int main(int argc, char **argv) > /* Fail if the kernel claims not to recognize a base key. */ > if ((i < 4) && (pairs[i].key != i)) > ksft_exit_fail_msg("Failed to recognize base key: key != i, " > - "key=%ld, i=%ld\n", pairs[i].key, i); > + "key=%lld, i=%ld\n", pairs[i].key, i); > > if (pairs[i].key != RISCV_HWPROBE_KEY_BASE_BEHAVIOR) > continue; > @@ -37,7 +37,7 @@ int main(int argc, char **argv) > if (pairs[i].value & RISCV_HWPROBE_BASE_BEHAVIOR_IMA) > continue; > > - ksft_exit_fail_msg("Unexpected pair: (%ld, %ld)\n", pairs[i].key, pairs[i].value); > + ksft_exit_fail_msg("Unexpected pair: (%lld, %llu)\n", pairs[i].key, pairs[i].value); > } > > out = riscv_hwprobe(pairs, 8, 0, 0, 0); You can add: Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Thanks! Alex
On 23/11/2023 19:58, Christoph Muellner wrote: > From: Christoph Müllner <christoph.muellner@vrull.eu> > > GCC prints a couple of format string warnings when compiling > the hwprobe test. Let's follow the recommendation in > Documentation/printk-formats.txt to fix these warnings. > > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> > --- > tools/testing/selftests/riscv/hwprobe/hwprobe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/riscv/hwprobe/hwprobe.c b/tools/testing/selftests/riscv/hwprobe/hwprobe.c > index c474891df307..abb825811c70 100644 > --- a/tools/testing/selftests/riscv/hwprobe/hwprobe.c > +++ b/tools/testing/selftests/riscv/hwprobe/hwprobe.c > @@ -29,7 +29,7 @@ int main(int argc, char **argv) > /* Fail if the kernel claims not to recognize a base key. */ > if ((i < 4) && (pairs[i].key != i)) > ksft_exit_fail_msg("Failed to recognize base key: key != i, " > - "key=%ld, i=%ld\n", pairs[i].key, i); > + "key=%lld, i=%ld\n", pairs[i].key, i); > > if (pairs[i].key != RISCV_HWPROBE_KEY_BASE_BEHAVIOR) > continue; > @@ -37,7 +37,7 @@ int main(int argc, char **argv) > if (pairs[i].value & RISCV_HWPROBE_BASE_BEHAVIOR_IMA) > continue; > > - ksft_exit_fail_msg("Unexpected pair: (%ld, %ld)\n", pairs[i].key, pairs[i].value); > + ksft_exit_fail_msg("Unexpected pair: (%lld, %llu)\n", pairs[i].key, pairs[i].value); > } > > out = riscv_hwprobe(pairs, 8, 0, 0, 0); You can add: Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Thanks! Alex
diff --git a/tools/testing/selftests/riscv/hwprobe/hwprobe.c b/tools/testing/selftests/riscv/hwprobe/hwprobe.c index c474891df307..abb825811c70 100644 --- a/tools/testing/selftests/riscv/hwprobe/hwprobe.c +++ b/tools/testing/selftests/riscv/hwprobe/hwprobe.c @@ -29,7 +29,7 @@ int main(int argc, char **argv) /* Fail if the kernel claims not to recognize a base key. */ if ((i < 4) && (pairs[i].key != i)) ksft_exit_fail_msg("Failed to recognize base key: key != i, " - "key=%ld, i=%ld\n", pairs[i].key, i); + "key=%lld, i=%ld\n", pairs[i].key, i); if (pairs[i].key != RISCV_HWPROBE_KEY_BASE_BEHAVIOR) continue; @@ -37,7 +37,7 @@ int main(int argc, char **argv) if (pairs[i].value & RISCV_HWPROBE_BASE_BEHAVIOR_IMA) continue; - ksft_exit_fail_msg("Unexpected pair: (%ld, %ld)\n", pairs[i].key, pairs[i].value); + ksft_exit_fail_msg("Unexpected pair: (%lld, %llu)\n", pairs[i].key, pairs[i].value); } out = riscv_hwprobe(pairs, 8, 0, 0, 0);