| Message ID | 20231213152350.431591-19-dhowells@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | netfs, afs, 9p: Delegate high-level I/O to netfslib | expand |
On Wed, 2023-12-13 at 15:23 +0000, David Howells wrote: > Export netfs_put_subrequest() and the netfs_rreq and netfs_sreq > tracepoints. > Erm...why? Are these called directly from module code in a later patch? Some rationale for this would be a nice thing. > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Jeff Layton <jlayton@kernel.org> > cc: linux-cachefs@redhat.com > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/netfs/main.c | 3 +++ > fs/netfs/objects.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/fs/netfs/main.c b/fs/netfs/main.c > index 97ce1436615b..404e68e339bf 100644 > --- a/fs/netfs/main.c > +++ b/fs/netfs/main.c > @@ -17,6 +17,9 @@ MODULE_DESCRIPTION("Network fs support"); > MODULE_AUTHOR("Red Hat, Inc."); > MODULE_LICENSE("GPL"); > > +EXPORT_TRACEPOINT_SYMBOL(netfs_rreq); > +EXPORT_TRACEPOINT_SYMBOL(netfs_sreq); > + > unsigned netfs_debug; > module_param_named(debug, netfs_debug, uint, S_IWUSR | S_IRUGO); > MODULE_PARM_DESC(netfs_debug, "Netfs support debugging mask"); > diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c > index 9f3f33c93317..a7947e82374a 100644 > --- a/fs/netfs/objects.c > +++ b/fs/netfs/objects.c > @@ -178,3 +178,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async, > if (dead) > netfs_free_subrequest(subreq, was_async); > } > +EXPORT_SYMBOL(netfs_put_subrequest); >
Jeff Layton <jlayton@kernel.org> wrote:
> Erm...why? Are these called directly from module code in a later patch?
Yes. I'll expand the commit message.
David
David Howells <dhowells@redhat.com> wrote: > Jeff Layton <jlayton@kernel.org> wrote: > > > Erm...why? Are these called directly from module code in a later patch? > > Yes. I'll expand the commit message. That said, only trace_netfs_sreq() is required. The other two can be dropped. David
diff --git a/fs/netfs/main.c b/fs/netfs/main.c index 97ce1436615b..404e68e339bf 100644 --- a/fs/netfs/main.c +++ b/fs/netfs/main.c @@ -17,6 +17,9 @@ MODULE_DESCRIPTION("Network fs support"); MODULE_AUTHOR("Red Hat, Inc."); MODULE_LICENSE("GPL"); +EXPORT_TRACEPOINT_SYMBOL(netfs_rreq); +EXPORT_TRACEPOINT_SYMBOL(netfs_sreq); + unsigned netfs_debug; module_param_named(debug, netfs_debug, uint, S_IWUSR | S_IRUGO); MODULE_PARM_DESC(netfs_debug, "Netfs support debugging mask"); diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c index 9f3f33c93317..a7947e82374a 100644 --- a/fs/netfs/objects.c +++ b/fs/netfs/objects.c @@ -178,3 +178,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async, if (dead) netfs_free_subrequest(subreq, was_async); } +EXPORT_SYMBOL(netfs_put_subrequest);
Export netfs_put_subrequest() and the netfs_rreq and netfs_sreq tracepoints. Signed-off-by: David Howells <dhowells@redhat.com> cc: Jeff Layton <jlayton@kernel.org> cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/main.c | 3 +++ fs/netfs/objects.c | 1 + 2 files changed, 4 insertions(+)