mbox series

[0/2] xen: have a more generic unaligned.h header (take 2)

Message ID 20231212162702.26360-1-jgross@suse.com (mailing list archive)
Headers show
Series xen: have a more generic unaligned.h header (take 2) | expand

Message

Jürgen Groß Dec. 12, 2023, 4:27 p.m. UTC 
Second try for the generic unaligned.h approach.

This time including a fix for building stubdom with libxenguest,
which is using a cruel hack to reuse the hypervisor's decompressing
code.

Juergen Gross (2):
  xen: make include/xen/unaligned.h usable on all architectures
  xen: remove asm/unaligned.h

 .../guest/xg_dom_decompress_unsafe_zstd.c     |  2 +-
 xen/arch/x86/include/asm/unaligned.h          |  6 ---
 xen/common/lz4/defs.h                         |  2 +-
 xen/common/lzo.c                              |  2 +-
 xen/common/unlzo.c                            |  2 +-
 xen/common/xz/private.h                       |  2 +-
 xen/common/zstd/mem.h                         |  2 +-
 xen/include/xen/unaligned.h                   | 53 +++++++++++--------
 xen/lib/xxhash32.c                            |  2 +-
 xen/lib/xxhash64.c                            |  2 +-
 10 files changed, 38 insertions(+), 37 deletions(-)
 delete mode 100644 xen/arch/x86/include/asm/unaligned.h

Comments

Jürgen Groß Dec. 21, 2023, 9:37 a.m. UTC | #1 
On 12.12.23 17:27, Juergen Gross wrote:
> Second try for the generic unaligned.h approach.
> 
> This time including a fix for building stubdom with libxenguest,
> which is using a cruel hack to reuse the hypervisor's decompressing
> code.
> 
> Juergen Gross (2):
>    xen: make include/xen/unaligned.h usable on all architectures
>    xen: remove asm/unaligned.h
> 
>   .../guest/xg_dom_decompress_unsafe_zstd.c     |  2 +-
>   xen/arch/x86/include/asm/unaligned.h          |  6 ---
>   xen/common/lz4/defs.h                         |  2 +-
>   xen/common/lzo.c                              |  2 +-
>   xen/common/unlzo.c                            |  2 +-
>   xen/common/xz/private.h                       |  2 +-
>   xen/common/zstd/mem.h                         |  2 +-
>   xen/include/xen/unaligned.h                   | 53 +++++++++++--------
>   xen/lib/xxhash32.c                            |  2 +-
>   xen/lib/xxhash64.c                            |  2 +-
>   10 files changed, 38 insertions(+), 37 deletions(-)
>   delete mode 100644 xen/arch/x86/include/asm/unaligned.h
> 

Is anything missing for this series to go in?


Juergen
Andrew Cooper Dec. 21, 2023, 9:38 a.m. UTC | #2 
On 21/12/2023 9:37 am, Juergen Gross wrote:
> On 12.12.23 17:27, Juergen Gross wrote:
>> Second try for the generic unaligned.h approach.
>>
>> This time including a fix for building stubdom with libxenguest,
>> which is using a cruel hack to reuse the hypervisor's decompressing
>> code.
>>
>> Juergen Gross (2):
>>    xen: make include/xen/unaligned.h usable on all architectures
>>    xen: remove asm/unaligned.h
>>
>>   .../guest/xg_dom_decompress_unsafe_zstd.c     |  2 +-
>>   xen/arch/x86/include/asm/unaligned.h          |  6 ---
>>   xen/common/lz4/defs.h                         |  2 +-
>>   xen/common/lzo.c                              |  2 +-
>>   xen/common/unlzo.c                            |  2 +-
>>   xen/common/xz/private.h                       |  2 +-
>>   xen/common/zstd/mem.h                         |  2 +-
>>   xen/include/xen/unaligned.h                   | 53 +++++++++++--------
>>   xen/lib/xxhash32.c                            |  2 +-
>>   xen/lib/xxhash64.c                            |  2 +-
>>   10 files changed, 38 insertions(+), 37 deletions(-)
>>   delete mode 100644 xen/arch/x86/include/asm/unaligned.h
>>
>
> Is anything missing for this series to go in?

Oh - I'd not spotted it.  Lemme throw it through a full Gitlab CI run
just to be sure.

~Andrew