diff mbox series

[04/22] udf: d_splice_alias() will do the right thing on ERR_PTR() inode

Message ID 20231220051828.GC1674809@ZenIV (mailing list archive)
State New, archived
Headers show
Series PATCH 01/22] hostfs: use d_splice_alias() calling conventions to simplify failure exits | expand

Commit Message

Al Viro Dec. 20, 2023, 5:18 a.m. UTC 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/udf/namei.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jan Kara Dec. 21, 2023, 12:19 p.m. UTC | #1 
On Wed 20-12-23 05:18:28, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

I don't expect any conflicts in UDF tree so you can keep these patches in
VFS tree. Feel free to add:

Acked-by: Jan Kara <jack@suse.cz>

								Honza	

> ---
>  fs/udf/namei.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index 3508ac484da3..92f25e540430 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -125,8 +125,6 @@ static struct dentry *udf_lookup(struct inode *dir, struct dentry *dentry,
>  		udf_fiiter_release(&iter);
>  
>  		inode = udf_iget(dir->i_sb, &loc);
> -		if (IS_ERR(inode))
> -			return ERR_CAST(inode);
>  	}
>  
>  	return d_splice_alias(inode, dentry);
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index 3508ac484da3..92f25e540430 100644
--- a/fs/udf/namei.c
+++ b/fs/udf/namei.c
@@ -125,8 +125,6 @@  static struct dentry *udf_lookup(struct inode *dir, struct dentry *dentry,
 		udf_fiiter_release(&iter);
 
 		inode = udf_iget(dir->i_sb, &loc);
-		if (IS_ERR(inode))
-			return ERR_CAST(inode);
 	}
 
 	return d_splice_alias(inode, dentry);