diff mbox series

dt-bindings: firmware: xilinx: Fix versal-fpga node name

Message ID 6779af2f9cc21c912f10cf310388d99b980800b2.1702996281.git.michal.simek@amd.com (mailing list archive)
State New
Headers show
Series dt-bindings: firmware: xilinx: Fix versal-fpga node name | expand

Commit Message

Michal Simek Dec. 19, 2023, 2:31 p.m. UTC
Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
document") using underscore ('_') in node name is not recommended that's
why switch to dash ('-').

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
 Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski Dec. 20, 2023, 7:54 a.m. UTC | #1
On 19/12/2023 15:31, Michal Simek wrote:
> Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> document") using underscore ('_') in node name is not recommended that's
> why switch to dash ('-').
> 
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
>  Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 8e584857ddd4..3d578f98ae2c 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -41,7 +41,7 @@ properties:
>    "#power-domain-cells":
>      const: 1
>  

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Xu Yilun Dec. 21, 2023, 1:47 p.m. UTC | #2
On Wed, Dec 20, 2023 at 08:54:33AM +0100, Krzysztof Kozlowski wrote:
> On 19/12/2023 15:31, Michal Simek wrote:
> > Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> > document") using underscore ('_') in node name is not recommended that's
> > why switch to dash ('-').
> > 
> > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > ---
> > 
> >  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
> >  Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml  | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > index 8e584857ddd4..3d578f98ae2c 100644
> > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> > @@ -41,7 +41,7 @@ properties:
> >    "#power-domain-cells":
> >      const: 1
> >  
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Xu Yilun <yilun.xu@intel.com>

> 
> Best regards,
> Krzysztof
> 
>
Michal Simek Jan. 22, 2024, 1:01 p.m. UTC | #3
On 12/19/23 15:31, Michal Simek wrote:
> Based on commit 83a368a3fc8a ("docs: dt-bindings: add DTS Coding Style
> document") using underscore ('_') in node name is not recommended that's
> why switch to dash ('-').
> 
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
>   .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml        | 4 ++--
>   Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml  | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 8e584857ddd4..3d578f98ae2c 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -41,7 +41,7 @@ properties:
>     "#power-domain-cells":
>       const: 1
>   
> -  versal_fpga:
> +  versal-fpga:
>       $ref: /schemas/fpga/xlnx,versal-fpga.yaml#
>       description: Compatible of the FPGA device.
>       type: object
> @@ -84,7 +84,7 @@ examples:
>         compatible = "xlnx,versal-firmware";
>         method = "smc";
>   
> -      versal_fpga: versal_fpga {
> +      versal_fpga: versal-fpga {
>           compatible = "xlnx,versal-fpga";
>         };
>   
> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> index 26f18834caa3..80833462f620 100644
> --- a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> @@ -26,7 +26,7 @@ additionalProperties: false
>   
>   examples:
>     - |
> -    versal_fpga: versal_fpga {
> +    versal_fpga: versal-fpga {
>            compatible = "xlnx,versal-fpga";
>       };
>   

Applied.
M
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
index 8e584857ddd4..3d578f98ae2c 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
@@ -41,7 +41,7 @@  properties:
   "#power-domain-cells":
     const: 1
 
-  versal_fpga:
+  versal-fpga:
     $ref: /schemas/fpga/xlnx,versal-fpga.yaml#
     description: Compatible of the FPGA device.
     type: object
@@ -84,7 +84,7 @@  examples:
       compatible = "xlnx,versal-firmware";
       method = "smc";
 
-      versal_fpga: versal_fpga {
+      versal_fpga: versal-fpga {
         compatible = "xlnx,versal-fpga";
       };
 
diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
index 26f18834caa3..80833462f620 100644
--- a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
+++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
@@ -26,7 +26,7 @@  additionalProperties: false
 
 examples:
   - |
-    versal_fpga: versal_fpga {
+    versal_fpga: versal-fpga {
          compatible = "xlnx,versal-fpga";
     };