| Message ID | 20231221101346.429-1-shenghao-ding@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/5] ASoC: dt-bindings: remove tas2563 from yaml | expand |
On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: > Remove tas2563 from tas2562, it will be supported in tas2781 to better > support dsp mode. DSP Shouldn't this patch go after the actual change happen? I don't know the answer myself, I would like to hear DT people on this.
On 21/12/2023 11:13, Shenghao Ding wrote: > Remove tas2563 from tas2562, it will be supported in tas2781 to better > support dsp mode. Please provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. For example "supported in tas2781" does not fit hardware part, so you sure must be talking about drivers thus why driver change would affect bindings? Best regards, Krzysztof
On 21/12/2023 16:50, Andy Shevchenko wrote: > On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: >> Remove tas2563 from tas2562, it will be supported in tas2781 to better >> support dsp mode. > > DSP > > Shouldn't this patch go after the actual change happen? I would squash both, so device documentation does not disappear. Best regards, Krzysztof
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Thursday, December 21, 2023 11:51 PM > To: Ding, Shenghao <shenghao-ding@ti.com> > Cc: broonie@kernel.org; conor+dt@kernel.org; > krzysztof.kozlowski@linaro.org; robh+dt@kernel.org; Lu, Kevin <kevin- > lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; devicetree@vger.kernel.org; > lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; > 13916275206@139.com; linux-sound@vger.kernel.org; linux- > kernel@vger.kernel.org; liam.r.girdwood@intel.com; soyer@irl.hu; > tiwai@suse.de; Gupta, Peeyush <peeyush@ti.com>; Navada Kanyana, > Mukund <navada@ti.com> > Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 > from yaml > > On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: > > Remove tas2563 from tas2562, it will be supported in tas2781 to better > > support dsp mode. > > DSP > > Shouldn't this patch go after the actual change happen? > I don't know the answer myself, I would like to hear DT people on this. > tas2781 driver can be reused as tas2563 driver, except for the DSP firmware file, and both DSP firmware files complied with TI SmartAMP DSP spec 3.0. > > -- > With Best Regards, > Andy Shevchenko > >
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, December 22, 2023 1:32 AM > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Ding, Shenghao > <shenghao-ding@ti.com> > Cc: broonie@kernel.org; conor+dt@kernel.org; robh+dt@kernel.org; Lu, > Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; > devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- > louis.bossart@linux.intel.com; 13916275206@139.com; linux- > sound@vger.kernel.org; linux-kernel@vger.kernel.org; > liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush > <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> > Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 > from yaml > > On 21/12/2023 16:50, Andy Shevchenko wrote: > > On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: > >> Remove tas2563 from tas2562, it will be supported in tas2781 to > >> better support dsp mode. > > > > DSP > > > > Shouldn't this patch go after the actual change happen? > > I would squash both, so device documentation does not disappear. I do not fully understand "squash both", do you mean still to keep ti,tas2563 in tas2562.yaml? > > Best regards, > Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, December 22, 2023 1:31 AM > To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org; > conor+dt@kernel.org > Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin > <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; > devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- > louis.bossart@linux.intel.com; 13916275206@139.com; linux- > sound@vger.kernel.org; linux-kernel@vger.kernel.org; > liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush > <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> > Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 > from yaml > > On 21/12/2023 11:13, Shenghao Ding wrote: > > Remove tas2563 from tas2562, it will be supported in tas2781 to better > > support dsp mode. > > Please provide rationale in terms of bindings and hardware, not in terms of > driver. Or at least not only. For example "supported in tas2781" does not fit > hardware part, so you sure must be talking about drivers thus why driver > change would affect bindings? This patch mainly change the binding, not the driver code. Tas2563 is unbound to tas2562 driver, and bound to tas2781 driver. > > > > Best regards, > Krzysztof
On 27/12/2023 08:04, Ding, Shenghao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Friday, December 22, 2023 1:32 AM >> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Ding, Shenghao >> <shenghao-ding@ti.com> >> Cc: broonie@kernel.org; conor+dt@kernel.org; robh+dt@kernel.org; Lu, >> Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; >> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- >> louis.bossart@linux.intel.com; 13916275206@139.com; linux- >> sound@vger.kernel.org; linux-kernel@vger.kernel.org; >> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush >> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> >> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 >> from yaml >> >> On 21/12/2023 16:50, Andy Shevchenko wrote: >>> On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: >>>> Remove tas2563 from tas2562, it will be supported in tas2781 to >>>> better support dsp mode. >>> >>> DSP >>> >>> Shouldn't this patch go after the actual change happen? >> >> I would squash both, so device documentation does not disappear. > I do not fully understand "squash both", do you mean still to keep ti,tas2563 in tas2562.yaml? I meant to squash both binding patches (git help rebase). Best regards, Krzysztof
On 27/12/2023 08:07, Ding, Shenghao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Friday, December 22, 2023 1:31 AM >> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org; >> conor+dt@kernel.org >> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin >> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; >> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- >> louis.bossart@linux.intel.com; 13916275206@139.com; linux- >> sound@vger.kernel.org; linux-kernel@vger.kernel.org; >> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush >> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> >> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 >> from yaml >> >> On 21/12/2023 11:13, Shenghao Ding wrote: >>> Remove tas2563 from tas2562, it will be supported in tas2781 to better >>> support dsp mode. >> >> Please provide rationale in terms of bindings and hardware, not in terms of >> driver. Or at least not only. For example "supported in tas2781" does not fit >> hardware part, so you sure must be talking about drivers thus why driver >> change would affect bindings? > This patch mainly change the binding, not the driver code. Tas2563 is unbound > to tas2562 driver, and bound to tas2781 driver. Then why do you reference driver "tas2781" here? Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, December 27, 2023 6:56 PM > To: Ding, Shenghao <shenghao-ding@ti.com> > Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin > <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; > devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- > louis.bossart@linux.intel.com; 13916275206@139.com; linux- > sound@vger.kernel.org; linux-kernel@vger.kernel.org; > liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush > <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; > broonie@kernel.org; conor+dt@kernel.org > Subject: Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove > tas2563 from yaml > > On 27/12/2023 08:07, Ding, Shenghao wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Friday, December 22, 2023 1:31 AM > >> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org; > >> conor+dt@kernel.org > >> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin > >> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; > >> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; > >> pierre- louis.bossart@linux.intel.com; 13916275206@139.com; linux- > >> sound@vger.kernel.org; linux-kernel@vger.kernel.org; > >> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, > >> Peeyush <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> > >> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove > >> tas2563 from yaml > >> > >> On 21/12/2023 11:13, Shenghao Ding wrote: > >>> Remove tas2563 from tas2562, it will be supported in tas2781 to > >>> better support dsp mode. > >> > >> Please provide rationale in terms of bindings and hardware, not in > >> terms of driver. Or at least not only. For example "supported in > >> tas2781" does not fit hardware part, so you sure must be talking > >> about drivers thus why driver change would affect bindings? > > This patch mainly change the binding, not the driver code. Tas2563 is > > unbound to tas2562 driver, and bound to tas2781 driver. > > Then why do you reference driver "tas2781" here? Both tas2563 and tas2781 are dsp-inside audio amplifier, tas2781 driver is designed for dsp-inside series chips, not only for tas2781. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml index f01c0dde0cf7..d28c102c0ce7 100644 --- a/Documentation/devicetree/bindings/sound/tas2562.yaml +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml @@ -18,7 +18,6 @@ description: | Specifications about the audio amplifier can be found at: https://www.ti.com/lit/gpn/tas2562 - https://www.ti.com/lit/gpn/tas2563 https://www.ti.com/lit/gpn/tas2564 https://www.ti.com/lit/gpn/tas2110 @@ -29,7 +28,6 @@ properties: compatible: enum: - ti,tas2562 - - ti,tas2563 - ti,tas2564 - ti,tas2110
Remove tas2563 from tas2562, it will be supported in tas2781 to better support dsp mode. Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- Change in v2: - remove tas2563, which will be move to tas2781 driver --- Documentation/devicetree/bindings/sound/tas2562.yaml | 2 -- 1 file changed, 2 deletions(-)