[v3,0/6] PolarFire SoC Auto Update Support

Message

Conor Dooley Oct. 20, 2023, 1:18 p.m. UTC

From: Conor Dooley <[e-mail]>

Hey all,

This patchset adds support for the "Auto Update" feature on PolarFire
SoC that allows for writing an FPGA bistream to the SPI flash connected
to the system controller.
On powercycle (or reboot depending on how the firmware implements the
openSBI SRST extension) "Auto Update" will take place, and program the
FPGA with the contents of the SPI flash - provided that that image is
valid and an actual upgrade from that already programmed.

Previously this driver was added to the FPGA subsystem, but as there is
no capability for dynamic reconfiguration due to the device reset
requirement, the FPGA manager framework is not actually used by the
driver. As a result, the FPGA maintainers did not think it belonged in
that directory, and after speaking to Arnd, I have put it in
drivers/firmware/microchip instead. Otherwise, very little has changed
here, compared to the previous submission.

If this is acceptable, I can add this to my eventual SoC drivers pull
request for v6.8.

Cheers,
Conor.

Changes in v3:
- Move the driver to drivers/firmware
- Rename the firmware upload device: s/mpfs_bitstream/mpfs-auto-update/
- Fix the clock parentage for the qspi node added in this series
- https://lore.kernel.org/linux-fpga/ZDlJxrybiWy3Mk4Y@yilunxu-OptiPlex-7050/

Changes in v2:
- per Russ' suggestion, the driver has been switched to using the
  firmware-upload API rather than the fpga one
- as a result of that change, the structure of the driver has changed
  significantly, although most of that is reshuffling existing code
  around
- check if the upgrade is possible in probe and fail if it isn't
- only write the image index if it is not already set
- delete the now unneeded debugfs bits

CC: Arnd Bergmann <[e-mail]>
CC: Conor Dooley <[e-mail]>
CC: Daire McNamara <[e-mail]>
CC: Rob Herring <[e-mail]>
CC: Krzysztof Kozlowski <[e-mail]>
CC: Moritz Fischer <[e-mail]>
CC: Wu Hao <[e-mail]>
CC: Xu Yilun <[e-mail]>
CC: Tom Rix <[e-mail]>
CC: Russ Weight <[e-mail]>
CC: [e-mail]
CC: [e-mail]
CC: [e-mail]
CC: [e-mail]
CC: [e-mail]

Conor Dooley (6):
  dt-bindings: soc: microchip: add a property for system controller
    flash
  soc: microchip: mpfs: enable access to the system controller's flash
  soc: microchip: mpfs: print service status in warning message
  soc: microchip: mpfs: add auto-update subdev to system controller
  firmware: microchip: add PolarFire SoC Auto Update support
  riscv: dts: microchip: add the mpfs' system controller qspi &
    associated flash

 .../microchip,mpfs-sys-controller.yaml        |  10 +
 .../boot/dts/microchip/mpfs-icicle-kit.dts    |  21 +
 arch/riscv/boot/dts/microchip/mpfs.dtsi       |  17 +
 drivers/firmware/Kconfig                      |   1 +
 drivers/firmware/Makefile                     |   1 +
 drivers/firmware/microchip/Kconfig            |  12 +
 drivers/firmware/microchip/Makefile           |   3 +
 drivers/firmware/microchip/mpfs-auto-update.c | 494 ++++++++++++++++++
 drivers/soc/microchip/Kconfig                 |   1 +
 drivers/soc/microchip/mpfs-sys-controller.c   |  33 +-
 include/soc/microchip/mpfs.h                  |   2 +
 11 files changed, 592 insertions(+), 3 deletions(-)
 create mode 100644 drivers/firmware/microchip/Kconfig
 create mode 100644 drivers/firmware/microchip/Makefile
 create mode 100644 drivers/firmware/microchip/mpfs-auto-update.c

Comments

Conor Dooley Dec. 6, 2023, 12:25 p.m. UTC | #1

From: Conor Dooley <[e-mail]>

On Fri, 20 Oct 2023 14:18:38 +0100, Conor Dooley wrote:
> Hey all,
> 
> This patchset adds support for the "Auto Update" feature on PolarFire
> SoC that allows for writing an FPGA bistream to the SPI flash connected
> to the system controller.
> On powercycle (or reboot depending on how the firmware implements the
> openSBI SRST extension) "Auto Update" will take place, and program the
> FPGA with the contents of the SPI flash - provided that that image is
> valid and an actual upgrade from that already programmed.
> 
> [...]

Arnd, I've gone and applied this stuff since things have been dead
since I sent it & will send it to you for the upcoming mw in a few weeks.

[1/6] dt-bindings: soc: microchip: add a property for system controller flash
      https://git.kernel.org/conor/c/98d62e97c39f
[2/6] soc: microchip: mpfs: enable access to the system controller's flash
      https://git.kernel.org/conor/c/742aa6c563d2
[3/6] soc: microchip: mpfs: print service status in warning message
      https://git.kernel.org/conor/c/a8f00589be7b
[4/6] soc: microchip: mpfs: add auto-update subdev to system controller
      https://git.kernel.org/conor/c/fad13b5b73e0
[5/6] firmware: microchip: add PolarFire SoC Auto Update support
      https://git.kernel.org/conor/c/ec5b0f1193ad

Thanks,
Conor.

[e-mail] Dec. 21, 2023, 5:41 p.m. UTC | #2

Hello:

This series was applied to soc/soc.git (for-next)
by Conor Dooley <[e-mail]>:

On Fri, 20 Oct 2023 14:18:38 +0100 you wrote:
> From: Conor Dooley <[e-mail]>
> 
> Hey all,
> 
> This patchset adds support for the "Auto Update" feature on PolarFire
> SoC that allows for writing an FPGA bistream to the SPI flash connected
> to the system controller.
> On powercycle (or reboot depending on how the firmware implements the
> openSBI SRST extension) "Auto Update" will take place, and program the
> FPGA with the contents of the SPI flash - provided that that image is
> valid and an actual upgrade from that already programmed.
> 
> [...]

Here is the summary with links:
  - [v3,1/6] dt-bindings: soc: microchip: add a property for system controller flash
    (no matching commit)
  - [v3,2/6] soc: microchip: mpfs: enable access to the system controller's flash
    (no matching commit)
  - [v3,3/6] soc: microchip: mpfs: print service status in warning message
    (no matching commit)
  - [v3,4/6] soc: microchip: mpfs: add auto-update subdev to system controller
    (no matching commit)
  - [v3,5/6] firmware: microchip: add PolarFire SoC Auto Update support
    (no matching commit)
  - [v3,6/6] riscv: dts: microchip: add the mpfs' system controller qspi & associated flash
    https://git.kernel.org/soc/soc/c/0678df827182

You are awesome, thank you!