| Message ID | 20231222032901.3861649-1-yangyongpeng1@oppo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0145eed6ed3210f98b366e88363553251c41807d |
| Headers | show |
| Series | [f2fs-dev,1/2] f2fs: Constrain the modification range of dir_level in the sysfs | expand |
On 2023/12/22 11:29, Yongpeng Yang wrote: > The {struct f2fs_sb_info}->dir_level can be modified through the sysfs > interface, but its value range is not limited. If the value exceeds > MAX_DIR_HASH_DEPTH and the mount options include "noinline_dentry", > the following error will occur: > [root@fedora ~]# mount -o noinline_dentry /dev/sdb /mnt/sdb/ > [root@fedora ~]# echo 128 > /sys/fs/f2fs/sdb/dir_level > [root@fedora ~]# cd /mnt/sdb/ > [root@fedora sdb]# mkdir test > [root@fedora sdb]# cd test/ > [root@fedora test]# mkdir test > mkdir: cannot create directory 'test': Argument list too long > > Signed-off-by: Yongpeng Yang <yangyongpeng1@oppo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 22 Dec 2023 11:29:00 +0800 you wrote: > The {struct f2fs_sb_info}->dir_level can be modified through the sysfs > interface, but its value range is not limited. If the value exceeds > MAX_DIR_HASH_DEPTH and the mount options include "noinline_dentry", > the following error will occur: > [root@fedora ~]# mount -o noinline_dentry /dev/sdb /mnt/sdb/ > [root@fedora ~]# echo 128 > /sys/fs/f2fs/sdb/dir_level > [root@fedora ~]# cd /mnt/sdb/ > [root@fedora sdb]# mkdir test > [root@fedora sdb]# cd test/ > [root@fedora test]# mkdir test > mkdir: cannot create directory 'test': Argument list too long > > [...] Here is the summary with links: - [f2fs-dev,1/2] f2fs: Constrain the modification range of dir_level in the sysfs https://git.kernel.org/jaegeuk/f2fs/c/0145eed6ed32 - [f2fs-dev,2/2] f2fs: Add error handling for negative returns from do_garbage_collect https://git.kernel.org/jaegeuk/f2fs/c/19ec1d31fa56 You are awesome, thank you!
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 7099ffa57299..8c8424b05fc7 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -741,6 +741,13 @@ static ssize_t __sbi_store(struct f2fs_attr *a, return count; } + if (!strcmp(a->attr.name, "dir_level")) { + if (t > MAX_DIR_HASH_DEPTH) + return -EINVAL; + sbi->dir_level = t; + return count; + } + *ui = (unsigned int)t; return count;
The {struct f2fs_sb_info}->dir_level can be modified through the sysfs interface, but its value range is not limited. If the value exceeds MAX_DIR_HASH_DEPTH and the mount options include "noinline_dentry", the following error will occur: [root@fedora ~]# mount -o noinline_dentry /dev/sdb /mnt/sdb/ [root@fedora ~]# echo 128 > /sys/fs/f2fs/sdb/dir_level [root@fedora ~]# cd /mnt/sdb/ [root@fedora sdb]# mkdir test [root@fedora sdb]# cd test/ [root@fedora test]# mkdir test mkdir: cannot create directory 'test': Argument list too long Signed-off-by: Yongpeng Yang <yangyongpeng1@oppo.com> --- fs/f2fs/sysfs.c | 7 +++++++ 1 file changed, 7 insertions(+)