[0/2] dmaengine: xilinx: xdma: Fix two clang warnings

Message

Nathan Chancellor Dec. 22, 2023, 6:06 p.m. UTC

Hi all,

This series fixes two clang warnings that I see after
commit 2f8f90cd2f8d ("dmaengine: xilinx: xdma: Implement interleaved DMA
transfers"). They have just been build tested but I think the logic is
sound, please double check though.

---
Nathan Chancellor (2):
      dmaengine: xilinx: xdma: Fix operator precedence in xdma_prep_interleaved_dma()
      dmaengine: xilinx: xdma: Fix initialization location of desc in xdma_channel_isr()

 drivers/dma/xilinx/xdma.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 3d0b2176e04261ab4ac095ff2a17db077fc1e46d
change-id: 20231222-dma-xilinx-xdma-clang-fixes-b9c2c3f5d0f3

Best regards,

Comments

Jan Kuliga Dec. 22, 2023, 10:43 p.m. UTC | #1

Hi all,

On 22.12.2023 19:06, Nathan Chancellor wrote:
> Hi all,
> 
> This series fixes two clang warnings that I see after
> commit 2f8f90cd2f8d ("dmaengine: xilinx: xdma: Implement interleaved DMA
> transfers"). They have just been build tested but I think the logic is
> sound, please double check though.
> 
> ---
> Nathan Chancellor (2):
>       dmaengine: xilinx: xdma: Fix operator precedence in xdma_prep_interleaved_dma()
>       dmaengine: xilinx: xdma: Fix initialization location of desc in xdma_channel_isr()
> 
>  drivers/dma/xilinx/xdma.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> ---
> base-commit: 3d0b2176e04261ab4ac095ff2a17db077fc1e46d
> change-id: 20231222-dma-xilinx-xdma-clang-fixes-b9c2c3f5d0f3
> 
> Best regards,

Thanks for fixing my broken patches Nathan. Next time I submit any patch, I have to pay more attention to use proper compiler flags for sure (I didn't use those flags so I didn't get any warnings/errors). The logic is okay.

Thanks,
Jan

Vinod Koul Jan. 19, 2024, 12:50 p.m. UTC | #2

On Fri, 22 Dec 2023 11:06:43 -0700, Nathan Chancellor wrote:
> This series fixes two clang warnings that I see after
> commit 2f8f90cd2f8d ("dmaengine: xilinx: xdma: Implement interleaved DMA
> transfers"). They have just been build tested but I think the logic is
> sound, please double check though.
> 

Applied, thanks!

[1/2] dmaengine: xilinx: xdma: Fix operator precedence in xdma_prep_interleaved_dma()
      commit: fe0d495e759cee0dbfff4348b5791f21b6f56655
[2/2] dmaengine: xilinx: xdma: Fix initialization location of desc in xdma_channel_isr()
      commit: 620a7e4c1f03a84e10c8c3fa0ae1aab03ef84294

Best regards,