| Message ID | 20231220-as7331-v1-0-745b73c27703@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: light: add support for AMS AS7331 | expand |
Am Samstag, 23. Dezember 2023, 11:46:12 CET schrieb Javier Carrasco: > The AMS AS7331 UV light sensor measures three ultraviolet bands (UVA, > UVB and UVC, also known as deep UV or DUV) as well as temperature. > > This device is practically identical to the AMS AS73211 XYZ True Color > sensor that is already supported by the iio subsystem, except for the > photodiodes used to aquire the desired light wavelengths. > > In order to reuse code and reduce maintenance load, this series extends > the AS73211 driver to support the AS7331 as well. > > Note that the UVA and UVB light modifiers have not been merged into the > mainline kernel yet, but they are already available in Greg's char-misc > git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > in the char-misc-next branch. > > The original device AS73211 supported by the driver could only be tested > briefly due to the lack of hardware. Instead, the i2c-stub module has > been used to make sure that the driver registers the iio device properly > and the attributes exported to sysfs are correct. Some basic register > assignments reported the expected intensity scales and in principle > nothing else should have been affected by the modifications in the code. I still use the original AS73211, so I can offer testing with it. I am currently away, I'll do the tests on 2023-12-30 and report the result then. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > Javier Carrasco (2): > dt-bindings: iio: light: as73211: add support for as7331 > io: light: as73211: add support for as7331 > > .../devicetree/bindings/iio/light/ams,as73211.yaml | 7 +- > drivers/iio/light/Kconfig | 5 +- > drivers/iio/light/as73211.c | 146 > +++++++++++++++++---- 3 files changed, 127 insertions(+), 31 deletions(-) > --- > base-commit: e9215fcca2561b208c78359110ee4009b454f761 > change-id: 20231220-as7331-88a25ceeb66d > > Best regards,
Hi Christian, On 23.12.23 13:18, Christian Eggers wrote:> I still use the original AS73211, so I can offer testing with it. I am > currently away, I'll do the tests on 2023-12-30 and report the result > then. > That would be great, thanks for your offer. In principle my modifications should be transparent to the AS73211 and only the code to retrieve the scales has suffered significant modifications, which I could test with i2c tools. But none of my tests can compare to yours with real hardware, so I am looking forward to hearing from you again. Hopefully to hear that I did not cause any regression :) Best regards, Javier Carrasco
The AMS AS7331 UV light sensor measures three ultraviolet bands (UVA, UVB and UVC, also known as deep UV or DUV) as well as temperature. This device is practically identical to the AMS AS73211 XYZ True Color sensor that is already supported by the iio subsystem, except for the photodiodes used to aquire the desired light wavelengths. In order to reuse code and reduce maintenance load, this series extends the AS73211 driver to support the AS7331 as well. Note that the UVA and UVB light modifiers have not been merged into the mainline kernel yet, but they are already available in Greg's char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The original device AS73211 supported by the driver could only be tested briefly due to the lack of hardware. Instead, the i2c-stub module has been used to make sure that the driver registers the iio device properly and the attributes exported to sysfs are correct. Some basic register assignments reported the expected intensity scales and in principle nothing else should have been affected by the modifications in the code. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- Javier Carrasco (2): dt-bindings: iio: light: as73211: add support for as7331 io: light: as73211: add support for as7331 .../devicetree/bindings/iio/light/ams,as73211.yaml | 7 +- drivers/iio/light/Kconfig | 5 +- drivers/iio/light/as73211.c | 146 +++++++++++++++++---- 3 files changed, 127 insertions(+), 31 deletions(-) --- base-commit: e9215fcca2561b208c78359110ee4009b454f761 change-id: 20231220-as7331-88a25ceeb66d Best regards,