| Message ID | 20231224143500.10940-4-petre.rodan@subdimension.ro (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | changes to mprls0025pa | expand |
On 24/12/2023 15:34, Petre Rodan wrote: > Add spi based example. > > Add spi-max-frequency property required by chip specifications. > > Add additional maintainer. > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > --- > .../iio/pressure/honeywell,mprls0025pa.yaml | 26 +++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > index e4021306d187..430496b047c7 100644 > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > @@ -8,12 +8,12 @@ title: Honeywell mprls0025pa pressure sensor > > maintainers: > - Andreas Klinger <ak@it-klinger.de> > + - Petre Rodan <petre.rodan@subdimension.ro> > > description: | > Honeywell pressure sensor of model mprls0025pa. > > - This sensor has an I2C and SPI interface. Only the I2C interface is > - implemented. > + This sensor has an I2C and SPI interface. Both are supported. Instead drop that sentence. Current driver support should not matter for the bindings. > > There are many models with different pressure ranges available. The vendor > calls them "mpr series". All of them have the identical programming model and > @@ -88,6 +88,9 @@ properties: > Maximum pressure value the sensor can measure in pascal. > To be specified only if honeywell,pressure-triplet is not set. > > + spi-max-frequency: > + maximum: 800000 So you miss allOf: with $ref to spi props. Best regards, Krzysztof
hello, On Mon, Dec 25, 2023 at 01:59:43PM +0100, Krzysztof Kozlowski wrote: > On 24/12/2023 15:34, Petre Rodan wrote: > > Add spi based example. > > There are many models with different pressure ranges available. The vendor > > calls them "mpr series". All of them have the identical programming model and > > @@ -88,6 +88,9 @@ properties: > > Maximum pressure value the sensor can measure in pascal. > > To be specified only if honeywell,pressure-triplet is not set. > > > > + spi-max-frequency: > > + maximum: 800000 > > So you miss allOf: with $ref to spi props. for simplicity's sake and for compatibility with the i2c devices already in use, this driver does not have distinct 'compatible' properties for the i2c and spi implementation. this is why I just defined spi-max-frequency, used it in the spi example, but not required it. just like in hsc030pa.yaml . without a differentiation in the 'compatible' string I don't see how your request can be implemented. cheers, peter
On 25/12/2023 16:13, Petre Rodan wrote: > > hello, > > On Mon, Dec 25, 2023 at 01:59:43PM +0100, Krzysztof Kozlowski wrote: >> On 24/12/2023 15:34, Petre Rodan wrote: >>> Add spi based example. >>> There are many models with different pressure ranges available. The vendor >>> calls them "mpr series". All of them have the identical programming model and >>> @@ -88,6 +88,9 @@ properties: >>> Maximum pressure value the sensor can measure in pascal. >>> To be specified only if honeywell,pressure-triplet is not set. >>> >>> + spi-max-frequency: >>> + maximum: 800000 >> >> So you miss allOf: with $ref to spi props. > > for simplicity's sake and for compatibility with the i2c devices already in use, > this driver does not have distinct 'compatible' properties for the i2c and spi > implementation. > this is why I just defined spi-max-frequency, used it in the spi example, but > not required it. just like in hsc030pa.yaml . > > without a differentiation in the 'compatible' string I don't see how your request > can be implemented. You cannot have different compatibles. I did not propose it. I wrote nothing about compatible. I wrote about missing $ref in top-level for spi-peripheral-props. Where do you see anything about compatible? Best regards, Krzysztof
On Mon, Dec 25, 2023 at 07:56:24PM +0100, Krzysztof Kozlowski wrote: > On 25/12/2023 16:13, Petre Rodan wrote: > >>> @@ -88,6 +88,9 @@ properties: > >>> Maximum pressure value the sensor can measure in pascal. > >>> To be specified only if honeywell,pressure-triplet is not set. > >>> > >>> + spi-max-frequency: > >>> + maximum: 800000 > >> > >> So you miss allOf: with $ref to spi props. > > > > for simplicity's sake and for compatibility with the i2c devices already in use, > > this driver does not have distinct 'compatible' properties for the i2c and spi > > implementation. > > this is why I just defined spi-max-frequency, used it in the spi example, but > > not required it. just like in hsc030pa.yaml . > > > > without a differentiation in the 'compatible' string I don't see how your request > > can be implemented. > > You cannot have different compatibles. I did not propose it. I wrote > nothing about compatible. I wrote about missing $ref in top-level for > spi-peripheral-props. Where do you see anything about compatible? sorry, for one hot second I thought you want that property to be conditionally defined, like allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml - if: properties: compatible: contains: const: honeywell,foo-spi then: properties: spi-max-frequency: maximum: 800000 required: - spi-max-frequency but I guess you only want the first two lines from here. happy holidays, peter
On 25/12/2023 21:29, Petre Rodan wrote: >>> without a differentiation in the 'compatible' string I don't see how your request >>> can be implemented. >> >> You cannot have different compatibles. I did not propose it. I wrote >> nothing about compatible. I wrote about missing $ref in top-level for >> spi-peripheral-props. Where do you see anything about compatible? > > sorry, for one hot second I thought you want that property to be conditionally > defined, like > > allOf: > - $ref: /schemas/spi/spi-peripheral-props.yaml > Yes, this one. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml index e4021306d187..430496b047c7 100644 --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml @@ -8,12 +8,12 @@ title: Honeywell mprls0025pa pressure sensor maintainers: - Andreas Klinger <ak@it-klinger.de> + - Petre Rodan <petre.rodan@subdimension.ro> description: | Honeywell pressure sensor of model mprls0025pa. - This sensor has an I2C and SPI interface. Only the I2C interface is - implemented. + This sensor has an I2C and SPI interface. Both are supported. There are many models with different pressure ranges available. The vendor calls them "mpr series". All of them have the identical programming model and @@ -88,6 +88,9 @@ properties: Maximum pressure value the sensor can measure in pascal. To be specified only if honeywell,pressure-triplet is not set. + spi-max-frequency: + maximum: 800000 + vdd-supply: description: provide VDD power to the sensor. @@ -135,3 +138,22 @@ examples: vdd-supply = <&vcc_3v3>; }; }; + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + pressure@0 { + compatible = "honeywell,mprls0025pa"; + reg = <0>; + spi-max-frequency = <800000>; + reset-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + interrupt-parent = <&gpio0>; + interrupts = <30 IRQ_TYPE_EDGE_RISING>; + + honeywell,pressure-triplet = "0015PA"; + honeywell,transfer-function = <1>; + vdd-supply = <&vcc_3v3>; + }; + }; +...