| Message ID | 20231225053932.1138-2-shenghao-ding@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml | expand |
On Mon, Dec 25, 2023 at 01:39:28PM +0800, Shenghao Ding wrote: > Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only > work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode > for tas2563, it has been moved to tas2781 driver. As to the hardware part, > such as register setting and DSP firmware, all these are stored in the > binary firmware. What tas2781 drivder dooes is to parse the firmware and > download them to the tas2781 or tas2563, then power on tas2781 or tas2563. > So, tas2781 driver can be resued as tas2563 driver。 Only attention will > be paid to downloading corresponding firmware. I dunno if you got my emails, but my comments were completely ignored. You can't do this patch as after it the current users may have a regression.
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 962c2cdfa017..54561ae598b8 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -59,7 +59,6 @@ struct tas2562_data { enum tas256x_model { TAS2562, - TAS2563, TAS2564, TAS2110, }; @@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562) static const struct i2c_device_id tas2562_id[] = { { "tas2562", TAS2562 }, - { "tas2563", TAS2563 }, { "tas2564", TAS2564 }, { "tas2110", TAS2110 }, { } @@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client) #ifdef CONFIG_OF static const struct of_device_id tas2562_of_match[] = { { .compatible = "ti,tas2562", }, - { .compatible = "ti,tas2563", }, { .compatible = "ti,tas2564", }, { .compatible = "ti,tas2110", }, { },
Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder dooes is to parse the firmware and download them to the tas2781 or tas2563, then power on tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。 Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- Change in v3: - Move tas2563 from tas2562 driver to tas2781 driver - Add more comments on why move tas2563 to tas2781 driver - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. --- sound/soc/codecs/tas2562.c | 3 --- 1 file changed, 3 deletions(-)