| Message ID | 20231223191902.22857-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b09c2b8f849079220a9a9ddf961582f00bdc2c4 |
| Headers | show |
| Series | pinctrl: samsung: constify iomem pointers | expand |
On Sat, Dec 23, 2023 at 1:19 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Constify few pointers to iomem, where the destination memory is not > modified, for code safety and readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/pinctrl/samsung/pinctrl-exynos.c | 4 ++-- > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c > index d3d4b5d036c8..871c1eb46ddf 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > @@ -693,7 +693,7 @@ static void exynos_pinctrl_suspend_bank( > struct samsung_pin_bank *bank) > { > struct exynos_eint_gpio_save *save = bank->soc_priv; > - void __iomem *regs = bank->eint_base; > + const void __iomem *regs = bank->eint_base; > > save->eint_con = readl(regs + EXYNOS_GPIO_ECON_OFFSET > + bank->eint_offset); > @@ -714,7 +714,7 @@ static void exynosauto_pinctrl_suspend_bank(struct samsung_pinctrl_drv_data *drv > struct samsung_pin_bank *bank) > { > struct exynos_eint_gpio_save *save = bank->soc_priv; > - void __iomem *regs = bank->eint_base; > + const void __iomem *regs = bank->eint_base; > > save->eint_con = readl(regs + bank->pctl_offset + bank->eint_con_offset); > save->eint_mask = readl(regs + bank->pctl_offset + bank->eint_mask_offset); > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index dbf38767f15f..ed07e23e0912 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -565,7 +565,7 @@ static void samsung_gpio_set(struct gpio_chip *gc, unsigned offset, int value) > /* gpiolib gpio_get callback function */ > static int samsung_gpio_get(struct gpio_chip *gc, unsigned offset) > { > - void __iomem *reg; > + const void __iomem *reg; > u32 data; > struct samsung_pin_bank *bank = gpiochip_get_data(gc); > const struct samsung_pin_bank_type *type = bank->type; > @@ -1204,7 +1204,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev) > > for (i = 0; i < drvdata->nr_banks; i++) { > struct samsung_pin_bank *bank = &drvdata->pin_banks[i]; > - void __iomem *reg = bank->pctl_base + bank->pctl_offset; > + const void __iomem *reg = bank->pctl_base + bank->pctl_offset; > const u8 *offs = bank->type->reg_offset; > const u8 *widths = bank->type->fld_width; > enum pincfg_type type; > -- > 2.34.1 > >
On Sat, Dec 23, 2023 at 8:19 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Constify few pointers to iomem, where the destination memory is not > modified, for code safety and readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Is this something I should just apply directly at this point? Yours, Linus Walleij
On 28/12/2023 01:23, Linus Walleij wrote: > On Sat, Dec 23, 2023 at 8:19 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> Constify few pointers to iomem, where the destination memory is not >> modified, for code safety and readability. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Is this something I should just apply directly at this point? Yes, please take it. Best regards, Krzysztof
On Sat, Dec 23, 2023 at 8:19 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Constify few pointers to iomem, where the destination memory is not > modified, for code safety and readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index d3d4b5d036c8..871c1eb46ddf 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -693,7 +693,7 @@ static void exynos_pinctrl_suspend_bank( struct samsung_pin_bank *bank) { struct exynos_eint_gpio_save *save = bank->soc_priv; - void __iomem *regs = bank->eint_base; + const void __iomem *regs = bank->eint_base; save->eint_con = readl(regs + EXYNOS_GPIO_ECON_OFFSET + bank->eint_offset); @@ -714,7 +714,7 @@ static void exynosauto_pinctrl_suspend_bank(struct samsung_pinctrl_drv_data *drv struct samsung_pin_bank *bank) { struct exynos_eint_gpio_save *save = bank->soc_priv; - void __iomem *regs = bank->eint_base; + const void __iomem *regs = bank->eint_base; save->eint_con = readl(regs + bank->pctl_offset + bank->eint_con_offset); save->eint_mask = readl(regs + bank->pctl_offset + bank->eint_mask_offset); diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index dbf38767f15f..ed07e23e0912 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -565,7 +565,7 @@ static void samsung_gpio_set(struct gpio_chip *gc, unsigned offset, int value) /* gpiolib gpio_get callback function */ static int samsung_gpio_get(struct gpio_chip *gc, unsigned offset) { - void __iomem *reg; + const void __iomem *reg; u32 data; struct samsung_pin_bank *bank = gpiochip_get_data(gc); const struct samsung_pin_bank_type *type = bank->type; @@ -1204,7 +1204,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev) for (i = 0; i < drvdata->nr_banks; i++) { struct samsung_pin_bank *bank = &drvdata->pin_banks[i]; - void __iomem *reg = bank->pctl_base + bank->pctl_offset; + const void __iomem *reg = bank->pctl_base + bank->pctl_offset; const u8 *offs = bank->type->reg_offset; const u8 *widths = bank->type->fld_width; enum pincfg_type type;
Constify few pointers to iomem, where the destination memory is not modified, for code safety and readability. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 ++-- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)