[00/23] ALSA: scarlett2: Refactor in preparation for gen4

Message

Geoffrey D. Bennett Dec. 24, 2023, 7:18 p.m. UTC

Hi Takashi,

This series is preparation for adding support for the Focusrite
Scarlett 4th Gen devices. It applies on top of the previous series
https://lore.kernel.org/linux-sound/[e-mail]/
"ALSA: scarlett2: Firmware Upgrade and Error Handling Improvements".

There should be no notable functional changes in this series, just
refactoring/restructuring/renaming/reformatting.

Regards,
Geoffrey.

Geoffrey D. Bennett (23):
  ALSA: scarlett2: Simplify enums by removing explicit values
  ALSA: scarlett2: Infer has_msd_mode from config items
  ALSA: scarlett2: Infer standalone switch from config items
  ALSA: scarlett2: Check for phantom persistence config item
  ALSA: scarlett2: Check presence of mixer using mux_assignment
  ALSA: scarlett2: Add config set struct
  ALSA: scarlett2: Remove scarlett2_config_sets array
  ALSA: scarlett2: Add check for config_item presence
  ALSA: scarlett2: Refactor scarlett2_usb_set_config()
  ALSA: scarlett2: Refactor scarlett2_config_save()
  ALSA: scarlett2: Formatting fixes
  ALSA: scarlett2: Parameterise notifications
  ALSA: scarlett2: Change num_mux_* from int to u8
  ALSA: scarlett2: Refactor common port_count lookups
  ALSA: scarlett2: Remove struct scarlett2_usb_volume_status
  ALSA: scarlett2: Split dim_mute_update from vol_updated
  ALSA: scarlett2: Remove line_out_hw_vol device info entry
  ALSA: scarlett2: Allow for interfaces without per-channel volume
  ALSA: scarlett2: Add scarlett2_mixer_value_to_db()
  ALSA: scarlett2: Add #define for SCARLETT2_MIX_MAX
  ALSA: scarlett2: Rename db_scale_scarlett2_gain to volume
  ALSA: scarlett2: Split input_other into level/pad/air/phantom
  ALSA: scarlett2: Split direct_monitor out from monitor_other

 sound/usb/mixer_scarlett2.c | 1536 ++++++++++++++++++++---------------
 1 file changed, 879 insertions(+), 657 deletions(-)

Comments

Takashi Iwai Dec. 29, 2023, 3:06 p.m. UTC | #1

On Sun, 24 Dec 2023 20:18:35 +0100,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> This series is preparation for adding support for the Focusrite
> Scarlett 4th Gen devices. It applies on top of the previous series
> https://lore.kernel.org/linux-sound/[e-mail]/
> "ALSA: scarlett2: Firmware Upgrade and Error Handling Improvements".
> 
> There should be no notable functional changes in this series, just
> refactoring/restructuring/renaming/reformatting.
> 
> Regards,
> Geoffrey.
> 
> Geoffrey D. Bennett (23):
>   ALSA: scarlett2: Simplify enums by removing explicit values
>   ALSA: scarlett2: Infer has_msd_mode from config items
>   ALSA: scarlett2: Infer standalone switch from config items
>   ALSA: scarlett2: Check for phantom persistence config item
>   ALSA: scarlett2: Check presence of mixer using mux_assignment
>   ALSA: scarlett2: Add config set struct
>   ALSA: scarlett2: Remove scarlett2_config_sets array
>   ALSA: scarlett2: Add check for config_item presence
>   ALSA: scarlett2: Refactor scarlett2_usb_set_config()
>   ALSA: scarlett2: Refactor scarlett2_config_save()
>   ALSA: scarlett2: Formatting fixes
>   ALSA: scarlett2: Parameterise notifications
>   ALSA: scarlett2: Change num_mux_* from int to u8
>   ALSA: scarlett2: Refactor common port_count lookups
>   ALSA: scarlett2: Remove struct scarlett2_usb_volume_status
>   ALSA: scarlett2: Split dim_mute_update from vol_updated
>   ALSA: scarlett2: Remove line_out_hw_vol device info entry
>   ALSA: scarlett2: Allow for interfaces without per-channel volume
>   ALSA: scarlett2: Add scarlett2_mixer_value_to_db()
>   ALSA: scarlett2: Add #define for SCARLETT2_MIX_MAX
>   ALSA: scarlett2: Rename db_scale_scarlett2_gain to volume
>   ALSA: scarlett2: Split input_other into level/pad/air/phantom
>   ALSA: scarlett2: Split direct_monitor out from monitor_other

Now applied all patches to topic/scarlett2 branch, which is merged to
for-next branch.

There was a wrong sha id reference in some fixes tag and I corrected
manually.


thanks,

Takashi