| Message ID | 20240102024916.19093-1-andy.chi@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 18a434f32fa61b3fda8ddcd9a63d5274569c6a41 |
| Headers | show |
| Series | ALSA: hda/realtek: fix mute/micmute LEDs for a HP ZBook | expand |
On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote: > There is a HP ZBook which using ALC236 codec and need the > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED > and micmute LED work. Hi Andy, I know Takashi in the name of smooth operation usually takes this kind of simple patch, quickly, since it's a simple bugfix, unless there are any objections, so I must raise one. Which HP ZBook? Which model? Is this a still unreleased model Canonical has had access under a NDA for example? Or perhaps there is some other reason why you cannot name the model yet? Either way, there is a need to publicly know the reason for the missing model information. > > Signed-off-by: Andy Chi <andy.chi@canonical.com> > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 7e9d8c1cedfc..1c8d5b58eb64 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), Same questioning as above. "HP" is IMHO unacceptable without a clear reason for the missing model information. Thanks, Geraldo Nascimento > SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), > -- > 2.34.1 > >
Hi Geraldo, Yes, this model is not yet publicly available, so I can't type the full name on this patch. (change to text plain mode to send out again.) Kr, Andy On Tue, Jan 2, 2024 at 1:47 PM Andy Chi <andy.chi@canonical.com> wrote: > > Hi Geraldo, > Yes, this model is not yet publicly available, so I can't type the full name on this patch. > > Kr, > Andy > > On Tue, Jan 2, 2024 at 12:25 PM Geraldo Nascimento <geraldogabriel@gmail.com> wrote: >> >> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote: >> > There is a HP ZBook which using ALC236 codec and need the >> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED >> > and micmute LED work. >> >> Hi Andy, >> >> I know Takashi in the name of smooth operation usually takes this kind >> of simple patch, quickly, since it's a simple bugfix, unless there are >> any objections, so I must raise one. >> >> Which HP ZBook? Which model? >> >> Is this a still unreleased model Canonical has had access under a NDA >> for example? Or perhaps there is some other reason why you cannot name >> the model yet? >> >> Either way, there is a need to publicly know the reason for the missing >> model information. >> >> > >> > Signed-off-by: Andy Chi <andy.chi@canonical.com> >> > --- >> > sound/pci/hda/patch_realtek.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c >> > index 7e9d8c1cedfc..1c8d5b58eb64 100644 >> > --- a/sound/pci/hda/patch_realtek.c >> > +++ b/sound/pci/hda/patch_realtek.c >> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { >> > SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), >> > SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), >> > SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), >> > + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), >> >> Same questioning as above. "HP" is IMHO unacceptable without a clear >> reason for the missing model information. >> >> Thanks, >> Geraldo Nascimento >> >> > SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), >> > SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), >> > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), >> > -- >> > 2.34.1 >> > >> >
On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote: > Hi Geraldo, > Yes, this model is not yet publicly available, so I can't type the > full name on this patch. > > (change to text plain mode to send out again.) Hi Andy, please be kind and next time refrain from top-posting, as it reverses the attention order for those reading the discussion for posterity. I think it is reasonable to mention it explicitly as an upcoming product in order not to cause any confusion and to make sure there's another janitorial patch later on filling in the model details. It's best to leave Takashi now to attend to your patch, and I congratulate both you as well as Canonical and HP for the effort towards bettering Linux. Thanks for addressing this quickly. Geraldo Nascimento > > Kr, > Andy > > > On Tue, Jan 2, 2024 at 1:47 PM Andy Chi <andy.chi@canonical.com> wrote: > > > > Hi Geraldo, > > Yes, this model is not yet publicly available, so I can't type the full name on this patch. > > > > Kr, > > Andy > > > > On Tue, Jan 2, 2024 at 12:25 PM Geraldo Nascimento <geraldogabriel@gmail.com> wrote: > >> > >> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote: > >> > There is a HP ZBook which using ALC236 codec and need the > >> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED > >> > and micmute LED work. > >> > >> Hi Andy, > >> > >> I know Takashi in the name of smooth operation usually takes this kind > >> of simple patch, quickly, since it's a simple bugfix, unless there are > >> any objections, so I must raise one. > >> > >> Which HP ZBook? Which model? > >> > >> Is this a still unreleased model Canonical has had access under a NDA > >> for example? Or perhaps there is some other reason why you cannot name > >> the model yet? > >> > >> Either way, there is a need to publicly know the reason for the missing > >> model information. > >> > >> > > >> > Signed-off-by: Andy Chi <andy.chi@canonical.com> > >> > --- > >> > sound/pci/hda/patch_realtek.c | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > >> > index 7e9d8c1cedfc..1c8d5b58eb64 100644 > >> > --- a/sound/pci/hda/patch_realtek.c > >> > +++ b/sound/pci/hda/patch_realtek.c > >> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > >> > SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > >> > SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > >> > SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > >> > + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > >> > >> Same questioning as above. "HP" is IMHO unacceptable without a clear > >> reason for the missing model information. > >> > >> Thanks, > >> Geraldo Nascimento > >> > >> > SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > >> > SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > >> > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), > >> > -- > >> > 2.34.1 > >> > > >> >
On Tue, Jan 2, 2024 at 2:42 PM Geraldo Nascimento <geraldogabriel@gmail.com> wrote: > > On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote: > > Hi Geraldo, > > Yes, this model is not yet publicly available, so I can't type the > > full name on this patch. > > > > (change to text plain mode to send out again.) > Hi Geraldo, > Hi Andy, please be kind and next time refrain from top-posting, > as it reverses the attention order for those reading the > discussion for posterity. > Got it, appreciate your feedback. > I think it is reasonable to mention it explicitly as an > upcoming product in order not to cause any confusion and > to make sure there's another janitorial patch later on > filling in the model details. > Should I mention it in the commit message? Or is it ok if I put the model name after it's on the market? > It's best to leave Takashi now to attend to your patch, and I > congratulate both you as well as Canonical and HP for the > effort towards bettering Linux. Cheers :) > > Thanks for addressing this quickly. > > Geraldo Nascimento > > > > > Kr, > > Andy > > > > > > On Tue, Jan 2, 2024 at 1:47 PM Andy Chi <andy.chi@canonical.com> wrote: > > > > > > Hi Geraldo, > > > Yes, this model is not yet publicly available, so I can't type the full name on this patch. > > > > > > Kr, > > > Andy > > > > > > On Tue, Jan 2, 2024 at 12:25 PM Geraldo Nascimento <geraldogabriel@gmail.com> wrote: > > >> > > >> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote: > > >> > There is a HP ZBook which using ALC236 codec and need the > > >> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED > > >> > and micmute LED work. > > >> > > >> Hi Andy, > > >> > > >> I know Takashi in the name of smooth operation usually takes this kind > > >> of simple patch, quickly, since it's a simple bugfix, unless there are > > >> any objections, so I must raise one. > > >> > > >> Which HP ZBook? Which model? > > >> > > >> Is this a still unreleased model Canonical has had access under a NDA > > >> for example? Or perhaps there is some other reason why you cannot name > > >> the model yet? > > >> > > >> Either way, there is a need to publicly know the reason for the missing > > >> model information. > > >> > > >> > > > >> > Signed-off-by: Andy Chi <andy.chi@canonical.com> > > >> > --- > > >> > sound/pci/hda/patch_realtek.c | 1 + > > >> > 1 file changed, 1 insertion(+) > > >> > > > >> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > >> > index 7e9d8c1cedfc..1c8d5b58eb64 100644 > > >> > --- a/sound/pci/hda/patch_realtek.c > > >> > +++ b/sound/pci/hda/patch_realtek.c > > >> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > >> > SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > >> > SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > >> > SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > >> > + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > >> > > >> Same questioning as above. "HP" is IMHO unacceptable without a clear > > >> reason for the missing model information. > > >> > > >> Thanks, > > >> Geraldo Nascimento > > >> > > >> > SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > >> > SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > >> > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), > > >> > -- > > >> > 2.34.1 > > >> > > > >> >
On Tue, Jan 02, 2024 at 02:59:56PM +0800, Andy Chi wrote: > On Tue, Jan 2, 2024 at 2:42 PM Geraldo Nascimento > <geraldogabriel@gmail.com> wrote: > > > > On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote: > > > Hi Geraldo, > > > Yes, this model is not yet publicly available, so I can't type the > > > full name on this patch. > > > > > > (change to text plain mode to send out again.) > > > Hi Geraldo, > > Hi Andy, please be kind and next time refrain from top-posting, > > as it reverses the attention order for those reading the > > discussion for posterity. > > > Got it, appreciate your feedback. > > I think it is reasonable to mention it explicitly as an > > upcoming product in order not to cause any confusion and > > to make sure there's another janitorial patch later on > > filling in the model details. > > > Should I mention it in the commit message? Or is it ok if I put the > model name after it's on the market? Andy, in order to clear up any confusion that might arise later on, and to maintain high the quality of both code and git meta-information I think you should explicitly mention both in the commit info and commit message that this is an upcoming product. Also, instead of just "HP" in the commit proper, it should say something like "Upcoming HP ZBook". But that's just my advice, now you need to wait and hear Takashi's advice. We should always strive toward striking a healthy balance between companies' needs and the public nature of the development of the Linux kernel and ALSA. Unfortunately that means some details of upcoming models may end up catching up the attention of the specialized press. I encourage you to look on the bright side and think of it as free PR ;) Best Regards, Geraldo Nascimento > > > It's best to leave Takashi now to attend to your patch, and I > > congratulate both you as well as Canonical and HP for the > > effort towards bettering Linux. > Cheers :) > > > > > Thanks for addressing this quickly. > > > > Geraldo Nascimento > > > > > > > > Kr, > > > Andy > > > > > > > > > On Tue, Jan 2, 2024 at 1:47 PM Andy Chi <andy.chi@canonical.com> wrote: > > > > > > > > Hi Geraldo, > > > > Yes, this model is not yet publicly available, so I can't type the full name on this patch. > > > > > > > > Kr, > > > > Andy > > > > > > > > On Tue, Jan 2, 2024 at 12:25 PM Geraldo Nascimento <geraldogabriel@gmail.com> wrote: > > > >> > > > >> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote: > > > >> > There is a HP ZBook which using ALC236 codec and need the > > > >> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED > > > >> > and micmute LED work. > > > >> > > > >> Hi Andy, > > > >> > > > >> I know Takashi in the name of smooth operation usually takes this kind > > > >> of simple patch, quickly, since it's a simple bugfix, unless there are > > > >> any objections, so I must raise one. > > > >> > > > >> Which HP ZBook? Which model? > > > >> > > > >> Is this a still unreleased model Canonical has had access under a NDA > > > >> for example? Or perhaps there is some other reason why you cannot name > > > >> the model yet? > > > >> > > > >> Either way, there is a need to publicly know the reason for the missing > > > >> model information. > > > >> > > > >> > > > > >> > Signed-off-by: Andy Chi <andy.chi@canonical.com> > > > >> > --- > > > >> > sound/pci/hda/patch_realtek.c | 1 + > > > >> > 1 file changed, 1 insertion(+) > > > >> > > > > >> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > > >> > index 7e9d8c1cedfc..1c8d5b58eb64 100644 > > > >> > --- a/sound/pci/hda/patch_realtek.c > > > >> > +++ b/sound/pci/hda/patch_realtek.c > > > >> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > > >> > SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > > >> > SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > > >> > SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), > > > >> > + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > > >> > > > >> Same questioning as above. "HP" is IMHO unacceptable without a clear > > > >> reason for the missing model information. > > > >> > > > >> Thanks, > > > >> Geraldo Nascimento > > > >> > > > >> > SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > > >> > SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > > > >> > SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), > > > >> > -- > > > >> > 2.34.1 > > > >> > > > > >> >
On Tue, 02 Jan 2024 08:45:07 +0100, Geraldo Nascimento wrote: > > On Tue, Jan 02, 2024 at 02:59:56PM +0800, Andy Chi wrote: > > On Tue, Jan 2, 2024 at 2:42 PM Geraldo Nascimento > > <geraldogabriel@gmail.com> wrote: > > > > > > On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote: > > > > Hi Geraldo, > > > > Yes, this model is not yet publicly available, so I can't type the > > > > full name on this patch. > > > > > > > > (change to text plain mode to send out again.) > > > > > Hi Geraldo, > > > Hi Andy, please be kind and next time refrain from top-posting, > > > as it reverses the attention order for those reading the > > > discussion for posterity. > > > > > Got it, appreciate your feedback. > > > I think it is reasonable to mention it explicitly as an > > > upcoming product in order not to cause any confusion and > > > to make sure there's another janitorial patch later on > > > filling in the model details. > > > > > Should I mention it in the commit message? Or is it ok if I put the > > model name after it's on the market? > > Andy, in order to clear up any confusion that might arise later on, and > to maintain high the quality of both code and git meta-information I think > you should explicitly mention both in the commit info and commit message > that this is an upcoming product. > > Also, instead of just "HP" in the commit proper, it should say something > like "Upcoming HP ZBook". > > But that's just my advice, now you need to wait and hear Takashi's advice. > > We should always strive toward striking a healthy balance between companies' > needs and the public nature of the development of the Linux kernel and ALSA. > Unfortunately that means some details of upcoming models may end up > catching up the attention of the specialized press. > > I encourage you to look on the bright side and think of it as free PR ;) I merged as is now with some comments about the new model. It's fine with the current patch if the entry will be updated later with a proper model name; having the code fix before the name definition would be more important. thanks, Takashi
On Tue, Jan 02, 2024 at 03:57:47PM +0100, Takashi Iwai wrote: > I merged as is now with some comments about the new model. > It's fine with the current patch if the entry will be updated later > with a proper model name; having the code fix before the name > definition would be more important. Thanks Takashi, actually it's a commit from the ideal world. I wish more integrators would work together with Linux companies to launch new products that work smoothly, like we see here. I appreciate you adding the note about it being a new model without a proper name. It's a middle path that doesn't overwork you and Andy, and my concern is still addressed that way. Regards, Geraldo Nascimento > > > thanks, > > Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 7e9d8c1cedfc..1c8d5b58eb64 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
There is a HP ZBook which using ALC236 codec and need the ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED and micmute LED work. Signed-off-by: Andy Chi <andy.chi@canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)