| Message ID | 20240102134833.68646-2-wse@tuxedocomputers.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] i8042: Add forcenorestore quirk to leave controller untouched even on s3 | expand |
Hi, Am 02.01.24 um 14:48 schrieb Werner Sembach: > The old quirk combination sometimes cause a laggy keyboard after boot. With > the new quirk the initial issue of an unresponsive keyboard after s3 resume > is also fixed, but it doesn't have the negative side effect of the > sometimes laggy keyboard. > > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> > Cc: stable@vger.kernel.org Added Hans to the loop. As mentioned in the one on one e-Mails with Hans I wrote a new quirk in [Patch 1/2] and tested it on the device in [Patch 2/2] At least one more device will follow which has negative side effects with the old quirkls, but I currently don't have it at hand for testing. I wonder if devices where the old quirk combination did not cause issue should also be switched to the new quirk, if, after testing, it also fixes the unresponsive keyboard issues? Kind regards, Werner
diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h index 10ec4534e5e14..e631a26394e92 100644 --- a/drivers/input/serio/i8042-acpipnpio.h +++ b/drivers/input/serio/i8042-acpipnpio.h @@ -1142,18 +1142,10 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = { SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) }, { - /* - * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes - * the keyboard very laggy for ~5 seconds after boot and - * sometimes also after resume. - * However both are required for the keyboard to not fail - * completely sometimes after boot or resume. - */ .matches = { DMI_MATCH(DMI_BOARD_NAME, "N150CU"), }, - .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | - SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) + .driver_data = (void *)(SERIO_QUIRK_FORCENORESTORE) }, { .matches = {
The old quirk combination sometimes cause a laggy keyboard after boot. With the new quirk the initial issue of an unresponsive keyboard after s3 resume is also fixed, but it doesn't have the negative side effect of the sometimes laggy keyboard. Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> Cc: stable@vger.kernel.org --- drivers/input/serio/i8042-acpipnpio.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)