dt-bindings: thermal: mediatek,thermal: document AUXADC 32k clock

Commit Message

Rafał Miłecki Jan. 1, 2024, 8:51 p.m. UTC

From: Rafał Miłecki <[e-mail]>

SoCs MT7981 and MT7986 include a newer thermal block (V3) that requires
enabling one more clock called AUXADC 32k. Require it in binding.

Cc: Daniel Golle <[e-mail]>
Cc: Sam Shih <[e-mail]>
Signed-off-by: Rafał Miłecki <[e-mail]>
---
 .../bindings/thermal/mediatek,thermal.yaml    | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski Jan. 4, 2024, 8:04 a.m. UTC | #1

On 01/01/2024 21:51, Rafał Miłecki wrote:
> From: Rafał Miłecki <[e-mail]>
> 
> SoCs MT7981 and MT7986 include a newer thermal block (V3) that requires
> enabling one more clock called AUXADC 32k. Require it in binding.
> 

>  
> +allOf:
> +  - $ref: thermal-sensor.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7981-thermal
> +              - mediatek,mt7986-thermal
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 3
> +
> +        clock-names:
> +          minItems: 3

else:
Is the clock valid for other variants?

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/thermal/mediatek,thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,thermal.yaml
index d96a2e32bd8f..a76be9c47fb5 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/mediatek,thermal.yaml
@@ -15,9 +15,6 @@  description:
   controls a mux in the apmixedsys register space via AHB bus accesses, so a
   phandle to the APMIXEDSYS is also needed.
 
-allOf:
-  - $ref: thermal-sensor.yaml#
-
 properties:
   compatible:
     enum:
@@ -38,14 +35,18 @@  properties:
     maxItems: 1
 
   clocks:
+    minItems: 2
     items:
       - description: Main clock needed for register access
       - description: The AUXADC clock
+      - description: AUXADC 32k clock
 
   clock-names:
+    minItems: 2
     items:
       - const: therm
       - const: auxadc
+      - const: adc_32k
 
   mediatek,auxadc:
     $ref: /schemas/types.yaml#/definitions/phandle
@@ -76,6 +77,23 @@  required:
   - mediatek,auxadc
   - mediatek,apmixedsys
 
+allOf:
+  - $ref: thermal-sensor.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt7981-thermal
+              - mediatek,mt7986-thermal
+    then:
+      properties:
+        clocks:
+          minItems: 3
+
+        clock-names:
+          minItems: 3
+
 unevaluatedProperties: false
 
 examples: