| Message ID | 6498e2dd-7960-daeb-acce-a8d2207f3404@omp.ru (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver | expand |
+ Shimoda-san On Wed, Jan 03, 2024 at 11:56:15PM +0300, Sergey Shtylyov wrote: > I don't know this hardware, I don't have the manuals for it, so I can't > provide a good review. Let's exclude the Ethernet Switch related files. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Hi Sergey, I don't know the back story to this, if there is one. But could I suggest that: 1. The patch also updates the title MAINTAINERS section to cover the remaining two drivers. e.g.: RENESAS ETHERNET DRIVERS -> RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS Or alternatively, create separate sections for each driver. n.b.: This may involve moving sections to maintain alphabetical order by section title 2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found. n.b.: It may still be a holiday period in Japan for the rest of the week. 3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver . > --- > The patch is against the 'main' branch of DaveM's 'net.git' repo... > > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > > Index: net/MAINTAINERS > =================================================================== > --- net.orig/MAINTAINERS > +++ net/MAINTAINERS > @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org > F: Documentation/devicetree/bindings/net/renesas,*.yaml > F: drivers/net/ethernet/renesas/ > F: include/linux/sh_eth.h > +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml > +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* > +X: drivers/net/ethernet/renesas/rswitch.* > > RENESAS IDT821034 ASoC CODEC > M: Herve Codina <herve.codina@bootlin.com>
On Wed, 3 Jan 2024 23:56:15 +0300 Sergey Shtylyov wrote: > I don't know this hardware, I don't have the manuals for it, so I can't > provide a good review. Let's exclude the Ethernet Switch related files. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Index: net/MAINTAINERS > =================================================================== > --- net.orig/MAINTAINERS > +++ net/MAINTAINERS > @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org > F: Documentation/devicetree/bindings/net/renesas,*.yaml > F: drivers/net/ethernet/renesas/ > F: include/linux/sh_eth.h > +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml > +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* > +X: drivers/net/ethernet/renesas/rswitch.* First off, very nice to see a refinement of MAINTAINERS to narrow down the scope and make it more precise. Thanks for doing that. The solution itself is not very idiomatic, however :( IIUC you want to support SuperH and the AVB implementation. It'd be more usual to make the entry cover only the relevant files. And for bonus points perhaps add an entry covering the switch files, mark that entry as Orphan?
Hi, a quick two cents from my side. > First off, very nice to see a refinement of MAINTAINERS to narrow > down the scope and make it more precise. Thanks for doing that. Ack. > IIUC you want to support SuperH and the AVB implementation. > It'd be more usual to make the entry cover only the relevant files. Ack again. > And for bonus points perhaps add an entry covering the switch files, > mark that entry as Orphan? I think Shimoda-san will happily maintain the rswitch driver. He is likely away this week, though. So, my suggestion would be to wait with this discussion another week so he can take part in it? All the best, Wolfram
On 1/4/24 12:37 AM, Jakub Kicinski wrote: [...] >> I don't know this hardware, I don't have the manuals for it, so I can't >> provide a good review. Let's exclude the Ethernet Switch related files. >> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > >> Index: net/MAINTAINERS >> =================================================================== >> --- net.orig/MAINTAINERS >> +++ net/MAINTAINERS >> @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org >> F: Documentation/devicetree/bindings/net/renesas,*.yaml >> F: drivers/net/ethernet/renesas/ >> F: include/linux/sh_eth.h >> +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml >> +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* >> +X: drivers/net/ethernet/renesas/rswitch.* > > First off, very nice to see a refinement of MAINTAINERS to narrow > down the scope and make it more precise. Thanks for doing that. It's long overdue. I've got a lot of the rswitch patches in my inbox which I mostly ignored. Unfortunately, I've been loaded with fixing the Svace (static analyzer) reports for about 2 years now... > The solution itself is not very idiomatic, however :( > IIUC you want to support SuperH and the AVB implementation. > It'd be more usual to make the entry cover only the relevant files. Yeah, figured that out fianally... but still not sure what should I do with Kconfig and Makefile... > And for bonus points perhaps add an entry covering the switch files, > mark that entry as Orphan? Will try to loop in Shimoda-san first -- maybe he'd be brave enough to step in... :-) MBR, Sergey
On 1/4/24 12:28 AM, Simon Horman wrote: [...] >> I don't know this hardware, I don't have the manuals for it, so I can't >> provide a good review. Let's exclude the Ethernet Switch related files. >> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > Hi Sergey, Hi Simon, long time, no see... :-) > I don't know the back story to this, if there is one. Not much of a history: I got a lot of the rswitch patches in my inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work... > But could I suggest that: > > 1. The patch also updates the title MAINTAINERS section to cover the > remaining two drivers. > > e.g.: RENESAS ETHERNET DRIVERS -> > RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS > > Or alternatively, create separate sections for each driver. Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ Makefile though... > n.b.: This may involve moving sections to maintain alphabetical order > by section title > > 2. Reaching out to Shimoda-san (CCed) or other relevant parties > to see if an appropriate maintainer or maintainers for the > Renesas Ethernet Switch driver can be found. > > n.b.: It may still be a holiday period in Japan for the rest of the week. It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > 3. Rephrase the subject and patch description as splitting out maintenance of > the Renesas Ethernet Switch driver . [...] MBR, Sergey
Hello, Thank you for adding CC to me. > From: Sergey Shtylyov, Sent: Friday, January 5, 2024 5:47 AM > > On 1/4/24 12:28 AM, Simon Horman wrote: > [...] > >> I don't know this hardware, I don't have the manuals for it, so I can't > >> provide a good review. Let's exclude the Ethernet Switch related files. > >> > >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > > > Hi Sergey, > > Hi Simon, long time, no see... :-) > > > I don't know the back story to this, if there is one. > > Not much of a history: I got a lot of the rswitch patches in my > inbox and I mostly ignored them... but kept deferring this patch due > to a high load with fixing Svace's reports at work... > > > But could I suggest that: > > > > 1. The patch also updates the title MAINTAINERS section to cover the > > remaining two drivers. > > > > e.g.: RENESAS ETHERNET DRIVERS -> > > RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS > > > > Or alternatively, create separate sections for each driver. > > Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ > Makefile though... How about adding "COMMON PARTS" section? - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > n.b.: This may involve moving sections to maintain alphabetical order > > by section title > > > > 2. Reaching out to Shimoda-san (CCed) or other relevant parties > > to see if an appropriate maintainer or maintainers for the > > Renesas Ethernet Switch driver can be found. I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. So, if my idea above is acceptable, perhaps the maintainers can be: - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda - RENESAS ETHERNET SWITCH DRIVER : Shimoda > > n.b.: It may still be a holiday period in Japan for the rest of the week. > > It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) I'm back from today, but next Monday (8th) is a holiday in Japan :) Best regards, Yoshihiro Shimoda > > 3. Rephrase the subject and patch description as splitting out maintenance of > > the Renesas Ethernet Switch driver . > > [...] > > MBR, Sergey
On Fri, Jan 05, 2024 at 02:42:54AM +0000, Yoshihiro Shimoda wrote: > Hello, > > Thank you for adding CC to me. Likewise, thanks for your response. > > From: Sergey Shtylyov, Sent: Friday, January 5, 2024 5:47 AM > > > > On 1/4/24 12:28 AM, Simon Horman wrote: > > [...] > > >> I don't know this hardware, I don't have the manuals for it, so I can't > > >> provide a good review. Let's exclude the Ethernet Switch related files. > > >> > > >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > > > > > Hi Sergey, > > > > Hi Simon, long time, no see... :-) > > > > > I don't know the back story to this, if there is one. > > > > Not much of a history: I got a lot of the rswitch patches in my > > inbox and I mostly ignored them... but kept deferring this patch due > > to a high load with fixing Svace's reports at work... > > > > > But could I suggest that: > > > > > > 1. The patch also updates the title MAINTAINERS section to cover the > > > remaining two drivers. > > > > > > e.g.: RENESAS ETHERNET DRIVERS -> > > > RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS > > > > > > Or alternatively, create separate sections for each driver. > > > > Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ > > Makefile though... > > How about adding "COMMON PARTS" section? I think that would be fine. > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth I think Sergey prefers two sections for the above. Perhaps: - RENESAS ETHERNET AVB DRIVER - RENESAS SUPERH ETHERNET DRIVER Whoever drafts the patch, please be sure to maintain alphabetical order by section title. > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas > - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > > > n.b.: This may involve moving sections to maintain alphabetical order > > > by section title > > > > > > 2. Reaching out to Shimoda-san (CCed) or other relevant parties > > > to see if an appropriate maintainer or maintainers for the > > > Renesas Ethernet Switch driver can be found. > > I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. > So, if my idea above is acceptable, perhaps the maintainers can be: > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda > - RENESAS ETHERNET SWITCH DRIVER : Shimoda Modulo my comments above, this sounds reasonable to me. > > > n.b.: It may still be a holiday period in Japan for the rest of the week. > > > > It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > > I'm back from today, but next Monday (8th) is a holiday in Japan :) Enjoy. > > Best regards, > Yoshihiro Shimoda > > > > 3. Rephrase the subject and patch description as splitting out maintenance of > > > the Renesas Ethernet Switch driver . > > > > [...] > > > > MBR, Sergey
On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote: [...] >>>> I don't know this hardware, I don't have the manuals for it, so I can't >>>> provide a good review. Let's exclude the Ethernet Switch related files. >>>> >>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> >>> >>> Hi Sergey, >> >> Hi Simon, long time, no see... :-) >> >>> I don't know the back story to this, if there is one. >> >> Not much of a history: I got a lot of the rswitch patches in my >> inbox and I mostly ignored them... but kept deferring this patch due >> to a high load with fixing Svace's reports at work... >> >>> But could I suggest that: >>> >>> 1. The patch also updates the title MAINTAINERS section to cover the >>> remaining two drivers. >>> >>> e.g.: RENESAS ETHERNET DRIVERS -> >>> RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS >>> >>> Or alternatively, create separate sections for each driver. >> >> Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ >> Makefile though... > > How about adding "COMMON PARTS" section? > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas > - RENESAS ETHERNET SWITCH DRIVER : For rswitch No, this seems too much for these poor little couple files. :-) Listing them in each new MAINTAINERS entry should achieve the same goal and seems a biut cleaner... >>> n.b.: This may involve moving sections to maintain alphabetical order >>> by section title >>> >>> 2. Reaching out to Shimoda-san (CCed) or other relevant parties >>> to see if an appropriate maintainer or maintainers for the >>> Renesas Ethernet Switch driver can be found. > > I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. Do you want to be a maintainer or just a reviewer (like me)? > So, if my idea above is acceptable, perhaps the maintainers can be: > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey There will be separate entries for those... > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda I'd like to avoid that... :-) > - RENESAS ETHERNET SWITCH DRIVER : Shimoda >>> n.b.: It may still be a holiday period in Japan for the rest of the week. >> >> It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > > I'm back from today, but next Monday (8th) is a holiday in Japan :) You're back for 1 day? :-) > Best regards, > Yoshihiro Shimoda > >>> 3. Rephrase the subject and patch description as splitting out maintenance of >>> the Renesas Ethernet Switch driver . The question that remains still unaddressed: should I do the MAINTAINERS "directory split" with a single patch? [...] MBR, Sergey
On Fri, Jan 05, 2024 at 01:46:32PM +0300, Sergey Shtylyov wrote: > On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote: > [...] > > >>>> I don't know this hardware, I don't have the manuals for it, so I can't > >>>> provide a good review. Let's exclude the Ethernet Switch related files. > >>>> > >>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > >>> > >>> Hi Sergey, > >> > >> Hi Simon, long time, no see... :-) > >> > >>> I don't know the back story to this, if there is one. > >> > >> Not much of a history: I got a lot of the rswitch patches in my > >> inbox and I mostly ignored them... but kept deferring this patch due > >> to a high load with fixing Svace's reports at work... > >> > >>> But could I suggest that: > >>> > >>> 1. The patch also updates the title MAINTAINERS section to cover the > >>> remaining two drivers. > >>> > >>> e.g.: RENESAS ETHERNET DRIVERS -> > >>> RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS > >>> > >>> Or alternatively, create separate sections for each driver. > >> > >> Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ > >> Makefile though... > > > > How about adding "COMMON PARTS" section? > > > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth > > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas > > - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > No, this seems too much for these poor little couple files. :-) > Listing them in each new MAINTAINERS entry should achieve the same goal > and seems a biut cleaner... > > >>> n.b.: This may involve moving sections to maintain alphabetical order > >>> by section title > >>> > >>> 2. Reaching out to Shimoda-san (CCed) or other relevant parties > >>> to see if an appropriate maintainer or maintainers for the > >>> Renesas Ethernet Switch driver can be found. > > > > I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. > > Do you want to be a maintainer or just a reviewer (like me)? FWIIW, either option is fine by me. > > > So, if my idea above is acceptable, perhaps the maintainers can be: > > > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey > > There will be separate entries for those... > > > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda > > I'd like to avoid that... :-) > > > - RENESAS ETHERNET SWITCH DRIVER : Shimoda > > >>> n.b.: It may still be a holiday period in Japan for the rest of the week. > >> > >> It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > > > > I'm back from today, but next Monday (8th) is a holiday in Japan :) > > You're back for 1 day? :-) > > > Best regards, > > Yoshihiro Shimoda > > > >>> 3. Rephrase the subject and patch description as splitting out maintenance of > >>> the Renesas Ethernet Switch driver . > > The question that remains still unaddressed: should I do the MAINTAINERS > "directory split" with a single patch? That seems easiest to me. > > [...] > > MBR, Sergey
On Fri, 5 Jan 2024 13:46:32 +0300 Sergey Shtylyov wrote: > > - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > No, this seems too much for these poor little couple files. :-) > Listing them in each new MAINTAINERS entry should achieve the same > goal and seems a biut cleaner... +1, FWIW, you can add them to both or neither. Series purely changing the Makefile / Kconfig are very rare.
Hello Jakub, Sergey, > From: Jakub Kicinski, Sent: Friday, January 5, 2024 11:14 PM > > On Fri, 5 Jan 2024 13:46:32 +0300 Sergey Shtylyov wrote: > > > - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > > > No, this seems too much for these poor little couple files. :-) > > Listing them in each new MAINTAINERS entry should achieve the same > > goal and seems a biut cleaner... > > +1, FWIW, you can add them to both or neither. Series purely changing > the Makefile / Kconfig are very rare. I see. It's a nice idea. Best regards, Yoshihiro Shimoda
Hi Sergey, > From: Sergey Shtylyov, Sent: Friday, January 5, 2024 7:47 PM > > On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote: > [...] > > >>>> I don't know this hardware, I don't have the manuals for it, so I can't > >>>> provide a good review. Let's exclude the Ethernet Switch related files. > >>>> > >>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > >>> > >>> Hi Sergey, > >> > >> Hi Simon, long time, no see... :-) > >> > >>> I don't know the back story to this, if there is one. > >> > >> Not much of a history: I got a lot of the rswitch patches in my > >> inbox and I mostly ignored them... but kept deferring this patch due > >> to a high load with fixing Svace's reports at work... > >> > >>> But could I suggest that: > >>> > >>> 1. The patch also updates the title MAINTAINERS section to cover the > >>> remaining two drivers. > >>> > >>> e.g.: RENESAS ETHERNET DRIVERS -> > >>> RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS > >>> > >>> Or alternatively, create separate sections for each driver. > >> > >> Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ > >> Makefile though... > > > > How about adding "COMMON PARTS" section? > > > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth > > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas > > - RENESAS ETHERNET SWITCH DRIVER : For rswitch > > No, this seems too much for these poor little couple files. :-) > Listing them in each new MAINTAINERS entry should achieve the same goal > and seems a biut cleaner... As I replied on other thread, I think Jakub's idea is good. > >>> n.b.: This may involve moving sections to maintain alphabetical order > >>> by section title > >>> > >>> 2. Reaching out to Shimoda-san (CCed) or other relevant parties > >>> to see if an appropriate maintainer or maintainers for the > >>> Renesas Ethernet Switch driver can be found. > > > > I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. > > Do you want to be a maintainer or just a reviewer (like me)? I want just a reviewer. > > So, if my idea above is acceptable, perhaps the maintainers can be: > > > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey > > There will be separate entries for those... > > > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda > > I'd like to avoid that... :-) > > > - RENESAS ETHERNET SWITCH DRIVER : Shimoda > > >>> n.b.: It may still be a holiday period in Japan for the rest of the week. > >> > >> It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > > > > I'm back from today, but next Monday (8th) is a holiday in Japan :) > > You're back for 1 day? :-) Yes :) > > Best regards, > > Yoshihiro Shimoda > > > >>> 3. Rephrase the subject and patch description as splitting out maintenance of > >>> the Renesas Ethernet Switch driver . > > The question that remains still unaddressed: should I do the MAINTAINERS > "directory split" with a single patch? As Simon-san mentioned, a single patch is easy, I think. Best regards, Yoshihiro Shimoda > [...] > > MBR, Sergey
Index: net/MAINTAINERS =================================================================== --- net.orig/MAINTAINERS +++ net/MAINTAINERS @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@vger.kernel.org F: Documentation/devicetree/bindings/net/renesas,*.yaml F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* +X: drivers/net/ethernet/renesas/rswitch.* RENESAS IDT821034 ASoC CODEC M: Herve Codina <herve.codina@bootlin.com>
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files. Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- The patch is against the 'main' branch of DaveM's 'net.git' repo... MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)