| Message ID | 3340ff84-8d7a-404b-8268-732c7f281164@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5733d139a6745382c733020c7d60a1cf9fb1fc29 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] lan743x: remove redundant statement in lan743x_ethtool_get_eee | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 5 Jan 2024 23:19:02 +0100 you wrote: > eee_active is set by phy_ethtool_get_eee() already, using the same > logic plus an additional check against link speed/duplex values. > See genphy_c45_eee_is_active() for details. > So we can remove this line. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] lan743x: remove redundant statement in lan743x_ethtool_get_eee https://git.kernel.org/netdev/net-next/c/5733d139a674 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index 8c4a2bb6a..a2b3f4433 100644 --- a/drivers/net/ethernet/microchip/lan743x_ethtool.c +++ b/drivers/net/ethernet/microchip/lan743x_ethtool.c @@ -1077,7 +1077,6 @@ static int lan743x_ethtool_get_eee(struct net_device *netdev, buf = lan743x_csr_read(adapter, MAC_CR); if (buf & MAC_CR_EEE_EN_) { eee->eee_enabled = true; - eee->eee_active = !!(eee->advertised & eee->lp_advertised); eee->tx_lpi_enabled = true; /* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */ buf = lan743x_csr_read(adapter, MAC_EEE_TX_LPI_REQ_DLY_CNT);
eee_active is set by phy_ethtool_get_eee() already, using the same logic plus an additional check against link speed/duplex values. See genphy_c45_eee_is_active() for details. So we can remove this line. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 1 - 1 file changed, 1 deletion(-)