| Message ID | 305898fb-6bd4-4749-806c-05ec51bbeb80@moroto.mountain (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a9668169961106f3598384fe95004106ec191201 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [1/2] HID: hid-steam: remove pointless error message | expand |
On Fri, 12 Jan 2024 17:34:14 +0300, Dan Carpenter wrote: > This error message doesn't really add any information. If modprobe > fails then the user will already know what the error code is. In the > case of kmalloc() it's a style violation to print an error message for > that because kmalloc has it's own better error messages built in. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.8/upstream-fixes), thanks! [1/2] HID: hid-steam: remove pointless error message https://git.kernel.org/hid/hid/c/a96681699611 [2/2] HID: hid-steam: Fix cleanup in probe() https://git.kernel.org/hid/hid/c/a9f1da09c69f Cheers,
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index b3c4e50e248a..59df6ead7b54 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -1109,10 +1109,9 @@ static int steam_probe(struct hid_device *hdev, return hid_hw_start(hdev, HID_CONNECT_DEFAULT); steam = devm_kzalloc(&hdev->dev, sizeof(*steam), GFP_KERNEL); - if (!steam) { - ret = -ENOMEM; - goto steam_alloc_fail; - } + if (!steam) + return -ENOMEM; + steam->hdev = hdev; hid_set_drvdata(hdev, steam); spin_lock_init(&steam->lock); @@ -1179,9 +1178,6 @@ static int steam_probe(struct hid_device *hdev, cancel_work_sync(&steam->work_connect); cancel_delayed_work_sync(&steam->mode_switch); cancel_work_sync(&steam->rumble_work); -steam_alloc_fail: - hid_err(hdev, "%s: failed with error %d\n", - __func__, ret); return ret; }
This error message doesn't really add any information. If modprobe fails then the user will already know what the error code is. In the case of kmalloc() it's a style violation to print an error message for that because kmalloc has it's own better error messages built in. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/hid/hid-steam.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)