| Message ID | 20240116020201.1883023-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 03fb8565c880d57952d9b4ba0b36468bae52b554 |
| Headers | show |
| Series | [net] selftests: bonding: add missing build configs | expand |
On 1/16/24 7:02 AM, Jakub Kicinski wrote: > bonding tests also try to create bridge, veth and dummy > interfaces. These are not currently listed in config. > > Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") > Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > CC: j.vosburgh@gmail.com > CC: andy@greyhouse.net > CC: shuah@kernel.org > CC: bpoirier@nvidia.com > CC: jon.toppins+linux@gmail.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/drivers/net/bonding/config | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config > index 70638fa50b2c..f85b16fc5128 100644 > --- a/tools/testing/selftests/drivers/net/bonding/config > +++ b/tools/testing/selftests/drivers/net/bonding/config > @@ -1,2 +1,5 @@ > CONFIG_BONDING=y > +CONFIG_BRIDGE=y > +CONFIG_DUMMY=y > CONFIG_MACVLAN=y > +CONFIG_VETH=y
On 2024-01-15 18:02 -0800, Jakub Kicinski wrote: > bonding tests also try to create bridge, veth and dummy > interfaces. These are not currently listed in config. > > Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") > Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: j.vosburgh@gmail.com > CC: andy@greyhouse.net > CC: shuah@kernel.org > CC: bpoirier@nvidia.com > CC: jon.toppins+linux@gmail.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/drivers/net/bonding/config | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config > index 70638fa50b2c..f85b16fc5128 100644 > --- a/tools/testing/selftests/drivers/net/bonding/config > +++ b/tools/testing/selftests/drivers/net/bonding/config > @@ -1,2 +1,5 @@ > CONFIG_BONDING=y > +CONFIG_BRIDGE=y > +CONFIG_DUMMY=y > CONFIG_MACVLAN=y > +CONFIG_VETH=y > -- Hi, I tested using the minimal config generated by virtme-ng and the following additional config options need to be enabled for bonding tests: CONFIG_IPV6=y CONFIG_NET_ACT_GACT=y CONFIG_NET_CLS_FLOWER=y CONFIG_NET_SCH_INGRESS=y CONFIG_NLMON=y
On Tue, 16 Jan 2024 09:37:40 -0500 Benjamin Poirier wrote: > I tested using the minimal config generated by virtme-ng and the > following additional config options need to be enabled for bonding > tests: > CONFIG_IPV6=y > CONFIG_NET_ACT_GACT=y > CONFIG_NET_CLS_FLOWER=y > CONFIG_NET_SCH_INGRESS=y > CONFIG_NLMON=y Perfect! Could you post a patch to add those? I'll apply this one right away to avoid conflicts. Fixes tags would be good to have, if you don't feel like finding each individual commit you can point at mine :)
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 15 Jan 2024 18:02:01 -0800 you wrote: > bonding tests also try to create bridge, veth and dummy > interfaces. These are not currently listed in config. > > Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") > Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > [...] Here is the summary with links: - [net] selftests: bonding: add missing build configs https://git.kernel.org/netdev/net/c/03fb8565c880 You are awesome, thank you!
diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config index 70638fa50b2c..f85b16fc5128 100644 --- a/tools/testing/selftests/drivers/net/bonding/config +++ b/tools/testing/selftests/drivers/net/bonding/config @@ -1,2 +1,5 @@ CONFIG_BONDING=y +CONFIG_BRIDGE=y +CONFIG_DUMMY=y CONFIG_MACVLAN=y +CONFIG_VETH=y
bonding tests also try to create bridge, veth and dummy interfaces. These are not currently listed in config. Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: j.vosburgh@gmail.com CC: andy@greyhouse.net CC: shuah@kernel.org CC: bpoirier@nvidia.com CC: jon.toppins+linux@gmail.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/drivers/net/bonding/config | 3 +++ 1 file changed, 3 insertions(+)