[v6,1/8] dt-bindings: adc: ad9467: add new io-backend property

Commit Message

Nuno Sa via B4 Relay Jan. 19, 2024, 4 p.m. UTC

From: Nuno Sa <[e-mail]>

The ad9467 will make use of the new IIO backend framework which is a
provider - consumer interface where IIO backends provide services to
consumers. As such, and being this device a consumer,  add the new
generic io-backend property to the bindings.

Reviewed-by: Rob Herring <[e-mail]>
Signed-off-by: Nuno Sa <[e-mail]>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring (Arm) Jan. 19, 2024, 5:15 p.m. UTC | #1

On Fri, 19 Jan 2024 17:00:47 +0100, Nuno Sa wrote:
> The ad9467 will make use of the new IIO backend framework which is a
> provider - consumer interface where IIO backends provide services to
> consumers. As such, and being this device a consumer,  add the new
> generic io-backend property to the bindings.
> 
> Reviewed-by: Rob Herring <[e-mail]>
> Signed-off-by: Nuno Sa <[e-mail]>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml: io-backends: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[e-mail]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Rob Herring (Arm) Jan. 22, 2024, 3:37 p.m. UTC | #2

On Fri, Jan 19, 2024 at 11:15:54AM -0600, Rob Herring wrote:
> 
> On Fri, 19 Jan 2024 17:00:47 +0100, Nuno Sa wrote:
> > The ad9467 will make use of the new IIO backend framework which is a
> > provider - consumer interface where IIO backends provide services to
> > consumers. As such, and being this device a consumer,  add the new
> > generic io-backend property to the bindings.
> > 
> > Reviewed-by: Rob Herring <[e-mail]>
> > Signed-off-by: Nuno Sa <[e-mail]>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml: io-backends: missing type definition

Are you going to update the GH PR so I can apply adding io-backends?

Rob

Nuno Sá Jan. 22, 2024, 4:01 p.m. UTC | #3

On Mon, 2024-01-22 at 09:37 -0600, Rob Herring wrote:
> On Fri, Jan 19, 2024 at 11:15:54AM -0600, Rob Herring wrote:
> > 
> > On Fri, 19 Jan 2024 17:00:47 +0100, Nuno Sa wrote:
> > > The ad9467 will make use of the new IIO backend framework which is a
> > > provider - consumer interface where IIO backends provide services to
> > > consumers. As such, and being this device a consumer,  add the new
> > > generic io-backend property to the bindings.
> > > 
> > > Reviewed-by: Rob Herring <[e-mail]>
> > > Signed-off-by: Nuno Sa <[e-mail]>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-
> > ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml: io-backends:
> > missing type definition
> 
> Are you going to update the GH PR so I can apply adding io-backends?
> 
> 

Yes, I can do that. I was thinking you preferred to have the second user so I was
planning in updating only after sending out that series (or Olivier if he ends up
sending his series first).

Olivier already gave his ack in [1], but I guess you would also like Jonathan's ack
on that PULL right?

Jonathan,
would that be something you can do? The pull is in [2]... Maybe give your
comments/review in there if any.


[2]: https://github.com/devicetree-org/dt-schema/pull/120
[1]: https://lore.kernel.org/linux-iio/[e-mail]/

- Nuno Sá

Jonathan Cameron Jan. 22, 2024, 7:16 p.m. UTC | #4

On Mon, 22 Jan 2024 17:01:57 +0100
Nuno Sá <[e-mail]> wrote:

> On Mon, 2024-01-22 at 09:37 -0600, Rob Herring wrote:
> > On Fri, Jan 19, 2024 at 11:15:54AM -0600, Rob Herring wrote:  
> > > 
> > > On Fri, 19 Jan 2024 17:00:47 +0100, Nuno Sa wrote:  
> > > > The ad9467 will make use of the new IIO backend framework which is a
> > > > provider - consumer interface where IIO backends provide services to
> > > > consumers. As such, and being this device a consumer,  add the new
> > > > generic io-backend property to the bindings.
> > > > 
> > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > Signed-off-by: Nuno Sa <[e-mail]>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >   
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-
> > > ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml: io-backends:
> > > missing type definition  
> > 
> > Are you going to update the GH PR so I can apply adding io-backends?
> > 
> >   
> 
> Yes, I can do that. I was thinking you preferred to have the second user so I was
> planning in updating only after sending out that series (or Olivier if he ends up
> sending his series first).
> 
> Olivier already gave his ack in [1], but I guess you would also like Jonathan's ack
> on that PULL right?
> 
> Jonathan,
> would that be something you can do? The pull is in [2]... Maybe give your
> comments/review in there if any.

Looks like there is a comment on Rob still to address about io-backend-names.
Otherwise I'm fine with it.

J

> 
> 
> [2]: https://github.com/devicetree-org/dt-schema/pull/120
> [1]: https://lore.kernel.org/linux-iio/[e-mail]/
> 
> - Nuno Sá
>

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
index 7aa748d6b7a0..eecd5fbab695 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
@@ -44,6 +44,9 @@  properties:
       Pin that controls the powerdown mode of the device.
     maxItems: 1
 
+  io-backends:
+    maxItems: 1
+
   reset-gpios:
     description:
       Reset pin for the device.
@@ -68,6 +71,7 @@  examples:
             reg = <0>;
             clocks = <&adc_clk>;
             clock-names = "adc-clk";
+            io-backends = <&iio_backend>;
         };
     };
 ...